DPDK patches and discussions
 help / color / mirror / Atom feed
From: Radha Mohan <mohun106@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dpdk-dev <dev@dpdk.org>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	 Radha Mohan Chintakuntla <radhac@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] usertools/devbind: remove octeontx2 DMA device
Date: Mon, 8 Nov 2021 22:57:39 -0500	[thread overview]
Message-ID: <CAC8NTUVY-5EzjYVTvSRyD2-EtScMbfHCwQxNPDMpKBBroPR8Bw@mail.gmail.com> (raw)
In-Reply-To: <20211107225708.3087968-1-thomas@monjalon.net>

On Sun, Nov 7, 2021 at 5:57 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The DMA raw driver for octeontx2 was removed in DPDK 21.11.
> The binding ability is also removed in the same release
> to be consistent.
>
> Fixes: a59745ebccf0 ("raw/octeontx2_dma: remove driver")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> ---
>
> Is there a reason to keep it?

Need to modify.

> ---
>  usertools/dpdk-devbind.py | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index af9a0ad5ab..95921b2281 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
> @@ -41,8 +41,6 @@
>                   'SVendor': None, 'SDevice': None}
>  octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
>                   'SVendor': None, 'SDevice': None}
> -octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
> -                 'SVendor': None, 'SDevice': None}
>  octeontx2_ree = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f4',
>                   'SVendor': None, 'SDevice': None}
>  cnxk_bphy = {'Class': '08', 'Vendor': '177d', 'Device': 'a089',
> @@ -80,8 +78,8 @@
>  mempool_devices = [cavium_fpa, octeontx2_npa]
>  compress_devices = [cavium_zip]
>  regex_devices = [octeontx2_ree]
> -misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev, intel_ntb_skx,
> -                intel_ntb_icx, octeontx2_dma]
> +misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev,
> +                intel_ntb_icx, intel_ntb_skx]
>
>  # global dict ethernet devices present. Dictionary indexed by PCI address.
>  # Each device within this is itself a dictionary of device properties
> --
> 2.33.0
>

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index bb00f43702..643860b3ae 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -41,7 +41,7 @@
                  'SVendor': None, 'SDevice': None}
 octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
                  'SVendor': None, 'SDevice': None}
-octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
+cnxk_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
                  'SVendor': None, 'SDevice': None}
 octeontx2_ree = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f4',
                  'SVendor': None, 'SDevice': None}
@@ -71,13 +71,14 @@
 network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class]
 baseband_devices = [acceleration_class]
 crypto_devices = [encryption_class, intel_processor_class]
-dma_devices = [intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx]
+dma_devices = [intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx
+               cnxk_dma]
 eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, octeontx2_sso]
 mempool_devices = [cavium_fpa, octeontx2_npa]
 compress_devices = [cavium_zip]
 regex_devices = [octeontx2_ree]
-misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev, intel_ntb_skx,
-                intel_ntb_icx, octeontx2_dma]
+misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev,
+                intel_ntb_skx, intel_ntb_icx]

  reply	other threads:[~2021-11-09  3:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-07 22:57 Thomas Monjalon
2021-11-09  3:57 ` Radha Mohan [this message]
2021-11-09  8:10   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAC8NTUVY-5EzjYVTvSRyD2-EtScMbfHCwQxNPDMpKBBroPR8Bw@mail.gmail.com \
    --to=mohun106@gmail.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=radhac@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).