From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id C4F5FA0C4B;
Tue, 9 Nov 2021 04:53:02 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4F2F740687;
Tue, 9 Nov 2021 04:53:02 +0100 (CET)
Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com
[209.85.167.43]) by mails.dpdk.org (Postfix) with ESMTP id 352E840151
for <dev@dpdk.org>; Tue, 9 Nov 2021 04:53:01 +0100 (CET)
Received: by mail-lf1-f43.google.com with SMTP id o18so41165986lfu.13
for <dev@dpdk.org>; Mon, 08 Nov 2021 19:53:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=mzIIK6JH126UOszIx9ZYJhPozojWyRRGDpZm7ROdo4Y=;
b=Z6WqjLsQLTOP6isEjJKgMtQMgKsyDO95YR2iqtr2YqTbh0tzLbMc8dP951a1pq/tAK
B99T0sydwx6BlDNB/XAdSjmIZZI9UzX6eN1hoF48Tmp18m96wjlMFQTjapPu+GHW+/RQ
R2xCrBp1G+ZZWQxacFzYDzWhT3/ccxuMntpCEY3bpFPeALeXq52rQAcqj4jpIZB92RBk
oeS964Q6WaEw4YHnMX2KPJ0QmAGD7BFaX3B+HQ3S4q97QZ1oY22dGd+95FxHkjjX8DSy
6/jkl8RJpXQ08CaXuY1J8X7h33Xc99QcqKHUSyTiq+PJ9XN7Y/mknZCxf9K0orhQImyL
FEMw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=mzIIK6JH126UOszIx9ZYJhPozojWyRRGDpZm7ROdo4Y=;
b=7m9Usyyzk28bWSXPRrhiIHYPZff7VYZvv38W8LZsFar+V9dUZw7NrJjFmcO06ABLyJ
YsvzImTwhfJnBFuhvFsdxwUnp87auFUY2UowT+ZtFcjJ1NpMLVZV79WfBvRbt4CZIPzA
YIzsSZlB+UDs2UEWBrPICC8l50AfP76e7Z7p9Z0GNgumYHFK9o7cOU6mQSl1sStjBj+E
wIu2lhdHbZousFmCM1D12tyBHBV7Q94bnVxPFQYyxd5V1xC6NceLplC9zRjti4ih1oO0
fY5VoRHZIDQ/kaFT+3hh/vCgERd2tJkq9HtuBY5ADWmYUhz/tM+DqhVscg0T76y8cjCH
x50w==
X-Gm-Message-State: AOAM533ByPC5Xe87Z590AAAQ8CJjAEKKiLdhdEouBRnW0knoSBHj5CgL
LRcjhKwweLBSL7lScGyYi+zbYqq78fiYrjJFkrg=
X-Google-Smtp-Source: ABdhPJy79s8AvdownW4GzzT4VQxUUQ77mefsEFRbsWn5T/0gHOTlkUOV+NrodxCsDJYUjp+HDxuNQtRnnE+50b8GFJQ=
X-Received: by 2002:a05:6512:1284:: with SMTP id
u4mr4225678lfs.342.1636429980623;
Mon, 08 Nov 2021 19:53:00 -0800 (PST)
MIME-Version: 1.0
References: <20211102034019.28900-1-radhac@marvell.com>
<20211103180150.10416-1-radhac@marvell.com>
<20211103180150.10416-2-radhac@marvell.com> <8895158.tUXmiChmOE@thomas>
In-Reply-To: <8895158.tUXmiChmOE@thomas>
From: Radha Mohan <mohun106@gmail.com>
Date: Mon, 8 Nov 2021 22:52:49 -0500
Message-ID: <CAC8NTUW=ieB8MyH-Mf6ufxABWjgiJCW0Hv9LuHuyt4VUA7pqQw@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Radha Mohan Chintakuntla <radhac@marvell.com>,
Chengwen Feng <fengchengwen@huawei.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Satananda Burla <sburla@marvell.com>, dpdk-dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3 2/5] dma/cnxk: create and initialize
dmadev on pci probe
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Sun, Nov 7, 2021 at 6:04 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 03/11/2021 19:01, Radha Mohan Chintakuntla:
> > This patch creates and initializes a dmadev device on pci probe.
> >
> > Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
>
> Series applied with few small improvements in the doc,
> compilation and other more or less important details
> like the release notes.
Thank you.
>
> I think you forgot to update dpdk-devbind script.
> See also this patch:
> https://patches.dpdk.org/project/dpdk/patch/20211107225708.3087968-1-thomas@monjalon.net/
Yes need to remove it from "misc" but also rename octeontx2_dma to
cnxk_dma and add under "dma_devices". I missed this.
I can push a patch which does both or if are ok to update yours then
that would be great.
diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index bb00f43702..643860b3ae 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -41,7 +41,7 @@
'SVendor': None, 'SDevice': None}
octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
'SVendor': None, 'SDevice': None}
-octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
+cnxk_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
'SVendor': None, 'SDevice': None}
octeontx2_ree = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f4',
'SVendor': None, 'SDevice': None}
@@ -71,13 +71,14 @@
network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class]
baseband_devices = [acceleration_class]
crypto_devices = [encryption_class, intel_processor_class]
-dma_devices = [intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx]
+dma_devices = [intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx
+ cnxk_dma]
eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, octeontx2_sso]
mempool_devices = [cavium_fpa, octeontx2_npa]
compress_devices = [cavium_zip]
regex_devices = [octeontx2_ree]
-misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev, intel_ntb_skx,
- intel_ntb_icx, octeontx2_dma]
+misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev,
+ intel_ntb_skx, intel_ntb_icx]
>
> Overall I have doubts about the quality but I want to move forward
> with the new DMA drivers.
> I will be probably less flexible with the next patches.
Ok. Please let know if you find any specific ones that needs improvements.
>
>