From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04BE0A034F; Wed, 10 Nov 2021 00:24:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9165840683; Wed, 10 Nov 2021 00:24:24 +0100 (CET) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by mails.dpdk.org (Postfix) with ESMTP id 5BC4640142 for ; Wed, 10 Nov 2021 00:24:23 +0100 (CET) Received: by mail-lj1-f174.google.com with SMTP id z8so1558531ljz.9 for ; Tue, 09 Nov 2021 15:24:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+xHWvwTd6SXrLYk3wCucBmSRRMLGczyPO1Uo73klGe4=; b=MpZgIhjOkeRA5U1Kg6lzUENeerBHtWUx92cfB8ypk6PTK36Fo+ols2wborLKc7QziV TNhjz49s1d6jrPA3usoGu+y2q6wbrqFerr4BQGe/1RODelm3hYz7lybGjD7GEbxDIrvS sn7i5n6ohqiqrBxI5dK+Mw5HhikfHCpWh93jXAI6v6Lu1L9GpMJb6xgrAMJETMjqVGZc ZyXyn88tJfTH4leznt7Lda3/LH9gcxpzcYpmLQs582Z8aqmTAOkPPsnckAONDtA9tZQH +f+DN7g8a8CoCl6IiNGykLQb7C985LO5FZYzE9SDOqxAmPP2buQwGBKeRlGUPxRXyRMB FDBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+xHWvwTd6SXrLYk3wCucBmSRRMLGczyPO1Uo73klGe4=; b=U3EWKviE1Ku7Z5FQxEe6ym8AeDGwsXlrux0A+wHhOCWDDN55x7bPSrNCjLf1YZHZUW W7xMDl4KZ8SSO0Q43Oglz0Fv7/CJWANwixAa0MMc6BAD0/Hs5XyHTm1FPRi4kdr5uSJy V4hYx63q2/3u6FiKKzr5KDxXMsO38/qkIdo5/Eqa5eZfwCnLWnN0fKSukqV/WStX1gS2 ScnKhqn3QfEeTrsVy0efz7anWvoH4VtKQMUNDTcx/bZf7cP8e/WOrYis9Ui4ubwqKjGo YOJV3xkKvEgOfsx4Gxx9lycAg3U0Fn8H247AoRr64+W98wh6lUO+f90WDmlp294BvvHG fI/A== X-Gm-Message-State: AOAM533+GMrAkWcQK3FN335X1FN4HqJKVz6a0XxusW18b9iPSDnttVS8 16Y/mZIt4L7blDOr+U+FYcH+buL13MTVXMfKOS0= X-Google-Smtp-Source: ABdhPJxOT1HkjfYncAfyRnEMqqOgubYo749P0zRGONJi494IQwRQoBWvJZcK7/O63jnIMtY3N2FQeZgi0SRjDn+3/6E= X-Received: by 2002:a05:651c:551:: with SMTP id q17mr11365254ljp.202.1636500262744; Tue, 09 Nov 2021 15:24:22 -0800 (PST) MIME-Version: 1.0 References: <20211109165540.21684-1-radhac@marvell.com> <6995554.cnLEcGnZd8@thomas> In-Reply-To: <6995554.cnLEcGnZd8@thomas> From: Radha Mohan Date: Tue, 9 Nov 2021 15:24:11 -0800 Message-ID: To: Thomas Monjalon Cc: Radha Mohan Chintakuntla , Chengwen Feng , dpdk-dev , Satananda Burla Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] usertools/devbind: update octeontx2 DMA device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 9, 2021 at 12:50 PM Thomas Monjalon wrote: > > 09/11/2021 17:55, Radha Mohan Chintakuntla: > > The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver > > for the same device uses the dmadev. So this patch updates the device > > naming and lists it under dma devices section. > > > > Signed-off-by: Radha Mohan Chintakuntla > > --- > > usertools/dpdk-devbind.py | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py > > index af9a0ad5ab..e298ad5f75 100755 > > --- a/usertools/dpdk-devbind.py > > +++ b/usertools/dpdk-devbind.py > > @@ -41,8 +41,8 @@ > > 'SVendor': None, 'SDevice': None} > > octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc', > > 'SVendor': None, 'SDevice': None} > > -octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081', > > - 'SVendor': None, 'SDevice': None} > > +cnxk_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081', > > + 'SVendor': None, 'SDevice': None} > > It doesn't look logical to have cnxk device in the middle of octeontx2 ones. > Maybe before to sort it a bit alphabetically? ok sure will do. I thought about it but rest of them were not in any order so didn't think it wouldn't matter. > > > dma_devices = [hisilicon_dma, > > - intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx] > > + intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx, > > + cnxk_dma] > > Would be better at the beginning of the list, before hisilicon > so it is alphabetically sorted. ok. > > >