From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stefan.puiu@gmail.com>
Received: from mail-io0-f193.google.com (mail-io0-f193.google.com
 [209.85.223.193]) by dpdk.org (Postfix) with ESMTP id 543BC10A7
 for <dev@dpdk.org>; Mon, 12 Dec 2016 09:27:30 +0100 (CET)
Received: by mail-io0-f193.google.com with SMTP id b194so20028250ioa.3
 for <dev@dpdk.org>; Mon, 12 Dec 2016 00:27:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=7P/EBoVJRkXmfm7ACp1ysqRTL2c3U25ekHT0mGY/FPY=;
 b=ntxx/xbLfRHeYLmKN1d+MWquvUhOQlqykOX6v6vII00kmSnyN+6yicJxw9WhpqojWc
 TD+ClWlVTyyPCC45AdsgJ4iO/fQv9yndpldsiXZ1xnGtlKgbzh13QGfWQA6AUGWgz6uI
 0z2fvq8XBbtYYzC8a8GL9ce91kA2LNrJ7BnRJm5zrVQu0/qMLy0WnJxuKEV64TVaIq3S
 AoMn+1WdSY0r9ZSS9XKFse70+cPE+XluKKcvqTVKeR1+kTFLHNYAUS+F3JmU8WZ+chKU
 phv+iCzMFCN+r1mdKM+YqXJGyPFATnkN2WzTEn01mrt57WY6IzKPI/g7n/xUXJwWQCPp
 tLqA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=7P/EBoVJRkXmfm7ACp1ysqRTL2c3U25ekHT0mGY/FPY=;
 b=Bnmw00ucMJpBG8DfYRIgf2ncsf4CVKoK91L4UEiUxlJ2QFvpcczKPZuUBlgt/KpAU6
 ev3ydXJCEVhKAgAqATH5xdJGSNAS+vSZ2piObmk+Lt6hvvEDAKuTIu53NwEybqkMW23j
 Y8CDqEUW9dMukepo9DS8hdiK6b+QTdhgOJLlsxceB4CTn6QQgK+DnaelnpbaSuLLzxFk
 fswbeROjLOAOegSkZTjC79i/wNV+81UwVVdlHvo0DZZAdpt9w0PCFUzP4F/Cu8BrKNiB
 8URIfJzaeOO3iKF4VDNz9QL2Nj2WUvFw2OdziRCzO0opDIyihidcu04bPYgtEjmkMNMJ
 aZ5A==
X-Gm-Message-State: AKaTC02NQSNON4ymlpdyQQu+umh+K1yLnlUhbpzow7ECR/VNQTiIF+tpyGzqI5x7CR5792PkEqAxh4iOG/zYug==
X-Received: by 10.36.253.139 with SMTP id m133mr16826202ith.119.1481531249636; 
 Mon, 12 Dec 2016 00:27:29 -0800 (PST)
MIME-Version: 1.0
Received: by 10.36.106.6 with HTTP; Mon, 12 Dec 2016 00:27:29 -0800 (PST)
In-Reply-To: <BY2PR05MB2359E5B448AFCF17B7713738AF8C0@BY2PR05MB2359.namprd05.prod.outlook.com>
References: <1479120376-48723-1-git-send-email-stefan.puiu@gmail.com>
 <BY2PR05MB2359E5B448AFCF17B7713738AF8C0@BY2PR05MB2359.namprd05.prod.outlook.com>
From: Stefan Puiu <stefan.puiu@gmail.com>
Date: Mon, 12 Dec 2016 10:27:29 +0200
Message-ID: <CACKs7VAJDu6aMY6tLJXcM4doS8diZkAOidVCRZwR6u1RTuRaDQ@mail.gmail.com>
To: Yong Wang <yongwang@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "mac_leehk@yahoo.com.hk" <mac_leehk@yahoo.com.hk>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [dpdk-dev] [PATCH] vmxnet3: fix Rx deadlock
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Dec 2016 08:27:30 -0000

Hello and thanks for reviewing the patch.

On Wed, Nov 30, 2016 at 6:59 AM, Yong Wang <yongwang@vmware.com> wrote:
[...]
> I think a more accurate description is that the particular descriptor's generation bit never got flipped properly when an mbuf failed to be refilled which caused the rx stuck, rather than vmxnet3_post_rx_bufs() not being called afterwards.
>

Not sure if this kind of level of detail is useful, but if you can
think of a better explanation to put in the changelist, I can add it.
I see the generation bit not flipping as a symptom, while the core
problem is the hardware can't write to the descriptor. I felt the
explanation was going into too much detail anyway, so I've reworded it
a bit for v2. Let me know what you think.

Thanks,
Stefan.