From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f178.google.com (mail-ie0-f178.google.com [209.85.223.178]) by dpdk.org (Postfix) with ESMTP id C8DE5B52B for ; Fri, 20 Feb 2015 09:34:47 +0100 (CET) Received: by iecrl12 with SMTP id rl12so6243214iec.4 for ; Fri, 20 Feb 2015 00:34:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=bIZPzMisHvPSAiQwVWbVodEJ4jbE0xB/LhqOmr9gAzE=; b=N7Mbmr9LgZWnDaPpawyn/KEmAHW4heLSW/+UZgiG7d3dFlp2NyiT+U8/pLmuh9SDyy KHbEZ95wP5v3K2akAWpMNqtQyeKq7dJtsdZVOluyAIU9jnEZTvP4r+H5NdEFwSJMglx6 2YjPoNR6iTQ6LMhSYGHiOTdkf1hQf2r+7kuoDJmQ5RnXrpkPcoFWQ5zoKXE8pX34d6py h+fN+2zxqygbHDvO8ob2FVx0GC4psCjj/MGJfeOhYUbfeYY0pyLCbzXu/7EDWJUaedkL l0H4gnle3PYnuVUJnrAEMYgSbrlU56pqSXauCw4SMVesnzGd0X6MtQg3VizOGuzUiAYs MWVw== MIME-Version: 1.0 X-Received: by 10.43.78.132 with SMTP id zm4mr10839180icb.81.1424421287268; Fri, 20 Feb 2015 00:34:47 -0800 (PST) Received: by 10.36.60.207 with HTTP; Fri, 20 Feb 2015 00:34:47 -0800 (PST) In-Reply-To: References: <1424379569-15851-1-git-send-email-stefan.puiu@gmail.com> <1424379569-15851-2-git-send-email-stefan.puiu@gmail.com> Date: Fri, 20 Feb 2015 10:34:47 +0200 Message-ID: From: Stefan Puiu To: "De Lara Guarch, Pablo" Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" , Stefan Puiu Subject: Re: [dpdk-dev] [PATCH] Fix compilation error when compiling with clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a space in between. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 08:34:48 -0000 Hi Pablo, On Fri, Feb 20, 2015 at 10:19 AM, De Lara Guarch, Pablo wrote: > Hi Stefan, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stefan Puiu >> Sent: Thursday, February 19, 2015 8:59 PM >> To: dev@dpdk.org >> Cc: Stefan Puiu >> Subject: [dpdk-dev] [PATCH] Fix compilation error when compiling with >> clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a >> space in between. >> >> From: Stefan Puiu >> >> Sample error message: >> dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 requires a >> space between literal and identifier [-Wreserved-user-defined-literal] > > You forgot to include "Signed-off". Oops, you're right. I'll resend. Thanks for looking over this. Stefan. > > Pablo >> --- >> lib/librte_eal/common/include/rte_pci.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lib/librte_eal/common/include/rte_pci.h >> b/lib/librte_eal/common/include/rte_pci.h >> index 66ed793..12ae5a7 100644 >> --- a/lib/librte_eal/common/include/rte_pci.h >> +++ b/lib/librte_eal/common/include/rte_pci.h >> @@ -93,10 +93,10 @@ extern struct pci_device_list pci_device_list; /**< >> Global list of PCI devices. >> #define SYSFS_PCI_DEVICES "/sys/bus/pci/devices" >> >> /** Formatting string for PCI device identifier: Ex: 0000:00:01.0 */ >> -#define PCI_PRI_FMT "%.4"PRIx16":%.2"PRIx8":%.2"PRIx8".%"PRIx8 >> +#define PCI_PRI_FMT "%.4" PRIx16 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 >> >> /** Short formatting string, without domain, for PCI device: Ex: 00:01.0 */ >> -#define PCI_SHORT_PRI_FMT "%.2"PRIx8":%.2"PRIx8".%"PRIx8 >> +#define PCI_SHORT_PRI_FMT "%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 >> >> /** Nb. of values in PCI device identifier format string. */ >> #define PCI_FMT_NVAL 4 >> -- >> 1.7.9.5 >