From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f172.google.com (mail-ie0-f172.google.com [209.85.223.172]) by dpdk.org (Postfix) with ESMTP id 22413B5AB for ; Fri, 20 Feb 2015 13:22:41 +0100 (CET) Received: by iecrd18 with SMTP id rd18so7294451iec.8 for ; Fri, 20 Feb 2015 04:22:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Y0KwZr9ZXNMl4Z7Kl0Q+4PExhNsxFgr4cxTsjCkcT+k=; b=EbptkDG978wlutRJkXIg2AJhzJy9+uOjkREcZ9gKVWVSK1Yt5DHe/i7lYMb9GSsag/ 1gHLdbF5HSnUvf1oZqcRjp1El0IEqkQvxdwyqH4DA4dPFa+KmOCPUS4jfZNO9DkkojH9 drMEm6yQ9mQyg1ONaJ+ZpLqTPLLfxUfAH4BOm7enX75VVtQeWlk3wuDj+h1njGHFbsBY c0AtGPUJTjbwddHlcBctg1IoL02it+WJkfouQiQ8RXHxd5dRCNmeHekuwIkYScGAcg3j O2p0p0Qo0PHclX8bOYrK6HbiFKeU7GquYuXjvK7m1AQ5UKxpVJKK7dEO9Gp65wYjBSyd bnpA== MIME-Version: 1.0 X-Received: by 10.42.0.74 with SMTP id 10mr11552304icb.13.1424434960487; Fri, 20 Feb 2015 04:22:40 -0800 (PST) Received: by 10.36.60.207 with HTTP; Fri, 20 Feb 2015 04:22:40 -0800 (PST) In-Reply-To: <2499656.ale3rhT9Ha@xps13> References: <1424424952-16885-1-git-send-email-stefan.puiu@gmail.com> <2499656.ale3rhT9Ha@xps13> Date: Fri, 20 Feb 2015 14:22:40 +0200 Message-ID: From: Stefan Puiu To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] rte_pci.h: Fix C++11 compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 12:22:41 -0000 Hi, On Fri, Feb 20, 2015 at 1:26 PM, Thomas Monjalon wrote: > Hi Stefan, > > Thanks for improving DPDK for C++ usage. > > I'm a bit lost because that's the fourth time you send the same patch (without versioning): > http://dpdk.org/dev/patchwork/patch/3140/ > (this one had some comments you didn't address) Sorry. I'm new to git-send-email and to patchwork; it seems some versions got through to patchwork but didn't make it to the list? Will have a look at fixing the mess. And I'll address the comments :). > http://dpdk.org/dev/patchwork/patch/3517/ > (is it different from the first one?) > http://dpdk.org/dev/patchwork/patch/3518/ > (this one was wrongly formatted but authored with your ixiacom address) > http://dpdk.org/dev/patchwork/patch/3537/ > (it is different from the first one?) > > Please check http://dpdk.org/dev#send for versioning and set the old versions > to "superseded" in patchwork. > Thanks > > > 2015-02-20 11:35, Stefan Puiu: >> In C++11 concatenated string literals need to have a >> space in between. Found with clang++-3.4, IIRC g++-4.8 also complains about this. >> >> Sample error message: >> dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal] >> >> Signed-off-by: Stefan Puiu >> --- >> lib/librte_eal/common/include/rte_pci.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h >> index 66ed793..12ae5a7 100644 >> --- a/lib/librte_eal/common/include/rte_pci.h >> +++ b/lib/librte_eal/common/include/rte_pci.h >> @@ -93,10 +93,10 @@ extern struct pci_device_list pci_device_list; /**< Global list of PCI devices. >> #define SYSFS_PCI_DEVICES "/sys/bus/pci/devices" >> >> /** Formatting string for PCI device identifier: Ex: 0000:00:01.0 */ >> -#define PCI_PRI_FMT "%.4"PRIx16":%.2"PRIx8":%.2"PRIx8".%"PRIx8 >> +#define PCI_PRI_FMT "%.4" PRIx16 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 >> >> /** Short formatting string, without domain, for PCI device: Ex: 00:01.0 */ >> -#define PCI_SHORT_PRI_FMT "%.2"PRIx8":%.2"PRIx8".%"PRIx8 >> +#define PCI_SHORT_PRI_FMT "%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 >> >> /** Nb. of values in PCI device identifier format string. */ >> #define PCI_FMT_NVAL 4 >> > >