From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f176.google.com (mail-ie0-f176.google.com [209.85.223.176]) by dpdk.org (Postfix) with ESMTP id 59336B54A for ; Fri, 20 Feb 2015 13:26:48 +0100 (CET) Received: by iecvy18 with SMTP id vy18so7242676iec.13 for ; Fri, 20 Feb 2015 04:26:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Pyju7/ge2vns+ZVp5HZTO1LciteLjxfoUftBd+WOjeM=; b=Op7+MBXV/cgz4bMICFKtrZppuPWcyB6jjyKN+ovPJlIONKVvlBjpwd6Sebp5wOt0zF 3q0GxY5otmOl1yQJZXh2e6FFRZix4SCu1oHd+p6vQ3v9LxNQR+CcjNxTY/WEOp8HJniJ SIQ0VZtvLD9kPZ4yIgxS6htsDTCMehSlc9tuDx7HErAETRKMp9rcHiYWBKIo0Ft33ONH OH4/mtQPXNlult75VfpG7MjsHWfgHYRkM8f3YfzbHCGFofr/XYBzy7MQBcuU06x/Op/u JmrKtyus7KUYzmSFWG4nkKalR1HEinXuQMIYDlfAuX/enbKO+LoPinMjp2EXqcXQUmXt KboQ== MIME-Version: 1.0 X-Received: by 10.107.152.211 with SMTP id a202mr12741325ioe.59.1424435207781; Fri, 20 Feb 2015 04:26:47 -0800 (PST) Received: by 10.36.60.207 with HTTP; Fri, 20 Feb 2015 04:26:47 -0800 (PST) In-Reply-To: References: <20150213101732.GA13304@bricha3-MOBL3> Date: Fri, 20 Feb 2015 14:26:47 +0200 Message-ID: From: Stefan Puiu To: "Mcnamara, John" Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 12:26:48 -0000 Hi and thanks for reviewing, I seem to have somehow missed the email for this one and thought it got lost. Sorry. On Fri, Feb 13, 2015 at 12:27 PM, Mcnamara, John wrote: >> -----Original Message----- >> From: Richardson, Bruce >> Sent: Friday, February 13, 2015 10:18 AM >> To: Mcnamara, John >> Cc: Stefan Puiu; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] Minor C++11 compilation fix for rte_pci.h >> >> > > >> > > In C++11 concatenated string literals need to have a space in between. >> > > clang 3.4 reports this as an error (and IIRC also gcc-4.8): >> > > >> > > dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; >> > > C++11 requires a space between literal and identifier >> > > [-Wreserved-user-defined- literal] >> > >> > >> > That concatenated string literal with PRI* is used in 65 files in the >> DPDK source. Is that the only compilation error that you got? >> > >> > John >> >> It should only be a problem in header files. The C files for DPDK source >> are always to be compiled up with a C compiler - only the headers get >> included in application C++ code. >> > > Hi, > > In that case it only occurs in 3 header files. I guess that patch should be extended to include those as well: > > $ find lib -name \*.h | xargs grep -l '"PRI' > lib/librte_vhost/vhost-net-cdev.h > lib/librte_eal/common/include/rte_pci.h > lib/librte_mempool/rte_mempool.h Makes sense. Bruce is right, I'm only including headers from C++, the library is compiled using C. It seems I didn't hit the rte_mempool.h because (at least in 1.8.0) that the usage of PRI* is under #ifdef RTE_LIBRTE_MEMPOOL_DEBUG. It's very likely I didn't need the first file in the list. Anyway, I'll send a new version. > > John. > -- > > > >