From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25616A034C; Fri, 25 Feb 2022 11:30:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F006D4115C; Fri, 25 Feb 2022 11:30:17 +0100 (CET) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id 582AE4068B; Fri, 25 Feb 2022 11:30:16 +0100 (CET) Received: by mail-pf1-f170.google.com with SMTP id l19so4331151pfu.2; Fri, 25 Feb 2022 02:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ekLO2tTg/v8mC7AxqC2HfxCcaS9ePIvr6/B2LXjiKpI=; b=GKJTwKGdr5T6j+ywbI9XOne5sqZNZ8T6DXHZXIMomx4Y708AkCbNlNrYLLWBn1X49r rxPvTvW66u/FqQZlHuTEAU6yD7qIp8PEwL5LZd+P6vBTRfsvKeGfg100ak1GQGAIYU0g 7SSlkxRnPs0WLe7MtZOp2nL2C480mwuspgRqMJ3ywczwp05czEQ1KDREBNhZef4Pimuy Dpjef9sp8hBVkvYetanYPl/qPwqmTtG7H9WSPyW8nOLzUeuJw3TN7F27OCyVkNBuJFqD tVYsgCIMGaZBYWEfzuly1ouVNTT1tBMHerCurXLmqfMtMgWAYldP84ETmadym2CXrRoh YK3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ekLO2tTg/v8mC7AxqC2HfxCcaS9ePIvr6/B2LXjiKpI=; b=tdmWPOQw9uRA5PJ8BwoSn0SrxXrU1XkKjHlaJ3a1huAUxt1WdMkBlR4P4JkWeGPvHc t0V33fqL0932nURcctPLBz9ctHbZiqY8f+4J8UiZeblni4CjA4OkTWlfYVJREGub7QaB 8lmtLhGRo23dEKUd1d3brIEx0GpPbx0FzxupIfcLoZBC3K9na98100QrlFfdi/SYyjD1 ZXJPjvXQo1fUbs683jsenE69FbqGy/DD2W47QSAy6k2YxEyyEmKRyMn2MpgV4fjCCy35 9VntibSxjQ3tmeaXNho2OZeXc5KKdk+Q+bvHfCJIX7i+Ffq72dXil4sfYrfjKWfK60K0 wJnA== X-Gm-Message-State: AOAM533b2EeY1dbd1wukhekk2PsBQW/eXV71HfDEWEbL/EcZ8y0Ko8ys sztDcOA2A2SYhrjziu9V9JlT6+1WbZOT7eKP+0w= X-Google-Smtp-Source: ABdhPJzobxe+ubrBja2hA2SOJd+cNweQa9/PhAt62QBDhsBZ8dxLodTIgdWeunoVlsB+w9D80kuVE9gJEEohlPRvIos= X-Received: by 2002:a05:6a00:114f:b0:4cd:65d0:7dd5 with SMTP id b15-20020a056a00114f00b004cd65d07dd5mr6895575pfm.41.1645785015534; Fri, 25 Feb 2022 02:30:15 -0800 (PST) MIME-Version: 1.0 References: <20210524090759.980530-1-qi.z.zhang@intel.com> <8297b7a87913490f894ee38bdb22a1e2@intel.com> <733185cb-95a4-c502-c4f4-77112331f390@redhat.com> In-Reply-To: <733185cb-95a4-c502-c4f4-77112331f390@redhat.com> From: Navin Srinivas Date: Fri, 25 Feb 2022 15:59:48 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process To: Kevin Traynor Cc: "Zhang, Qi Z" , "Wang, Yixue" , "Yang, Qiming" , "Zhang, Liheng" , "Dong, Yao" , "dev@dpdk.org" , "stable@dpdk.org" , "Xueming(Steven) Li" Content-Type: multipart/alternative; boundary="0000000000003a478905d8d52f8a" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000003a478905d8d52f8a Content-Type: text/plain; charset="UTF-8" Thanks, I noticed it in the release and took the LTS version. I do not see the previously noticed VF crash now on 20.11.4 Navin On Tue, Feb 22, 2022 at 2:51 PM Kevin Traynor wrote: > On 22/02/2022 04:30, Zhang, Qi Z wrote: > > Hi Srinivas: > > > > This is the fix for PF driver only, for VF we have a separated fix and > it is not be captured in 20.11.3, but I saw the patches are already merged > in stable tree. > > You can try with latest 20.11.4-rc1, or wait for 20.11.4 LTS. > > > > 20.11.4 is already released. Xueming sent details here > > http://inbox.dpdk.org/announce/20220124084950.482883-1-xuemingl@nvidia.com/T/#u > > You can check the release notes (or git) for specific fixes > > https://git.dpdk.org/dpdk-stable/tree/doc/guides/rel_notes/release_20_11.rst?h=20.11 > > > Regards > > Qi > > > > From: Navin Srinivas > > Sent: Tuesday, February 22, 2022 11:56 AM > > To: Zhang, Qi Z > > Cc: Wang, Yixue ; Yang, Qiming < > qiming.yang@intel.com>; Zhang, Liheng ; Dong, Yao > ; dev@dpdk.org; stable@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection > in secondary process > > > > Hi, > > > > Is this tested on VFs? I saw crash on both PF as well as VF, on 20.11.1, > but did not see PF crash on 20.11.3, > > I'm seeing a crash on the secondary process when it receives packet on > the VF, but PF doesn't crash now on 20.11.3 > > > > So I suspect this is the patch which is fixing the issue on ICE > secondary process crash on PF. > > > > Thanks & Regards, > > Navin Srinivas > > > > On Thu, Jun 3, 2021 at 3:51 PM Zhang, Qi Z qi.z.zhang@intel.com>> wrote: > > > > > >> -----Original Message----- > >> From: Wang, Yixue > > >> Sent: Thursday, June 3, 2021 6:04 PM > >> To: Zhang, Qi Z >; > Yang, Qiming > >> > > >> Cc: Zhang, Liheng >; > Dong, Yao > >> >; dev@dpdk.org dev@dpdk.org>; stable@dpdk.org > >> Subject: RE: [PATCH] net/ice: fix wrong data path selection in secondary > >> process > >> > >> Hi, Qi > >> > >> I've tested this patch and it works. > >> > >> Best Regards, > >> Yixue. > >> > >>> -----Original Message----- > >>> From: Zhang, Qi Z > > >>> Sent: Monday, May 24, 2021 17:08 > >>> To: Yang, Qiming > > >>> Cc: Zhang, Liheng liheng.zhang@intel.com>>; Wang, Yixue > >>> >; Dong, Yao < > yao.dong@intel.com>; dev@dpdk.org dev@dpdk.org>; > >>> Zhang, Qi Z >; > stable@dpdk.org > >>> Subject: [PATCH] net/ice: fix wrong data path selection in secondary > >>> process > >>> > >>> The flag use_avx2 and use_avx512 are defined as local variables, they > >>> will not be aware by the secondary process, then wrong data path is > >>> selected. Fix the issue by moving them into struct ice_adapter. > >>> > >>> Fixes: ae60d3c9b227 ("net/ice: support Rx AVX2 vector") > >>> Fixes: 2d5f6953d56d ("net/ice: support vector AVX2 in Tx") > >>> Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path") > >>> Cc: stable@dpdk.org > >>> > >>> Reported-by: Yixue Wang yixue.wang@intel.com>> > >>> Signed-off-by: Qi Zhang qi.z.zhang@intel.com>> > > > > Tested-by: Yixue Wang >> > > > > Applied to dpdk-next-net-intel. > > > > Thanks > > Qi > > --0000000000003a478905d8d52f8a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, I noticed it=C2=A0in=C2=A0the rel= ease=C2=A0and took the LTS version.=C2=A0
I do not se= e the previously noticed VF crash now on 20.11.4

Navin

On Tue, Feb 22, 2022 at 2:51 PM Kevin Traynor <ktraynor@redhat.com> wrote:
On 22/02/2022 04:30, Zhang, Qi Z wrote= :
> Hi Srinivas:
>
> This is the fix for PF driver only, for VF we have a separated fix and= it is not be captured in 20.11.3, but I saw the patches are already merged= in stable tree.
> You can try with latest 20.11.4-rc1,=C2=A0 =C2=A0or wait for 20.11.4 L= TS.
>

20.11.4 is already released. Xueming sent details here
http://inbox.dpdk.org= /announce/20220124084950.482883-1-xuemingl@nvidia.com/T/#u

You can check the release notes (or git) for specific fixes
https://git.dp= dk.org/dpdk-stable/tree/doc/guides/rel_notes/release_20_11.rst?h=3D20.11

> Regards
> Qi
>
> From: Navin Srinivas <g.navinsrinivas@gmail.com>
> Sent: Tuesday, February 22, 2022 11:56 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Wang, Yixue <yixue.wang@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Zhang= , Liheng <li= heng.zhang@intel.com>; Dong, Yao <yao.dong@intel.com>; dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection= in secondary process
>
> Hi,
>
> Is this tested on VFs? I saw crash on both PF as well as VF, on 20.11.= 1, but did not see PF crash on 20.11.3,
> I'm seeing a crash on the secondary process when it receives packe= t on the VF, but PF doesn't crash now on 20.11.3
>
> So I suspect this is the patch which is fixing the issue on ICE second= ary process crash on PF.
>
> Thanks & Regards,
> Navin Srinivas
>
> On Thu, Jun 3, 2021 at 3:51 PM Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>> wrote:
>
>
>> -----Original Message-----
>> From: Wang, Yixue <yixue.wang@intel.com<mailto:yixue.wang@intel.com>>
>> Sent: Thursday, June 3, 2021 6:04 PM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>; Yang, Qimin= g
>> <qim= ing.yang@intel.com<mailto:qiming.yang@intel.com>>
>> Cc: Zhang, Liheng <liheng.zhang@intel.com<mailto:liheng.zhang@intel.com>>; D= ong, Yao
>> <yao.do= ng@intel.com<mailto:yao.dong@intel.com>>; dev@dpdk.org<mailto:dev@dpdk.org>; stable@dpdk.org<mailto:stable@dpdk.org>
>> Subject: RE: [PATCH] net/ice: fix wrong data path selection in sec= ondary
>> process
>>
>> Hi, Qi
>>
>> I've tested this patch and it works.
>>
>> Best Regards,
>> Yixue.
>>
>>> -----Original Message-----
>>> From: Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>
>>> Sent: Monday, May 24, 2021 17:08
>>> To: Yang, Qiming <qiming.yang@intel.com<mailto:qiming.yang@intel.com>>
>>> Cc: Zhang, Liheng <liheng.zhang@intel.com<mailto:liheng.zhang@intel.com>>= ;; Wang, Yixue
>>> <= yixue.wang@intel.com<mailto:yixue.wang@intel.com>>; Dong, Yao <yao.dong@intel.com<= mailto:yao.dong@int= el.com>>; dev@d= pdk.org<mailto:dev= @dpdk.org>;
>>> Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>; stable@dpdk.org<mailto:stable@dpdk.org> >>> Subject: [PATCH] net/ice: fix wrong data path selection in sec= ondary
>>> process
>>>
>>> The flag use_avx2 and use_avx512 are defined as local variable= s, they
>>> will not be aware by the secondary process, then wrong data pa= th is
>>> selected. Fix the issue by moving them into struct ice_adapter= .
>>>
>>> Fixes: ae60d3c9b227 ("net/ice: support Rx AVX2 vector&quo= t;)
>>> Fixes: 2d5f6953d56d ("net/ice: support vector AVX2 in Tx&= quot;)
>>> Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path&quo= t;)
>>> Cc: stabl= e@dpdk.org<mailto:stable@dpdk.org>
>>>
>>> Reported-by: Yixue Wang <yixue.wang@intel.com<mailto:yixue.wang@intel.com>><= br> >>> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>><= br> >
> Tested-by: Yixue Wang <yixue.wang@intel.com<mailto:yixue.wang@intel.com>>
>
> Applied to dpdk-next-net-intel.
>
> Thanks
> Qi

--0000000000003a478905d8d52f8a--