From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDA0EA034C; Fri, 25 Feb 2022 11:25:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 547DC4115C; Fri, 25 Feb 2022 11:25:05 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 027044068B; Fri, 25 Feb 2022 11:25:03 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id g1so4313701pfv.1; Fri, 25 Feb 2022 02:25:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2ysJRHt3BQRuqlLnTac/lbuQYqp7Sz1pqIVvLcMiNgE=; b=p32Mg9ZMkBe216M3DZ+UNxAVBpW/Etc6gwqt052/6RIihzGAxpWsNbZ+CbyF5sIiif 1Dr4k0c8jEzSAbQsIq1Kec7tRvfD6aKlGfh1XJWgRwa+OfnduQxOI3aByPN7VWVgU/xh IyH13PoWKBIm7nGUMRUjXK43najfmPN8N2OXqImHMPYRMXKZgUIrAYAd0g2MkxGoz2p5 2H/MdxPI7QpqkKihd4kLOn1oPrF1uLQ48Qw+LwCaZtqhyj/7huUbcjyTqE37gRHrBz5/ TUNg5Dw5/OZSRzrcymPJwU6AiGgpG1QPe9DJdTBq69ZSuZrLelio4qk2wM30jmSlf2H9 VdNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2ysJRHt3BQRuqlLnTac/lbuQYqp7Sz1pqIVvLcMiNgE=; b=rgkOjFS8I3SE+ssLYSkdf+CJe6TXIc137+3/6ZF3S2ATAJS/e1YjzO/o0M32d9eEQO Nj4PAHDN5phv3j81GZRiZiuon2uvCxAo+LcQW9JluCMVrWJ4k+mguyK+Xs2gKEJ57Dgu ljp20+lCSRKxbDNu/KHte3vKYp6c5iDKugDqVUddgwiUWKVQKLs7L8LWz8BPKdbOyPuv /oaaxu677s9qpMNrgYvvfMSlFvNvFPIS5PK+4s+zn/KQV4Fgph847Lb9UtGL/Lv/Qwez u81O2GsTvvDjYYzsdv0Uhft3DOU1oikpoVp7cP96QfvcA5n9cyJ3GJIr2VOAi1MPS4oT ohSQ== X-Gm-Message-State: AOAM532qzr8IQ5O21trkBYZjCaUSApP2yHOPphe28M44I8V3R/al03E6 hP8wDTsIp8Py9XfhulySWoWUuqK4DbdUbtajZBs= X-Google-Smtp-Source: ABdhPJyFhchBhILBlN291WBkHced8RvekCMJ9VAh+rQkhnygAPGrvTYxwBdi+lmjBx2ARjCY3cCQCEvm7m9OVK4QgK0= X-Received: by 2002:a63:8ac2:0:b0:341:1e45:26c with SMTP id y185-20020a638ac2000000b003411e45026cmr5724526pgd.31.1645784703134; Fri, 25 Feb 2022 02:25:03 -0800 (PST) MIME-Version: 1.0 References: <20211025054029.1140977-1-dapengx.yu@intel.com> <20211026015542.1416819-1-dapengx.yu@intel.com> <32fc5d6c6b6c40aaa04320307672c878@intel.com> <67177ae735ce4658b86a930f82aa91f4@intel.com> In-Reply-To: <67177ae735ce4658b86a930f82aa91f4@intel.com> From: Navin Srinivas Date: Fri, 25 Feb 2022 15:54:36 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH v5] net/ice: fix function pointer in multi-process To: "Zhang, Qi Z" Cc: "Yu, DapengX" , "Yang, Qiming" , "dev@dpdk.org" , "Wang, Haiyue" , "stable@dpdk.org" Content-Type: multipart/alternative; boundary="0000000000009b719605d8d51c5b" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000009b719605d8d51c5b Content-Type: text/plain; charset="UTF-8" Hi Qi, Thank you for your reply and confirmation. Regards, Navin Srinivas On Fri, Feb 25, 2022 at 7:04 AM Zhang, Qi Z wrote: > We need a separate fix for AVF which is ongoing. > > And DPDK 20.11.4 LTS by default will only backport all the fix that during > DPDK 21.11 dev cycle, so you may need to wait for 20.11.5 or just cherry > pick by yourself. > > > > Regards > > Qi > > > > > > *From:* Navin Srinivas > *Sent:* Friday, February 25, 2022 2:00 AM > *To:* Zhang, Qi Z > *Cc:* Yu, DapengX ; Yang, Qiming < > qiming.yang@intel.com>; dev@dpdk.org; Wang, Haiyue ; > stable@dpdk.org > *Subject:* Re: [dpdk-dev] [PATCH v5] net/ice: fix function pointer in > multi-process > > > > Hi, > > > > Whether this fix is applicable for VF? I do not see this change ported to > VF in DPDK-20.11.4. > > > > Thanks, > > Navin Srinivas > > > > On Wed, Oct 27, 2021 at 8:58 AM Zhang, Qi Z wrote: > > > > > -----Original Message----- > > From: Yu, DapengX > > Sent: Tuesday, October 26, 2021 9:56 AM > > To: Yang, Qiming ; Zhang, Qi Z > > > > Cc: dev@dpdk.org; Wang, Haiyue ; Yu, DapengX > > ; stable@dpdk.org > > Subject: [PATCH v5] net/ice: fix function pointer in multi-process > > > > From: Dapeng Yu > > > > This patch uses the index value to call the function, instead of the > function > > pointer assignment to save the selection of Receive Flex Descriptor > profile ID. > > > > Otherwise the secondary process will run with wrong function address from > > primary process. > > > > Fixes: 7a340b0b4e03 ("net/ice: refactor Rx FlexiMD handling") > > Cc: stable@dpdk.org > > > > Signed-off-by: Dapeng Yu > > Acked-by: Haiyue Wang > > Applied to dpdk-next-net-intel. > > Thanks > Qi > > --0000000000009b719605d8d51c5b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Qi,
Thank you=C2=A0for your reply and confirmation.=

Regards,
Navin Srinivas

=
On Fri, Fe= b 25, 2022 at 7:04 AM Zhang, Qi Z <qi.z.zhang@intel.com> wrote:

We need a separate fix for AVF which is ongoing.<= /u>

And DPDK 20.11.4 LTS by default will only backport a= ll the fix that during DPDK 21.11 dev cycle, so you may need to wait for 20= .11.5 or just cherry pick by yourself.

=C2=A0

Regards

Qi

=C2=A0

=C2=A0

From: Navin Srinivas <g.navinsrinivas@gmail.com>= ;
Sent: Friday, February 25, 2022 2:00 AM
To: Zhang, Qi Z <qi.z.zhang@intel.com>
Cc: Yu, DapengX <dapengx.yu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; <= a href=3D"mailto:dev@dpdk.org" target=3D"_blank">dev@dpdk.org; Wang, Ha= iyue <haiyue.= wang@intel.com>; stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5] net/ice: fix function pointer in = multi-process

=C2=A0

Hi,

=C2=A0

Whether this fix is applicable for VF? I do not see = this change ported to VF in DPDK-20.11.4.=C2=A0

=C2=A0

Thanks,

Navin Srinivas

=C2=A0

On Wed, Oct 27, 2021 at 8:58 AM Zhang, Qi Z <qi.z.zhang@intel.com<= /a>> wrote:



> -----Original Message-----
> From: Yu, DapengX <dapengx.yu@intel.com>
> Sent: Tuesday, October 26, 2021 9:56 AM
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zha= ng@intel.com>
> Cc: dev@dpdk.org= ; Wang, Haiyue <haiyue.wang@intel.com>; Yu, DapengX
> <dapengx.= yu@intel.com>; stable@dpdk.org > Subject: [PATCH v5] net/ice: fix function pointer in multi-process
>
> From: Dapeng Yu <dapengx.yu@intel.com>
>
> This patch uses the index value to call the function, instead of the f= unction
> pointer assignment to save the selection of Receive Flex Descriptor pr= ofile ID.
>
> Otherwise the secondary process will run with wrong function address f= rom
> primary process.
>
> Fixes: 7a340b0b4e03 ("net/ice: refactor Rx FlexiMD handling"= )
> Cc: stable@dpdk.o= rg
>
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

--0000000000009b719605d8d51c5b--