From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80B65A034E; Tue, 22 Feb 2022 04:56:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10EA040DF4; Tue, 22 Feb 2022 04:56:11 +0100 (CET) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id 7BF824068C; Tue, 22 Feb 2022 04:56:09 +0100 (CET) Received: by mail-pg1-f170.google.com with SMTP id w37so9571247pga.7; Mon, 21 Feb 2022 19:56:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jziHzg6CUHZX8xjnfLF35flKjDnWa4fiUuL1RxAQY5k=; b=ZmxGKI+pIIBkcVcyxBpJGKSNpx5Nu2JiGZEFdovJ/qtxylExhxujOppJ76mx8irHJq p4HUDWUlta+5dquKaji+8u8jOey8niDtVsitOG5fa1rusgQQFwr5MHvaJODibJaQtwq+ +NblH2B37FQ8epohzqF0mFuzUKh4Emg71WcO/yviDwUL3NfE6No68iqHA14YYlTbBMFJ QwjBbIjlussocN0FWen+MoEEaFmc/A3O2QUIDnXccX7hDh5nAZl4Nph8tW+sJPzhJGgY tCgGfk0gAeHQRzqT5BeKMSuBddM6ijSe3Dby/zpn4fmsD1Ea7eX6Z7+n7Hj/it4zcxM8 4nFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jziHzg6CUHZX8xjnfLF35flKjDnWa4fiUuL1RxAQY5k=; b=lD5aRcX2g1MHn01iRsAhdA/vgt/Or0PD9qeVklw9opOqygXD/0mqd7Kceu1SeZl0ZD xthqJYR8r8yS0iFS2j5Rb2v+V46JV1kiBakSIzAdxSAqxa/9b13BvsCNSbvJrU+WoA5E NlRg1AWrGHgfyb/uKXx3BsDL8gHW1LUmZ24MIg/jgbcVz/QPUwMprC/g62sA4ulPjIPs sWhccj3AqQRGKG0Xh+8up3pWQS8lzLeSyib9/qt4Un4XHbyWus1BU7tpbb/5Ib2cAsUQ vaKxlr2fnabj/8jvC2T7Fi5jUXfKZW0IAHJp247ZfFYpw0iVJ/IPc1DPLl+IkFurb89X O+Zw== X-Gm-Message-State: AOAM530WaQlFQ5qoKfzg3ihVBMFtGrdzgKXMECJDskkpndz0wy770Qit eV/gFdu8A7iHNC0XIocpP98+CkmgNqdbgLk3+QY= X-Google-Smtp-Source: ABdhPJwxiQ1ewt3OtFICUgGkZou/XNekk+txGQOELTGAZK6n94Lh7aq+/eWtw61JYaaE6+GPD5puINDRAqVp6o8YFTc= X-Received: by 2002:a63:8ac2:0:b0:341:1e45:26c with SMTP id y185-20020a638ac2000000b003411e45026cmr18416906pgd.31.1645502168634; Mon, 21 Feb 2022 19:56:08 -0800 (PST) MIME-Version: 1.0 References: <20210524090759.980530-1-qi.z.zhang@intel.com> <8297b7a87913490f894ee38bdb22a1e2@intel.com> In-Reply-To: <8297b7a87913490f894ee38bdb22a1e2@intel.com> From: Navin Srinivas Date: Tue, 22 Feb 2022 09:25:51 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process To: "Zhang, Qi Z" Cc: "Wang, Yixue" , "Yang, Qiming" , "Zhang, Liheng" , "Dong, Yao" , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: multipart/alternative; boundary="0000000000003d19b805d893544b" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000003d19b805d893544b Content-Type: text/plain; charset="UTF-8" Hi, Is this tested on VFs? I saw crash on both PF as well as VF, on 20.11.1, but did not see PF crash on 20.11.3, I'm seeing a crash on the secondary process when it receives packet on the VF, but PF doesn't crash now on 20.11.3 So I suspect this is the patch which is fixing the issue on ICE secondary process crash on PF. Thanks & Regards, Navin Srinivas On Thu, Jun 3, 2021 at 3:51 PM Zhang, Qi Z wrote: > > > > -----Original Message----- > > From: Wang, Yixue > > Sent: Thursday, June 3, 2021 6:04 PM > > To: Zhang, Qi Z ; Yang, Qiming > > > > Cc: Zhang, Liheng ; Dong, Yao > > ; dev@dpdk.org; stable@dpdk.org > > Subject: RE: [PATCH] net/ice: fix wrong data path selection in secondary > > process > > > > Hi, Qi > > > > I've tested this patch and it works. > > > > Best Regards, > > Yixue. > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Monday, May 24, 2021 17:08 > > > To: Yang, Qiming > > > Cc: Zhang, Liheng ; Wang, Yixue > > > ; Dong, Yao ; dev@dpdk.org; > > > Zhang, Qi Z ; stable@dpdk.org > > > Subject: [PATCH] net/ice: fix wrong data path selection in secondary > > > process > > > > > > The flag use_avx2 and use_avx512 are defined as local variables, they > > > will not be aware by the secondary process, then wrong data path is > > > selected. Fix the issue by moving them into struct ice_adapter. > > > > > > Fixes: ae60d3c9b227 ("net/ice: support Rx AVX2 vector") > > > Fixes: 2d5f6953d56d ("net/ice: support vector AVX2 in Tx") > > > Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path") > > > Cc: stable@dpdk.org > > > > > > Reported-by: Yixue Wang > > > Signed-off-by: Qi Zhang > > Tested-by: Yixue Wang > > Applied to dpdk-next-net-intel. > > Thanks > Qi > > --0000000000003d19b805d893544b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,=C2=A0

Is this test= ed on VFs? I saw crash on both PF as well as VF, on 20.11.1, but did not se= e PF crash on 20.11.3,=C2=A0
I'm seeing a crash on the second= ary process when it receives=C2=A0packet on the VF, but PF doesn't cras= h now on 20.11.3

So I suspect this is the patch wh= ich is fixing the=C2=A0issue on ICE secondary process crash on PF.

Thanks & Regards,
Navin Srinivas
=
On Thu= , Jun 3, 2021 at 3:51 PM Zhang, Qi Z <qi.z.zhang@intel.com> wrote:


> -----Original Message-----
> From: Wang, Yixue <yixue.wang@intel.com>
> Sent: Thursday, June 3, 2021 6:04 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.= yang@intel.com>
> Cc: Zhang, Liheng <liheng.zhang@intel.com>; Dong, Yao
> <yao.dong@i= ntel.com>; dev@dpd= k.org; stable@dpdk= .org
> Subject: RE: [PATCH] net/ice: fix wrong data path selection in seconda= ry
> process
>
> Hi, Qi
>
> I've tested this patch and it works.
>
> Best Regards,
> Yixue.
>
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: Monday, May 24, 2021 17:08
> > To: Yang, Qiming <qiming.yang@intel.com>
> > Cc: Zhang, Liheng <liheng.zhang@intel.com>; Wang, Yixue
> > <yix= ue.wang@intel.com>; Dong, Yao <yao.dong@intel.com>; dev@dpdk.org;
> > Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/ice: fix wrong data path selection in second= ary
> > process
> >
> > The flag use_avx2 and use_avx512 are defined as local variables, = they
> > will not be aware by the secondary process, then wrong data path = is
> > selected. Fix the issue by moving them into struct ice_adapter. > >
> > Fixes: ae60d3c9b227 ("net/ice: support Rx AVX2 vector")=
> > Fixes: 2d5f6953d56d ("net/ice: support vector AVX2 in Tx&quo= t;)
> > Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path")=
> > Cc: stable@d= pdk.org
> >
> > Reported-by: Yixue Wang <yixue.wang@intel.com>
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

Tested-by: Yixue Wang <yixue.wang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

--0000000000003d19b805d893544b--