From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D256A034E; Tue, 22 Feb 2022 05:39:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDFBF40DF4; Tue, 22 Feb 2022 05:39:51 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 4F7384068C; Tue, 22 Feb 2022 05:39:50 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id 132so16042002pga.5; Mon, 21 Feb 2022 20:39:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NVTjTYVhfSIiOrPychFXi0MbRkR/fFlwP6L7NSoDhsU=; b=MF/A5Kc+D3yYjZJnIvW4iWSOGQVyhW2v6d+1OyQjR1iFXc9Y67TgbIOmNpaImnyd21 08zJjHHY+Qymud3xcElVP01ZH4TH7pOLfGuGWAcdrKiH5BMfveQdpErqQfUZuhomrLO4 2EFCCVLF0AfGFCC+FXErA0L20ew7OKWVIU8a3Mgwj+61yP3Kh3eWwDxge6pSknFTjhBL aL31Un+ArLnOSK4NtTF2YvA3UaKVgdOnv6czOvJ4mVLJSW/uN+b384s0P8UWnbjhoW5J dBlnag0Xu81LbXZOxqYBfWOqzjadAuIlsZmCGfVGf/XHl7QdkiQGh1ioRkBw5dqSGTB9 taug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NVTjTYVhfSIiOrPychFXi0MbRkR/fFlwP6L7NSoDhsU=; b=bZOSTgXLnq31HQK0IzDMn7j/jrKDSrkoRI/wXP3k1mXZZ8gJTA5Nq3S1oEhwn3V4o5 zS5uF649pxi8t9IcS2+xLp4jvAmYo6QQzACFp9VwGpSQwtLuem7zvlOfRryudCQCO5Pz +xrv4mMJfsAQ0iIzc2L1K9DNQtqp8csstHIyF6fOtmTOzt5n6+I/2OR86KogDRBx823M Hj0M7F2rVR5JMYtd37HqjpJiyiES1dr7t+m7Uc9rlJGI2BnvoQv7mfZOcdHHXQeuPtx9 mXOrjTgR20LbzYSC/NVMTdaCQe9qH3GDjI3aNSLCyq4o9UarciPjlhxXwIdh0OocDm9D CD1g== X-Gm-Message-State: AOAM533P+cqSN6yk8HXs1W+T3Eed09wuJlZiiAHBueHNfT3ZhgyDwOoZ 1HrXigUynzeNBP3x7LIx2xmMHpKQ7+O4GyY5z4Q= X-Google-Smtp-Source: ABdhPJzCQPAE2nY/8NtpcD3qzJ/WHGIQJKcueS9cA9UTyVrnenIb7tUMNZ6EtNi/N18GFA6TufAUh7kYGjEjVJVL9iw= X-Received: by 2002:a05:6a00:244f:b0:4df:82ad:447 with SMTP id d15-20020a056a00244f00b004df82ad0447mr22846735pfj.49.1645504789363; Mon, 21 Feb 2022 20:39:49 -0800 (PST) MIME-Version: 1.0 References: <20210524090759.980530-1-qi.z.zhang@intel.com> <8297b7a87913490f894ee38bdb22a1e2@intel.com> In-Reply-To: From: Navin Srinivas Date: Tue, 22 Feb 2022 10:09:27 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process To: "Zhang, Qi Z" Cc: "Wang, Yixue" , "Yang, Qiming" , "Zhang, Liheng" , "Dong, Yao" , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: multipart/alternative; boundary="000000000000723fba05d893f0c8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000723fba05d893f0c8 Content-Type: text/plain; charset="UTF-8" Hi Qi, Thank you for the confirmation! I will try with the mentioned release. Thanks & Regards, Navin Srinivas On Tue, Feb 22, 2022 at 10:01 AM Zhang, Qi Z wrote: > Hi Srinivas: > > > > This is the fix for PF driver only, for VF we have a separated fix and it > is not be captured in 20.11.3, but I saw the patches are already merged in > stable tree. > > You can try with latest 20.11.4-rc1, or wait for 20.11.4 LTS. > > > > Regards > > Qi > > > > *From:* Navin Srinivas > *Sent:* Tuesday, February 22, 2022 11:56 AM > *To:* Zhang, Qi Z > *Cc:* Wang, Yixue ; Yang, Qiming < > qiming.yang@intel.com>; Zhang, Liheng ; Dong, Yao > ; dev@dpdk.org; stable@dpdk.org > *Subject:* Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection > in secondary process > > > > Hi, > > > > Is this tested on VFs? I saw crash on both PF as well as VF, on 20.11.1, > but did not see PF crash on 20.11.3, > > I'm seeing a crash on the secondary process when it receives packet on the > VF, but PF doesn't crash now on 20.11.3 > > > > So I suspect this is the patch which is fixing the issue on ICE secondary > process crash on PF. > > > > Thanks & Regards, > > Navin Srinivas > > > > On Thu, Jun 3, 2021 at 3:51 PM Zhang, Qi Z wrote: > > > > > -----Original Message----- > > From: Wang, Yixue > > Sent: Thursday, June 3, 2021 6:04 PM > > To: Zhang, Qi Z ; Yang, Qiming > > > > Cc: Zhang, Liheng ; Dong, Yao > > ; dev@dpdk.org; stable@dpdk.org > > Subject: RE: [PATCH] net/ice: fix wrong data path selection in secondary > > process > > > > Hi, Qi > > > > I've tested this patch and it works. > > > > Best Regards, > > Yixue. > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Monday, May 24, 2021 17:08 > > > To: Yang, Qiming > > > Cc: Zhang, Liheng ; Wang, Yixue > > > ; Dong, Yao ; dev@dpdk.org; > > > Zhang, Qi Z ; stable@dpdk.org > > > Subject: [PATCH] net/ice: fix wrong data path selection in secondary > > > process > > > > > > The flag use_avx2 and use_avx512 are defined as local variables, they > > > will not be aware by the secondary process, then wrong data path is > > > selected. Fix the issue by moving them into struct ice_adapter. > > > > > > Fixes: ae60d3c9b227 ("net/ice: support Rx AVX2 vector") > > > Fixes: 2d5f6953d56d ("net/ice: support vector AVX2 in Tx") > > > Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path") > > > Cc: stable@dpdk.org > > > > > > Reported-by: Yixue Wang > > > Signed-off-by: Qi Zhang > > Tested-by: Yixue Wang > > Applied to dpdk-next-net-intel. > > Thanks > Qi > > --000000000000723fba05d893f0c8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Qi,

Thank you for the confirmation! = I will try with the mentioned release.=C2=A0

Thank= s & Regards,
Navin Srinivas

On Tue, Feb 22, 2022 at 10:0= 1 AM Zhang, Qi Z <qi.z.zhang@int= el.com> wrote:

Hi Srinivas:

=C2=A0

This is the fix for PF driver only, for VF we have a= separated fix and it is not be captured in 20.11.3, but I saw the patches = are already merged in stable tree.

You can try with latest 20.11.4-rc1, =C2=A0=C2=A0or = wait for 20.11.4 LTS.

=C2=A0

Regards

Qi

=C2=A0

From: Navin Srinivas <g.navinsrinivas@gmail.com>= ;
Sent: Tuesday, February 22, 2022 11:56 AM
To: Zhang, Qi Z <qi.z.zhang@intel.com>
Cc: Wang, Yixue <yixue.wang@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Z= hang, Liheng <liheng.zhang@intel.com>; Dong, Yao <yao.dong@intel.com>; dev@dpdk.org; stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selecti= on in secondary process

=C2=A0

Hi,=C2=A0

=C2=A0

Is this tested on VFs? I saw crash on both PF as wel= l as VF, on 20.11.1, but did not see PF crash on 20.11.3,=C2=A0

I'm seeing a crash on the secondary process when= it receives=C2=A0packet on the VF, but PF doesn't crash now on 20.11.3=

=C2=A0

So I suspect this is the patch which is fixing the= =C2=A0issue on ICE secondary process crash on PF.

=C2=A0

Thanks & Regards,

Navin Srinivas

=C2=A0

On Thu, Jun 3, 2021 at 3:51 PM Zhang, Qi Z <qi.z.zhang@intel.com> wrote:



> -----Original Message-----
> From: Wang, Yixue <yixue.wang@intel.com>
> Sent: Thursday, June 3, 2021 6:04 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.= yang@intel.com>
> Cc: Zhang, Liheng <liheng.zhang@intel.com>; Dong, Yao
> <yao.dong@i= ntel.com>; dev@dpdk.org; stab= le@dpdk.org
> Subject: RE: [PATCH] net/ice: fix wrong data path selection in seconda= ry
> process
>
> Hi, Qi
>
> I've tested this patch and it works.
>
> Best Regards,
> Yixue.
>
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: Monday, May 24, 2021 17:08
> > To: Yang, Qiming <qiming.yang@intel.com>
> > Cc: Zhang, Liheng <liheng.zhang@intel.com>; Wang, Yixue
> > <yix= ue.wang@intel.com>; Dong, Yao <yao.dong@intel.com>; dev@dpdk.org;
> > Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org > > Subject: [PATCH] net/ice: fix wrong data path selection in second= ary
> > process
> >
> > The flag use_avx2 and use_avx512 are defined as local variables, = they
> > will not be aware by the secondary process, then wrong data path = is
> > selected. Fix the issue by moving them into struct ice_adapter. > >
> > Fixes: ae60d3c9b227 ("net/ice: support Rx AVX2 vector")=
> > Fixes: 2d5f6953d56d ("net/ice: support vector AVX2 in Tx&quo= t;)
> > Fixes: 7f85d5ebcfe1 ("net/ice: add AVX512 vector path")=
> > Cc: stable@d= pdk.org
> >
> > Reported-by: Yixue Wang <yixue.wang@intel.com>
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

Tested-by: Yixue Wang <yixue.wang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

--000000000000723fba05d893f0c8--