From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C57BEA0A0C; Fri, 2 Jul 2021 03:16:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54BED40141; Fri, 2 Jul 2021 03:16:39 +0200 (CEST) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by mails.dpdk.org (Postfix) with ESMTP id D3E5B4003E for ; Fri, 2 Jul 2021 03:16:37 +0200 (CEST) Received: by mail-qk1-f170.google.com with SMTP id v139so7945577qkb.9 for ; Thu, 01 Jul 2021 18:16:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Oy2CbqxB7CR84A42bunUGZeUW2Ep32HMBNtgxZ/bbBk=; b=Ns5zw8Vfrvx+/SNfDjmUi/vCMGP2MNRnNA3As3dreZ8JV/quk7BhO39zqvTp2NzZY2 XRwzOym+RnZZpCaMzplMYy3nWS+pLT0JNdM45NWJgsBd9SDtLPise6r8Ybd4d3ysRIlg 2w02is6NpqNAj8Q/8poSffcctlKNkUQaWG/mo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Oy2CbqxB7CR84A42bunUGZeUW2Ep32HMBNtgxZ/bbBk=; b=eMwtREtqNvx9p2pxAXil3MLB0M7VUA7e9TbUtYBJ9eu0M5NM1Jsd8/hhJBbOYwIdgn 5upXglvHeqxadSDL/krW2fHElhnYUYOSMIYeFiL2cAHHIQsrEp2mo9phLSFwpbOwPH9o FBUP8/v6HEUWWfbY1AENwEo4s+8d3psMpdwjWj69ywn3DOtPFUAZjKsiMItshs+YvpRT 8otOThOlH3/GEukuMOus9EFet/Qwsx3uU+QHU/lkTwUOJaV8C947LJeZVdRbWxNZzpJS 7vXwifkb9ZoepTdel6657npvosMALhNPck8dvRV8q5T4zSdq5cNHdDf8Y8wZdAQr4cW5 MNkw== X-Gm-Message-State: AOAM530AOyATbKaFerEl3x6ESOTliIgcurXZhYbbhSMYoRYjtgKWhPyJ Lto2Io39NYS022Ag1I3VEFMGA10IzZ2GjsV42aTvBA== X-Google-Smtp-Source: ABdhPJyAZ4hITCkWAz+COss21dFedLOIdnVaMBx38sryrDUjZABfFel6aMxYSmzMmkf2HREgEkfJQenIzkPu53zrESA= X-Received: by 2002:ae9:ef83:: with SMTP id d125mr2890174qkg.455.1625188596959; Thu, 01 Jul 2021 18:16:36 -0700 (PDT) MIME-Version: 1.0 References: <20210701181253.39373-1-ajit.khaparde@broadcom.com> In-Reply-To: From: Ajit Khaparde Date: Thu, 1 Jul 2021 18:16:20 -0700 Message-ID: To: David Marchand Cc: dev , Lance Richardson , Andrew Rybchenko , "Yigit, Ferruh" , Thomas Monjalon Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000009ba9705c619b5b2" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: set rxq interrupt config to 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000009ba9705c619b5b2 Content-Type: text/plain; charset="UTF-8" On Thu, Jul 1, 2021 at 12:44 PM David Marchand wrote: > On Thu, Jul 1, 2021 at 8:13 PM Ajit Khaparde > wrote: > > > > Set rxq interrupt config to 0 instead of 1. > > Applications can set the rxq interrupt config to 1 or 0 as needed. > > If an application is not interested in handling Rx interrupts and > > prefers to poll Rx rings, there is no need for the PMD to set this > > config option to 1. > > > > Signed-off-by: Ajit Khaparde > > Reviewed-by: Lance Richardson > > --- > > drivers/net/bnxt/bnxt_ethdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > > index 495c6cd21e..bef9605fed 100644 > > --- a/drivers/net/bnxt/bnxt_ethdev.c > > +++ b/drivers/net/bnxt/bnxt_ethdev.c > > @@ -1011,7 +1011,7 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev > *eth_dev, > > }; > > eth_dev->data->dev_conf.intr_conf.lsc = 1; > > > > - eth_dev->data->dev_conf.intr_conf.rxq = 1; > > + eth_dev->data->dev_conf.intr_conf.rxq = 0; > > The application passes a dev_conf structure at configure time. > This structure configures many features, like rx interrupts. > Resetting anything from this configuration in the get_infos op is > wrong, be it 1 or 0. Agree. I will spin a v2. > > Idem with LSC. > I was testing that as well. But I could not complete all the tests. > > I don't think enabling LSC works as expected, because this driver does > not report the RTE_ETH_DEV_INTR_LSC capability. > Which leads me to a question for ethdev maintainers. > I am surprised we don't have a capability for rx interrupts, is this > feature advertised through another way than device flags? > > > -- > David Marchand > > --00000000000009ba9705c619b5b2--