From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2B2AA052B; Wed, 29 Jul 2020 02:48:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8550937B7; Wed, 29 Jul 2020 02:48:39 +0200 (CEST) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by dpdk.org (Postfix) with ESMTP id DC9F410A3 for ; Wed, 29 Jul 2020 02:48:38 +0200 (CEST) Received: by mail-ot1-f66.google.com with SMTP id a26so7507820otf.1 for ; Tue, 28 Jul 2020 17:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CAK+Pykj90RrZ7XOCuSwdKnXOQuJIt4h0aEqTapDqT8=; b=Pca2w3Dodg52SnMetTXJ354snHdUfNopO4viEAWx1eUg4+6Y4QsBwA5rRMxJNFHtKH ja+L8lD6zCHdTrQFCNV0OaxCZPhi6kvWOQ+STlLAjni8iX8CjyMkecWIgjxAN+77UzhH IgATiovLr4ojofbuFsGpz1cJ2+X6XgQwnnUU8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CAK+Pykj90RrZ7XOCuSwdKnXOQuJIt4h0aEqTapDqT8=; b=EV9y7IBoVHgljl3Vn9ZlCJsIPOfmmfSVUIF9XZhfuRnMvJOWFLjyTIJ6GKBicibv5C dcnxD/xMh34brxVM/dtoKCC9EyXiG/rn2MIbcpXUvsAFY6x4oE2UQ/oSMfT0n/D9cBl8 J/USjz1ICCjtokSEc24FPcOy5iBFmOQblJKd6ErcsT9QQibs5cqMxdJk4t2fqIjMuwY7 kSTBWXR3U5cu3hXR44xYfy4EIA8E1D9vywZedDe02ZntGXWWx1aELMRPyLg/JnJ5wT8/ ZJiyr188rYrDCb14oA//wa2lRKl3tKtidMaModxbpp65oOo7Zx77w7ilE7SJcBYQb7J4 haFQ== X-Gm-Message-State: AOAM532vBUv70vJ9/jdk4XvzklELpMHFCoC3RV5VTvx+EBxLim61nHa6 2q1JqkYydSIfzOaQ2cSTFB9Dqa0/OcJ+buGkd4ghSw== X-Google-Smtp-Source: ABdhPJxOY5GLBxnQgp581Gd5hmT3fo+MwVK0VkFM6VAdcpL2+rrPBU8Qd4tp/3SPbPKjuu3ptkXwUWyvKchGCG6bgds= X-Received: by 2002:a9d:3b1:: with SMTP id f46mr28621135otf.154.1595983717920; Tue, 28 Jul 2020 17:48:37 -0700 (PDT) MIME-Version: 1.0 References: <20200709081504.12336-1-david.marchand@redhat.com> In-Reply-To: <20200709081504.12336-1-david.marchand@redhat.com> From: Ajit Khaparde Date: Tue, 28 Jul 2020 17:48:21 -0700 Message-ID: To: David Marchand Cc: dpdk-dev , Ferruh Yigit , Thomas Monjalon , Somnath Kotur , Randy Schacher , Venkat Duvvuru , Peter Spreadborough Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 9, 2020 at 1:15 AM David Marchand wrote: > In existing build env, RTE_LIBRTE_BNXT_PMD_SYSTEM is unset. > Testing against a n value does not work and we end up with a link issue: > > /usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_alloc': > .../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1040: undefined reference > to `tf_em_ext_alloc' > /usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_free': > .../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1047: undefined reference > to `tf_em_ext_free' > collect2: error: ld returned 1 exit status > gmake[4]: *** [.../dpdk/mk/rte.lib.mk:95: librte_pmd_bnxt.so.20.0.3] > Error 1 > gmake[3]: *** [.../dpdk/mk/rte.subdir.mk:35: bnxt] Error 2 > > Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory") > > Signed-off-by: David Marchand > David, I have submitted a patch [1]. With that memory management for Extended Exact Match is simplified. We won't need any config or meson option with that change. [1] https://patchwork.dpdk.org/patch/74964/ > --- > drivers/net/bnxt/tf_core/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/bnxt/tf_core/Makefile > b/drivers/net/bnxt/tf_core/Makefile > index b4fbdd00fc..806471427c 100644 > --- a/drivers/net/bnxt/tf_core/Makefile > +++ b/drivers/net/bnxt/tf_core/Makefile > @@ -16,10 +16,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_msg.c > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_tbl.c > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_common.c > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_internal.c > -ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM), n) > -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c > +ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM),y) > +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_system.c > else > -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM) += tf_core/tf_em_system.c > +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c > endif > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_session.c > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_device.c > -- > 2.23.0 > >