From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA43CA034F; Mon, 29 Mar 2021 16:13:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BEEF9140D89; Mon, 29 Mar 2021 16:13:13 +0200 (CEST) Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by mails.dpdk.org (Postfix) with ESMTP id D58554069D for ; Mon, 29 Mar 2021 16:13:12 +0200 (CEST) Received: by mail-qk1-f169.google.com with SMTP id c4so12504728qkg.3 for ; Mon, 29 Mar 2021 07:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W4iSfNdYv9wjsFrGFxHX1COPqPHGkunRwA97eFQgvA8=; b=YU3CKT4a6rDJU3ktP18TTQ84rsTkPieaDltjTqxDe50z/gJTIDoHZsjawiYtsmcUFP JoEkCnyM5pTYAzc/W59F0BBvMrcnOrhLrJed6JgRB7FpkiGwx8xJgAZfzL5AlplYMEdL dstuDdyj8NZv2+pe/gAztwwW72TquccWQxJWs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W4iSfNdYv9wjsFrGFxHX1COPqPHGkunRwA97eFQgvA8=; b=clRzMYKmQteEWmhvJGUQxbQcUShI2n0kzUCYAxIm+mm+4dK5JTgv6qA+tLa5qmTmvY JiSjOY+2UgCh3Timal5iWcaEoYQXnfrb75T6M/SzywUkTRZzVphn7Z7pnMNjDsUsrYw+ Cwmp/I/yMAOGczFeTC1H7Rrvu8w43n7ePuB+JXmx0ZUrTiCo6oYOqh9Q5/JELBnxmc0C 4JTD29epO7sv7l6oGAKFwUShzsPM4/a/xH5YgJWR9xQ6kUq1su6qi/jhayXAJ2Cqykf4 1fizUKL+dBk7we/lWKuWoVXuvqKD1pQKOjNIjWkZ44BDmb6FZ9nPB2tKcK+bXnzZ7ehP VKgQ== X-Gm-Message-State: AOAM532EjA27KuuWTNDLHJGxpprevb48XmRvF3CrobII4zUzAVo4HwuZ M1jwxGLvlnhxninQIew2RVAifo92oHrIVXH5OIaZunD2YILCOw== X-Google-Smtp-Source: ABdhPJyYY/CwhJxt21pKwV9YAJRRWzMebAu8WtozMwQJVFs6DdNhAlRepaq08pfzbqN7m2HWgUVEyZdhHsRW616rFxM= X-Received: by 2002:a37:7985:: with SMTP id u127mr25643114qkc.333.1617027191946; Mon, 29 Mar 2021 07:13:11 -0700 (PDT) MIME-Version: 1.0 References: <2a9f3c44-44da-854b-8b25-772a3570baa4@huawei.com> <20210329072854.450188-1-thomas@monjalon.net> In-Reply-To: <20210329072854.450188-1-thomas@monjalon.net> From: Ajit Khaparde Date: Mon, 29 Mar 2021 07:12:55 -0700 Message-ID: To: Thomas Monjalon Cc: dpdk-dev , lihuisong@huawei.com, Ferruh Yigit , Andrew Rybchenko , Jerin Jacob Kollanukkaran , Somnath Kotur , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000006618b605bead7b1f" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] drivers/net: remove useless autoneg capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000006618b605bead7b1f Content-Type: text/plain; charset="UTF-8" On Mon, Mar 29, 2021 at 12:29 AM Thomas Monjalon wrote: > > The flag ETH_LINK_SPEED_AUTONEG is 0, > so it cannot be used in a capability bitmap. > > Having 0 in speed capability means all speeds are accepted. > > Signed-off-by: Thomas Monjalon > --- > drivers/net/bnxt/bnxt_ethdev.c | 2 -- For bnxt Acked-by: Ajit Khaparde > drivers/net/mlx5/linux/mlx5_ethdev_os.c | 4 ---- > 2 files changed, 6 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index f1dd40591f..a2debdbb64 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -889,8 +889,6 @@ uint32_t bnxt_get_speed_capabilities(struct bnxt *bp) > if (bp->link_info->auto_mode == > HWRM_PORT_PHY_QCFG_OUTPUT_AUTO_MODE_NONE) > speed_capa |= ETH_LINK_SPEED_FIXED; > - else > - speed_capa |= ETH_LINK_SPEED_AUTONEG; > > return speed_capa; > } > diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c > index 0e8de9439e..58d56913ae 100644 > --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c > +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c > @@ -409,8 +409,6 @@ mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev, > else > dev_link.link_speed = link_speed; > priv->link_speed_capa = 0; > - if (edata.supported & SUPPORTED_Autoneg) > - priv->link_speed_capa |= ETH_LINK_SPEED_AUTONEG; > if (edata.supported & (SUPPORTED_1000baseT_Full | > SUPPORTED_1000baseKX_Full)) > priv->link_speed_capa |= ETH_LINK_SPEED_1G; > @@ -517,8 +515,6 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, > sc = ecmd->link_mode_masks[0] | > ((uint64_t)ecmd->link_mode_masks[1] << 32); > priv->link_speed_capa = 0; > - if (sc & MLX5_BITSHIFT(ETHTOOL_LINK_MODE_Autoneg_BIT)) > - priv->link_speed_capa |= ETH_LINK_SPEED_AUTONEG; > if (sc & (MLX5_BITSHIFT(ETHTOOL_LINK_MODE_1000baseT_Full_BIT) | > MLX5_BITSHIFT(ETHTOOL_LINK_MODE_1000baseKX_Full_BIT))) > priv->link_speed_capa |= ETH_LINK_SPEED_1G; > -- > 2.30.1 > --0000000000006618b605bead7b1f--