From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B491A04DC; Mon, 26 Oct 2020 16:15:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D7232BB5; Mon, 26 Oct 2020 16:15:22 +0100 (CET) Received: from mail-oo1-f65.google.com (mail-oo1-f65.google.com [209.85.161.65]) by dpdk.org (Postfix) with ESMTP id 48001100C for ; Mon, 26 Oct 2020 16:15:21 +0100 (CET) Received: by mail-oo1-f65.google.com with SMTP id n16so1258867ooj.2 for ; Mon, 26 Oct 2020 08:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ng1CWDpee088R/XxMyjFXombdVdtCB6/Clf/7KkmNzI=; b=P0WNAs8PCc4yeFb2CuZNdupDCHaFl2Vv+hXbFQPw6EhUDjDutntuPNaxbXh15q/Mo7 Fprdz3gd56OHUuT+8zDV/+R42BLFSuP1+nFNWdpKTO6xPdyqH/yY1LMX2SfYOzJdbw7E glCKe6nQinmxYyPRjflpmXGoOVFYERDUNVlg0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ng1CWDpee088R/XxMyjFXombdVdtCB6/Clf/7KkmNzI=; b=PJ/MmXYqkoTHlmZLTrnC8R4I16y2YyGXNeB3VKcpwJDYRaWInmE7tNeEj6SCXNFp1x pXqwbbH6HKrFj4njcS7AiyH3XP28ZrGJbFTyZIeqsxoQ4HSSbiXlo/VgU74ktQ+yf1kP gH0ae4B8pDOuXWm2eZE7BuM45k3jsKKHo6IrPQxnbWE09In7rpfxUQsM4CWYrbI4b6XV DrNfRXsC/Ku1Ksf7o6WS9c3btOvLYYh6UCRWDHsyqCvXu7UhcGOJpPAJVas2tAtBLR+R MDvjbkT3hqlrCdlVT22s8PvaWZiIeIH5hwIVIhe5sCMWhxz4Mq2iySTCbLr0hQY2/kQS cEIQ== X-Gm-Message-State: AOAM533ABH1uYGIcY6wf6dSBwweaZnKBd7fMFSvVTbnyw+CyzoZn4XmC rB75XCgjkb9xIysfTMShcghYNkF9BasoTC1hZPJ81A== X-Google-Smtp-Source: ABdhPJzr037L2kta1Zt3iY952G7Vf0KIeU/Sz/5xp23XlP3PCELYSbce3M7G/lEMlVhk5nRX+hvxN8nMtWSS63PoRaU= X-Received: by 2002:a4a:9e87:: with SMTP id u7mr14719052ook.15.1603725319340; Mon, 26 Oct 2020 08:15:19 -0700 (PDT) MIME-Version: 1.0 References: <20200914110511.95609-1-mb@smartsharesystems.com> In-Reply-To: <20200914110511.95609-1-mb@smartsharesystems.com> From: Ajit Khaparde Date: Mon, 26 Oct 2020 08:15:03 -0700 Message-ID: To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Bruce Richardson , Jeff Guo , dpdk-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] ethdev: rte_eth_rx_burst() nb_pkts requirements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 14, 2020 at 4:05 AM Morten Br=C3=B8rup wrote: > > Updated description of rte_eth_rx_burst() to reflect what drivers, > when using vector instructions, expect from nb_pkts. > > Also discussed on the mailing list here: > http://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35C61257@smartser= ver.smartshare.dk/ > > Signed-off-by: Morten Br=C3=B8rup Acked-by: Ajit Khaparde > --- > lib/librte_ethdev/rte_ethdev.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethde= v.h > index 70295d7ab..41f8ba4ef 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -4469,6 +4469,10 @@ int rte_eth_dev_hairpin_capability_get(uint16_t po= rt_id, > * burst-oriented optimizations in both synchronous and asynchronous > * packet processing environments with no overhead in both cases. > * > + * @note > + * Some drivers using vector instructions require that *nb_pkts* is > + * divisible by 4 or 8, depending on the driver implementation. > + * > * The rte_eth_rx_burst() function does not provide any error > * notification to avoid the corresponding overhead. As a hint, the > * upper-level application might check the status of the device link onc= e > @@ -4485,6 +4489,7 @@ int rte_eth_dev_hairpin_capability_get(uint16_t por= t_id, > * must be large enough to store *nb_pkts* pointers in it. > * @param nb_pkts > * The maximum number of packets to retrieve. > + * The value must be divisible by 8 in order to work with any driver. > * @return > * The number of packets actually retrieved, which is the number > * of pointers to *rte_mbuf* structures effectively supplied to the > -- > 2.17.1 >