From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEA5AA04F8; Sat, 21 Dec 2019 03:51:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9AFC4CBD; Sat, 21 Dec 2019 03:51:45 +0100 (CET) Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by dpdk.org (Postfix) with ESMTP id 870B437A2 for ; Sat, 21 Dec 2019 03:51:44 +0100 (CET) Received: by mail-ot1-f67.google.com with SMTP id c22so14307840otj.13 for ; Fri, 20 Dec 2019 18:51:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p6nTZXxyDgN34ApmWxv38kPrToPhOaY1di2yKOjJAIk=; b=O5c/MqJCZIncgzc+EHTECHGMMsYJ5s89K171BAdBghY9rKLQCbAXCA8JzUG/FO86Rn KMZxcOaMEbp7LhfC68LuWfCytwmrJMkEkbKcMXi2IzmM8QDHtm+l78nQ8VVJglVrIWOF XP1hwUJQ7TM9QrRNMexBWTpPr0Vvqcmzf11Ys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p6nTZXxyDgN34ApmWxv38kPrToPhOaY1di2yKOjJAIk=; b=R5SwAFjRXjv+QtJGUNukf6Tz1Ffl+JjQy1tN2TwXKA4+VVY9Ri94bID1NkAoCPfcHb 74bqFva2DtGTt9hHd0tFm4qQNFL2i5fmdySjE5STNSwIolERQl6mKE/nvS6VfDMEzSsp SXBiTVekEre+3lqZqfRrW+Ts7boa+TE4Bh7Xg8uvQqbQrxaqF4QcdL3yAW32W1Jsr5r8 UeXOP0l5IEQrfKTt4QJZcFFwZHv9GDXrsXZjQ3Fxflw5cibDJfbDC5qgUFO3TH9a4V7r EH2sCxtuRc65s53pctat93zO6zSdnRsqU5KsZ3eNUgsl9YYQ0atVTuohV03yQJNx2wat 5QjQ== X-Gm-Message-State: APjAAAWBSifXylSw9JeixTtI5STPOk5xhptFRKvfuIiO8whNe4POUdC8 9dzJft41h8ep3X+40IzSYnwFxvAN4igU/YMYnKUf7mn7tWU= X-Google-Smtp-Source: APXvYqz4+4p/VyUkFbfnMitw03rdODPUVDFsDNm9MDoLrJ4/ZY8oICxxWgiTyeiCeg2KKHt6cHraHU6XYOy+5NBP2Og= X-Received: by 2002:a9d:48a:: with SMTP id 10mr17377388otm.95.1576896703695; Fri, 20 Dec 2019 18:51:43 -0800 (PST) MIME-Version: 1.0 References: <20191221024218.56582-1-ajit.khaparde@broadcom.com> In-Reply-To: <20191221024218.56582-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Fri, 20 Dec 2019 18:51:28 -0800 Message-ID: To: dpdk-dev Cc: Ferruh Yigit , dpdk stable , Lance Richardson Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix to not overwrite error message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Dec 20, 2019 at 6:42 PM Ajit Khaparde wrote: > In some cases when flow creation fails, we overwrite the specific > error message with a generic error message. This patch fixes it. > > Fixes: d24610f7bfda ("net/bnxt: allow flow creation when RSS is enabled") > Cc: stable@dpdk.org > > Signed-off-by: Ajit Khaparde > Reviewed-by: Lance Richardson > Patch applied to dpdk-next-net-brcm > --- > drivers/net/bnxt/bnxt_flow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c > index 707aedcec..cde1fa41c 100644 > --- a/drivers/net/bnxt/bnxt_flow.c > +++ b/drivers/net/bnxt/bnxt_flow.c > @@ -1485,7 +1485,7 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev, > if (rxq && !vnic->rx_queue_cnt) > rxq->vnic = &bp->vnic_info[0]; > } > - return rc; > + return -rte_errno; > } > > static > @@ -1815,7 +1815,7 @@ bnxt_flow_create(struct rte_eth_dev *dev, > rte_flow_error_set(error, 0, > RTE_FLOW_ERROR_TYPE_NONE, NULL, > "Flow with pattern exists, updating > destination queue"); > - else > + else if (!rte_errno) > rte_flow_error_set(error, -ret, > RTE_FLOW_ERROR_TYPE_HANDLE, NULL, > "Failed to create flow."); > -- > 2.21.0 (Apple Git-122.2) > >