From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D3AEA09E9; Tue, 8 Dec 2020 21:59:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 11F8372D9; Tue, 8 Dec 2020 21:59:35 +0100 (CET) Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by dpdk.org (Postfix) with ESMTP id F1D69A3 for ; Tue, 8 Dec 2020 21:59:32 +0100 (CET) Received: by mail-qt1-f194.google.com with SMTP id b9so13008752qtr.2 for ; Tue, 08 Dec 2020 12:59:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Rhw+d2xFkIPR5OBU2vQ6WutlHmJPwui8GYFC1OGELcs=; b=hhT4wPsw3BvMRXu1ioNoM+rui9laF26glNODWlS1ozvBUcYS0RxwubJkXxLkVyhDXO D48k5M5VFDYtY7vXnlRYbf8gtfYYl0dZJIp2dAQGbEEwVDyCWA35HF14m7BqIigmN/Li FfHFQgNWgOE+LGtkjRQCgpP6VbIKd2ubzuSyY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Rhw+d2xFkIPR5OBU2vQ6WutlHmJPwui8GYFC1OGELcs=; b=Odgw7e0DVB3bTXDXY/0QPkLk0Oov1NzDRIDHcA5GHUlY7wMIUkp4YoQMJ2QGqpXjP9 PjYXFhLbSp7dVkv98GMJwB03ptr6gnu7TLbg4CIcregEsFRRtkLipJUJmXJCK9q561Kj 4U0Kgf/gthX72uaiUVlSX2Gw7DQ3uUEzPUlVtkPyygrxZ3jRnJAVQ4m8cb3/L2R9xLGI sjjyUZGzpDZ+XZtaNlZZrxxQlRlteVARaOvx2PUyf/TAlq7FcvkGhCZTg0uL8wJHpzoq nEsVi783Z4S3J+ibs2lgf9qE03LJuAHLdw83qXgMsrr7N4PuNb43HsKznXhH+5FU2/d4 x1Kw== X-Gm-Message-State: AOAM5318oRHjBn7U1/OA8g7h+sizY5XR1xQRvR8ibaN1HP9bJTzYLHCd pvl9PMinE/gZubOhkVFYc/23qrsTuZzp1k+ZId+V0t7aOX8Nubk1YHwjP/6S2mjq31gXBkn0F63 fyoX1S9SIBg== X-Google-Smtp-Source: ABdhPJxj/Yne/xTWPwAgVlrOWqBpgYOvG3lPF/7tHZkuovqRS/jGLrLDz8C6MhPeTyp99ahPo5rSCwB8BIoC4ysnaF4= X-Received: by 2002:ac8:ec8:: with SMTP id w8mr31962503qti.371.1607461172296; Tue, 08 Dec 2020 12:59:32 -0800 (PST) MIME-Version: 1.0 References: <20201203141621.160040-1-lance.richardson@broadcom.com> In-Reply-To: <20201203141621.160040-1-lance.richardson@broadcom.com> From: Ajit Khaparde Date: Tue, 8 Dec 2020 12:59:15 -0800 Message-ID: To: Lance Richardson Cc: Somnath Kotur , dpdk-dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: disable receive end-of-packet padding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Dec 3, 2020 at 6:16 AM Lance Richardson wrote: > > Testing has shown that the packet forwarding rate for packet sizes > that are not a multiple of the cache line size is reduced when the > DMA size is padded to a multiple of the cache line size. Improve > performance for these packet sizes by disabling EOP padding. > > Fixes: f4253e97e7b0 ("net/bnxt: set padding flags in Rx descriptor") > Signed-off-by: Lance Richardson > Reviewed-by: Ajit Kumar Khaparde > Reviewed-by: Somnath Kotur Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_rxr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index fdbe6f71e..af1774844 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -1113,7 +1113,7 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq) > size = rte_pktmbuf_data_room_size(rxq->mb_pool) - RTE_PKTMBUF_HEADROOM; > size = RTE_MIN(BNXT_MAX_PKT_LEN, size); > > - type = RX_PROD_PKT_BD_TYPE_RX_PROD_PKT | RX_PROD_PKT_BD_FLAGS_EOP_PAD; > + type = RX_PROD_PKT_BD_TYPE_RX_PROD_PKT; > > rxr = rxq->rx_ring; > ring = rxr->rx_ring_struct; > -- > 2.25.1 > -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.