From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90470A0524; Tue, 13 Apr 2021 19:11:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 034FD1611E0; Tue, 13 Apr 2021 19:11:09 +0200 (CEST) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by mails.dpdk.org (Postfix) with ESMTP id 87EE8160D68 for ; Tue, 13 Apr 2021 19:11:07 +0200 (CEST) Received: by mail-qk1-f174.google.com with SMTP id x11so18552300qkp.11 for ; Tue, 13 Apr 2021 10:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VcRs6+chZ35sd5FsrpoTHXL4WsrgjDo2D1ARCirEdwE=; b=hMuX9ETu/ex+jYmnAHEtFjxGkJ5wkhMeVpb1gkvyO06fdeGLEdj3YU+QBoPfF09R3X +smLk8V0NG+68WvSfZaghRVSI5HJek56HM5Fr5cTG3S1UjqAwNm5SLxLDVlL5eioExhI Z1CfU9i3z5ElugDbcDL/+AfbhbQKdj7Yht7gQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VcRs6+chZ35sd5FsrpoTHXL4WsrgjDo2D1ARCirEdwE=; b=fzPprojSKxUa++8cdCAN3jufAwh0/Cz63KqMFer0ZuJ+EjMXWByTcWhxpZyRLQxJkY g40SC6osNghkDi1Zi8wYRvd323TKw27ByAcX1VTusbDBOowrcSqQpX3rwZBU6Ua35Xhc /Luh1aqecvmtCbCmpNOivmolKbLuXsm8DQpvd/x2zBc76XYPnm680iPuZSSz/SlX9fBY LQcQ+UvDUK0TQGYs28QrzrG8lxoEUxwEVQRsGUCzM2rITZdqoNHykHsmb44umCtc7hQE k+NAE2sceoF6BpsLFry57NIu2Wl8DpbmWNa3fM/Fcll7SRpCK2U5RSL+vn6GYnw/zWaK 1Uog== X-Gm-Message-State: AOAM532j63EuL5PdVhHxWvHCPLCxKhsMsAvx5oTKn9Rlvi+6oYXQbbO1 IXk0HpNr1WWsRHhG8g+3NfHlifstwhpkywgMU1rvIw== X-Google-Smtp-Source: ABdhPJwej947lImrXYyfdMmIquSjqS7fGa/O4N3DLiVXQKsDH7/ypezVr2TBcgmGXQISvPzRkBXnX3yvvC9A4WI3d3k= X-Received: by 2002:a05:620a:2053:: with SMTP id d19mr7499159qka.40.1618333866743; Tue, 13 Apr 2021 10:11:06 -0700 (PDT) MIME-Version: 1.0 References: <1617877348-16394-1-git-send-email-humin29@huawei.com> <94a40608-6d33-3d24-f6ab-86424a50eab1@intel.com> In-Reply-To: <94a40608-6d33-3d24-f6ab-86424a50eab1@intel.com> From: Ajit Khaparde Date: Tue, 13 Apr 2021 10:10:50 -0700 Message-ID: To: Ferruh Yigit Cc: "Min Hu (Connor)" , dpdk-dev , Xiaoyun Li , Andrew Rybchenko , Qi Zhang Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000047790f05bfddb7a3" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix bitmap of link speeds when force speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000047790f05bfddb7a3 Content-Type: text/plain; charset="UTF-8" On Tue, Apr 13, 2021 at 10:08 AM Ferruh Yigit wrote: > > On 4/8/2021 11:22 AM, Min Hu (Connor) wrote: > > From: Huisong Li > > > > Currently, when the user sets force link speed through 'link_speeds', > > bit(0) of 'link_speeds' is not set to 1(ETH_LINK_SPEED_FIXED), > > which conflicts with the definition. > > > > Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function") > > Cc: stable@dpdk.org > > > > Signed-off-by: Huisong Li > > Signed-off-by: Min Hu (Connor) > > --- > > app/test-pmd/cmdline.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > > index f44116b..8c36de2 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -1523,6 +1523,9 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed) > > printf("Unknown speed parameter\n"); > > return -1; > > } > > + > > + if (*speed != ETH_LINK_SPEED_AUTONEG) > > + *speed |= ETH_LINK_SPEED_FIXED; > > } > > > > return 0; > > > > Acked-by: Ferruh Yigit Acked-by: Ajit Khaparde > > This has a history, same patch has been done in the past by Andrew [1], later > reverted [2] (by me) since some PMDs failed and we were close to release. > > In recent discussion [3] already agreed to get the patch again before -rc1, and > this time there will be time to fix failing PMDs. > Thanks for making the patch. +1 > > > [1] Commit bdca79053b6a ("app/testpmd: set fixed flag for exact link speed") > > [2] Commit f53cc91f412a ("app/testpmd: revert fixed flag for exact link speed") > > [3] http://inbox.dpdk.org/dev/43d67012-7f6f-2de8-e5ee-50cbe025d3eb@intel.com/#t --00000000000047790f05bfddb7a3--