* [dpdk-dev] [PATCH 1/1] net/bnxt: fix transmit length hint threshold
@ 2021-03-18 19:52 Lance Richardson
2021-03-19 3:51 ` Ajit Khaparde
0 siblings, 1 reply; 2+ messages in thread
From: Lance Richardson @ 2021-03-18 19:52 UTC (permalink / raw)
To: Ajit Khaparde, Somnath Kotur, Stephen Hurd, David Christensen; +Cc: dev, stable
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
Use correct threshold when selecting "greater than or equal to
2K" length hint.
Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code")
Cc: stable@dpdk.org
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_txr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c
index 65355fb040..27459960de 100644
--- a/drivers/net/bnxt/bnxt_txr.c
+++ b/drivers/net/bnxt/bnxt_txr.c
@@ -187,7 +187,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,
txbd->flags_type |= TX_BD_SHORT_FLAGS_COAL_NOW;
txbd->flags_type |= TX_BD_LONG_FLAGS_NO_CMPL;
txbd->len = tx_pkt->data_len;
- if (tx_pkt->pkt_len >= 2014)
+ if (tx_pkt->pkt_len >= 2048)
txbd->flags_type |= TX_BD_LONG_FLAGS_LHINT_GTE2K;
else
txbd->flags_type |= lhint_arr[tx_pkt->pkt_len >> 9];
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH 1/1] net/bnxt: fix transmit length hint threshold
2021-03-18 19:52 [dpdk-dev] [PATCH 1/1] net/bnxt: fix transmit length hint threshold Lance Richardson
@ 2021-03-19 3:51 ` Ajit Khaparde
0 siblings, 0 replies; 2+ messages in thread
From: Ajit Khaparde @ 2021-03-19 3:51 UTC (permalink / raw)
To: Lance Richardson
Cc: Somnath Kotur, Stephen Hurd, David Christensen, dpdk-dev, dpdk stable
[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]
On Thu, Mar 18, 2021 at 12:52 PM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> Use correct threshold when selecting "greater than or equal to
> 2K" length hint.
>
> Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code")
> Cc: stable@dpdk.org
>
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt_txr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c
> index 65355fb040..27459960de 100644
> --- a/drivers/net/bnxt/bnxt_txr.c
> +++ b/drivers/net/bnxt/bnxt_txr.c
> @@ -187,7 +187,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,
> txbd->flags_type |= TX_BD_SHORT_FLAGS_COAL_NOW;
> txbd->flags_type |= TX_BD_LONG_FLAGS_NO_CMPL;
> txbd->len = tx_pkt->data_len;
> - if (tx_pkt->pkt_len >= 2014)
> + if (tx_pkt->pkt_len >= 2048)
> txbd->flags_type |= TX_BD_LONG_FLAGS_LHINT_GTE2K;
> else
> txbd->flags_type |= lhint_arr[tx_pkt->pkt_len >> 9];
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-19 3:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 19:52 [dpdk-dev] [PATCH 1/1] net/bnxt: fix transmit length hint threshold Lance Richardson
2021-03-19 3:51 ` Ajit Khaparde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).