From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 368DCA0C45;
	Thu, 22 Jul 2021 03:31:40 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AD6CB4014E;
	Thu, 22 Jul 2021 03:31:39 +0200 (CEST)
Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com
 [209.85.219.51]) by mails.dpdk.org (Postfix) with ESMTP id D16014014D
 for <dev@dpdk.org>; Thu, 22 Jul 2021 03:31:38 +0200 (CEST)
Received: by mail-qv1-f51.google.com with SMTP id w2so1896766qvh.13
 for <dev@dpdk.org>; Wed, 21 Jul 2021 18:31:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=lQsaI19GUR/QLlJfef+bI0R/hNOj93Yal/wg3a1wEyI=;
 b=HCrVMrITDNXo6ufv5vpzCVqTcSzaVQg4uM5l5qdnjmOLZVz1SBgw1zqAjau4yfm8JP
 4C+k9pxTXxMktIoE7Rz4jarK6iNckD4CierKc8vCbxGnbg9S0l3aMiiKFXSvA4EiYGv3
 izAATlSa5mGJhtvbcdFg3TncE+qGDHE8K53tw=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=lQsaI19GUR/QLlJfef+bI0R/hNOj93Yal/wg3a1wEyI=;
 b=HF/H9/oS0D4OOsUN6YTD260zjCJFmNYx6297BUHCwMs7R8OjwUxOBHUIY83oYZQ2hV
 vlQlY9kNxefI76qnRdfzV8yxJfJwHLR5/uHNK9Igj2vHLYXRDxutC3REjtBsclS1nIOb
 q3KzGH3Cgvy+n2hqA/osLyTYkJueKYMTmWLlGqIa2UsQbfNGT1+VoS2m2nQYCjs0eMqD
 U9bJl8++RubYlQM0krphT62EGFQHHBcn4wWk4JT9EI+E84/46w3Peu0J8n/cElBOkfDJ
 KQPfLygCbe1rbA2qKntIsZA6bfKQin17IfA6CwncAb8YF4J7cInUIKlz3gHibY5ich6d
 +qnQ==
X-Gm-Message-State: AOAM530bZ89BxpJLklmDXh661mA+M5Bdwhl1dakpj6v78oLceXZuc5Z9
 YRrs0HW8uJnB4DhRkMcg+hd8E0QLvS7mRphRBlPwQg==
X-Google-Smtp-Source: ABdhPJzAwEv+xEDjmKYP9nThdekr7XEQz/R2H2rUaMxiNCEkFjpSHTjC+YNmV+v91FuadiU4ZLikxbujAywQebTivo8=
X-Received: by 2002:ad4:54d0:: with SMTP id j16mr39330062qvx.30.1626917498008; 
 Wed, 21 Jul 2021 18:31:38 -0700 (PDT)
MIME-Version: 1.0
References: <20210709172923.3369846-1-ferruh.yigit@intel.com>
 <6655b8c1-82d8-27af-087c-c63153e79d3d@oktetlabs.ru>
 <61fbde10-1e3e-45a4-9877-f57f0aac2360@intel.com>
In-Reply-To: <61fbde10-1e3e-45a4-9877-f57f0aac2360@intel.com>
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: Wed, 21 Jul 2021 18:31:21 -0700
Message-ID: <CACZ4nhs=1ck9TG3s9SNws80UiQ6WvjG91FfrpsftphvVZzUycQ@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Jerin Jacob <jerinj@marvell.com>, 
 Xiaoyun Li <xiaoyun.li@intel.com>, Chas Williams <chas3@att.com>, 
 "Min Hu (Connor)" <humin29@huawei.com>, Hemant Agrawal <hemant.agrawal@nxp.com>,
 Sachin Saxena <sachin.saxena@oss.nxp.com>, Qi Zhang <qi.z.zhang@intel.com>, 
 Xiao Wang <xiao.w.wang@intel.com>, Matan Azrad <matan@nvidia.com>, 
 Shahaf Shuler <shahafs@nvidia.com>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>, 
 Harman Kalra <hkalra@marvell.com>, Maciej Czekaj <mczekaj@marvell.com>,
 Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>, 
 Bruce Richardson <bruce.richardson@intel.com>, 
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 John McNamara <john.mcnamara@intel.com>, 
 Igor Russkikh <igor.russkikh@aquantia.com>,
 Pavel Belous <pavel.belous@aquantia.com>, 
 Steven Webster <steven.webster@windriver.com>,
 Matt Peters <matt.peters@windriver.com>, 
 Somalapuram Amaranath <asomalap@amd.com>, Rasesh Mody <rmody@marvell.com>, 
 Shahed Shaikh <shshaikh@marvell.com>,
 Somnath Kotur <somnath.kotur@broadcom.com>, 
 Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>, 
 Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>, 
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Haiyue Wang <haiyue.wang@intel.com>, 
 Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>,
 Guy Tzalik <gtzalik@amazon.com>, 
 Evgeny Schemeilin <evgenys@amazon.com>, Igor Chauskin <igorch@amazon.com>, 
 Gagandeep Singh <g.singh@nxp.com>, John Daley <johndale@cisco.com>,
 Hyong Youb Kim <hyonkim@cisco.com>, Ziyang Xuan <xuanziyang2@huawei.com>,
 Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>, 
 Guoyang Zhou <zhouguoyang@huawei.com>, Yisen Zhuang <yisen.zhuang@huawei.com>, 
 Lijun Ou <oulijun@huawei.com>, Beilei Xing <beilei.xing@intel.com>, 
 Jingjing Wu <jingjing.wu@intel.com>, Qiming Yang <qiming.yang@intel.com>, 
 Andrew Boyer <aboyer@pensando.io>, Rosen Xu <rosen.xu@intel.com>, 
 Shijith Thotton <sthotton@marvell.com>, 
 Srisivasubramanian Srinivasan <srinivasan@marvell.com>,
 Zyta Szpak <zr@semihalf.com>, 
 Liron Himi <lironh@marvell.com>, Heinrich Kuhn <heinrich.kuhn@netronome.com>, 
 Devendra Singh Rawat <dsinghrawat@marvell.com>,
 Keith Wiles <keith.wiles@intel.com>, 
 Jiawen Wu <jiawenwu@trustnetic.com>, Jian Wang <jianwang@trustnetic.com>, 
 Maxime Coquelin <maxime.coquelin@redhat.com>, Chenbo Xia <chenbo.xia@intel.com>,
 Nicolas Chautru <nicolas.chautru@intel.com>, David Hunt <david.hunt@intel.com>,
 Harry van Haaren <harry.van.haaren@intel.com>, 
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Radu Nicolau <radu.nicolau@intel.com>, 
 Akhil Goyal <gakhil@marvell.com>, Tomasz Kantecki <tomasz.kantecki@intel.com>, 
 Declan Doherty <declan.doherty@intel.com>,
 Pavan Nikhilesh <pbhagavatula@marvell.com>, 
 Kirill Rybalchenko <kirill.rybalchenko@intel.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>, 
 Thomas Monjalon <thomas@monjalon.net>, dpdk-dev <dev@dpdk.org>
Content-Type: multipart/signed; protocol="application/pkcs7-signature";
 micalg=sha-256; boundary="00000000000091fa2505c7ac3f1b"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

--00000000000091fa2505c7ac3f1b
Content-Type: text/plain; charset="UTF-8"

> > [snip]
> >
> >> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
> >> index faf3bd901d75..9f288f98329c 100644
> >> --- a/lib/ethdev/rte_ethdev.h
> >> +++ b/lib/ethdev/rte_ethdev.h
> >> @@ -410,7 +410,7 @@ enum rte_eth_tx_mq_mode {
> >>  struct rte_eth_rxmode {
> >>      /** The multi-queue packet distribution mode to be used, e.g. RSS.
> */
> >>      enum rte_eth_rx_mq_mode mq_mode;
> >> -    uint32_t max_rx_pkt_len;  /**< Only used if JUMBO_FRAME enabled. */
> >> +    uint32_t mtu;  /**< Requested MTU. */
> >
> > Maximum Transmit Unit looks a bit confusing in Rx mode
> > structure.
> >
>
> True, but I think it is already used for Rx already as concept, I believe
> the
> intention will be clear enough. Do you think will be more clear if we pick
> a
> DPDK specific variable name?
>
Maybe use MRU - Max Receive Unit.


>
> >>      /** Maximum allowed size of LRO aggregated packet. */
> >>      uint32_t max_lro_pkt_size;
> >>      uint16_t split_hdr_size;  /**< hdr buf size (header_split
> enabled).*/
> >
> > [snip]
> >
>
>

--00000000000091fa2505c7ac3f1b--