From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 368DCA0C45; Thu, 22 Jul 2021 03:31:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD6CB4014E; Thu, 22 Jul 2021 03:31:39 +0200 (CEST) Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by mails.dpdk.org (Postfix) with ESMTP id D16014014D for ; Thu, 22 Jul 2021 03:31:38 +0200 (CEST) Received: by mail-qv1-f51.google.com with SMTP id w2so1896766qvh.13 for ; Wed, 21 Jul 2021 18:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lQsaI19GUR/QLlJfef+bI0R/hNOj93Yal/wg3a1wEyI=; b=HCrVMrITDNXo6ufv5vpzCVqTcSzaVQg4uM5l5qdnjmOLZVz1SBgw1zqAjau4yfm8JP 4C+k9pxTXxMktIoE7Rz4jarK6iNckD4CierKc8vCbxGnbg9S0l3aMiiKFXSvA4EiYGv3 izAATlSa5mGJhtvbcdFg3TncE+qGDHE8K53tw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lQsaI19GUR/QLlJfef+bI0R/hNOj93Yal/wg3a1wEyI=; b=HF/H9/oS0D4OOsUN6YTD260zjCJFmNYx6297BUHCwMs7R8OjwUxOBHUIY83oYZQ2hV vlQlY9kNxefI76qnRdfzV8yxJfJwHLR5/uHNK9Igj2vHLYXRDxutC3REjtBsclS1nIOb q3KzGH3Cgvy+n2hqA/osLyTYkJueKYMTmWLlGqIa2UsQbfNGT1+VoS2m2nQYCjs0eMqD U9bJl8++RubYlQM0krphT62EGFQHHBcn4wWk4JT9EI+E84/46w3Peu0J8n/cElBOkfDJ KQPfLygCbe1rbA2qKntIsZA6bfKQin17IfA6CwncAb8YF4J7cInUIKlz3gHibY5ich6d +qnQ== X-Gm-Message-State: AOAM530bZ89BxpJLklmDXh661mA+M5Bdwhl1dakpj6v78oLceXZuc5Z9 YRrs0HW8uJnB4DhRkMcg+hd8E0QLvS7mRphRBlPwQg== X-Google-Smtp-Source: ABdhPJzAwEv+xEDjmKYP9nThdekr7XEQz/R2H2rUaMxiNCEkFjpSHTjC+YNmV+v91FuadiU4ZLikxbujAywQebTivo8= X-Received: by 2002:ad4:54d0:: with SMTP id j16mr39330062qvx.30.1626917498008; Wed, 21 Jul 2021 18:31:38 -0700 (PDT) MIME-Version: 1.0 References: <20210709172923.3369846-1-ferruh.yigit@intel.com> <6655b8c1-82d8-27af-087c-c63153e79d3d@oktetlabs.ru> <61fbde10-1e3e-45a4-9877-f57f0aac2360@intel.com> In-Reply-To: <61fbde10-1e3e-45a4-9877-f57f0aac2360@intel.com> From: Ajit Khaparde Date: Wed, 21 Jul 2021 18:31:21 -0700 Message-ID: To: Ferruh Yigit Cc: Andrew Rybchenko , Jerin Jacob , Xiaoyun Li , Chas Williams , "Min Hu (Connor)" , Hemant Agrawal , Sachin Saxena , Qi Zhang , Xiao Wang , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Harman Kalra , Maciej Czekaj , Ray Kinsella , Neil Horman , Bernard Iremonger , Bruce Richardson , Konstantin Ananyev , John McNamara , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Yisen Zhuang , Lijun Ou , Beilei Xing , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Zyta Szpak , Liron Himi , Heinrich Kuhn , Devendra Singh Rawat , Keith Wiles , Jiawen Wu , Jian Wang , Maxime Coquelin , Chenbo Xia , Nicolas Chautru , David Hunt , Harry van Haaren , Cristian Dumitrescu , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Declan Doherty , Pavan Nikhilesh , Kirill Rybalchenko , Jasvinder Singh , Thomas Monjalon , dpdk-dev Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000091fa2505c7ac3f1b" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000091fa2505c7ac3f1b Content-Type: text/plain; charset="UTF-8" > > [snip] > > > >> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > >> index faf3bd901d75..9f288f98329c 100644 > >> --- a/lib/ethdev/rte_ethdev.h > >> +++ b/lib/ethdev/rte_ethdev.h > >> @@ -410,7 +410,7 @@ enum rte_eth_tx_mq_mode { > >> struct rte_eth_rxmode { > >> /** The multi-queue packet distribution mode to be used, e.g. RSS. > */ > >> enum rte_eth_rx_mq_mode mq_mode; > >> - uint32_t max_rx_pkt_len; /**< Only used if JUMBO_FRAME enabled. */ > >> + uint32_t mtu; /**< Requested MTU. */ > > > > Maximum Transmit Unit looks a bit confusing in Rx mode > > structure. > > > > True, but I think it is already used for Rx already as concept, I believe > the > intention will be clear enough. Do you think will be more clear if we pick > a > DPDK specific variable name? > Maybe use MRU - Max Receive Unit. > > >> /** Maximum allowed size of LRO aggregated packet. */ > >> uint32_t max_lro_pkt_size; > >> uint16_t split_hdr_size; /**< hdr buf size (header_split > enabled).*/ > > > > [snip] > > > > --00000000000091fa2505c7ac3f1b--