From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id A826BA0C5A;
Mon, 29 Nov 2021 19:11:56 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 2D6694068E;
Mon, 29 Nov 2021 19:11:56 +0100 (CET)
Received: from mail-il1-f178.google.com (mail-il1-f178.google.com
[209.85.166.178])
by mails.dpdk.org (Postfix) with ESMTP id 0B52B40689
for <dev@dpdk.org>; Mon, 29 Nov 2021 19:11:54 +0100 (CET)
Received: by mail-il1-f178.google.com with SMTP id e8so18370758ilu.9
for <dev@dpdk.org>; Mon, 29 Nov 2021 10:11:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=eHBKvZgOA37PBHmg2faFsTk/EiMcMQNQiGOepCXRHJ0=;
b=YFZXsX7ynxoDYzhQAbWz2i9Z6xH1TFRMj0ONi1Qu3G37af73kg6a3Z6Zl6XGGGtbNY
c804ex7bfoDGXE31OR1ibg8wK+Z5zgEnN8ZcUkI7DN9o+o0qP/zXh0M30SqvxGokxzCo
DoYFvJf+K4MwEuuQWly3YuY8GCO/6IsB6Bzis=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=eHBKvZgOA37PBHmg2faFsTk/EiMcMQNQiGOepCXRHJ0=;
b=cdljPFhTdlQDxpvM5+Dd9dSJj2kUeV1CvBqVcXq33AMZ/aoPpP+GWojujZBEq4L26o
P2rAIcbhZuClWwgqOmL9xw78gyNfgaBR0wdmnO8uoyPfo8o0ZNhy7GDj959u1imO+0uW
A/XSTGp/Ntcwb1fCtygplmTJYwrh82XYkzqJkT6tRQBv/bqClO0xMfBiVY9eTgTH2Olw
t17JEuv4ZYcQrLDrWEllIZo3ulEB1EmtGL1r+u/SstUV3D0MkFHKXMuQz9UmLmJeqxVB
202d4n3VedaVYDf8TQXiHNarqCbD588x598KOaT9C/gZXUo8KXhdo5ml5rgmN+wYxzIo
YrMQ==
X-Gm-Message-State: AOAM530O9qOijUELDvBImGP8x8xhCeDs4VotzCj55KIxnUJqkv/8FhrN
x5W9hKs+leAzOPZlPHeeozvi9d4+JgdACBzyLmBRkQ==
X-Google-Smtp-Source: ABdhPJy8ab1Suhrdpy+fXsMJ4KVWG+VhVZAS2avA/Tlar3++864t8KPDyXrFCObJx3P5H2lUUXGpTim25g052MkoYrw=
X-Received: by 2002:a05:6e02:20e5:: with SMTP id
q5mr56617003ilv.63.1638209513399;
Mon, 29 Nov 2021 10:11:53 -0800 (PST)
MIME-Version: 1.0
References: <20211126195851.50167-1-jsoref@users.noreply.github.com>
<737b8856-a247-3709-ad4c-a074d4547c86@intel.com>
<YaTcpcVk4+nPZ3MB@bricha3-MOBL.ger.corp.intel.com>
<2048067.usQuhbGJ8B@thomas>
In-Reply-To: <2048067.usQuhbGJ8B@thomas>
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: Mon, 29 Nov 2021 10:11:37 -0800
Message-ID: <CACZ4nhsGENbybJ2XU0vmVr=y5YFvq3iOLUD09OS3_Hgvb6+SCw@mail.gmail.com>
Subject: Re: [PATCH] Spelling
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Josh Soref <jsoref@gmail.com>, Josh Soref <jsoref@users.noreply.github.com>,
dpdk-dev <dev@dpdk.org>, David Marchand <david.marchand@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Mon, Nov 29, 2021 at 6:02 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 29/11/2021 14:59, Bruce Richardson:
> > On Mon, Nov 29, 2021 at 12:49:56PM +0000, Ferruh Yigit wrote:
> > > On 11/26/2021 7:58 PM, Josh Soref wrote:
> > > > diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c
> > > > index ff7813f9..603e7c91 100644
> > > > --- a/app/test-eventdev/test_order_common.c
> > > > +++ b/app/test-eventdev/test_order_common.c
> > > > @@ -253,7 +253,7 @@ void
> > > > order_opt_dump(struct evt_options *opt)
> > > > {
> > > > evt_dump_producer_lcores(opt);
> > > > - evt_dump("nb_wrker_lcores", "%d", evt_nr_active_lcores(opt->wlcores));
> > > > + evt_dump("nb_worker_lcores", "%d", evt_nr_active_lcores(opt->wlcores));
> > >
> > > Hi Josh, Thanks for the patch.
> > >
> > > The typo fixes for comments and logs are more straightforward, but I have
> > > mixed feeling about the variable / macro typo fixes, let's see what others
> > > think.
> > >
> > > And I think we should get this patch either one of the first patch or last
> > > patch to prevent conflict with other patches.
> >
> > +1 to being a first patch to start things off clean.
> >
> > For the macros, since there is quick a bit of content in the patch, could
> > we have the patch split into a separate patch for macro changes to review
> > separately, allowing the simple doc/printf spelling changes to go in
> > immediately?
>
> +1 to start with a patch on doc, comments and log messages
+1
>
>