Re: [PATCH v3 04/11] net/bnxt: update Truflow core

[Ajit Khaparde <ajit.khaparde@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 2054 bytes --]

On Sat, Jun 10, 2023 at 11:33 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 04/05/2023 19:36, Ajit Khaparde:
> > From: Randy Schacher <stuart.schacher@broadcom.com>
> >
> > Update TruFlow core code to:
> > - Add shared session management
> > - Add SRAM session management
> > - Add dynamic TCAM management
> > - Add shared TCAM session management
> > - Add Hot Upgrade support
> > - Update copyright year
>
> I suppose you can update the date in the previous patch
> for the whole driver.
To some extent the idea was to update the date in the patch when the
code change was happening, instead of a blanket date change.

>
> Also this patch is removing some blank lines out of Truflow.
> And I don't understand the need for removing the blank lines
> before the last #ifdef of the file.
The template files are auto generated using a bunch of scripts.
What we are seeing is probably because of that.
But we have cleaned up many of those in the v4 submission.

>
> More important, you are doing huge update of many different things
> in one patch.
> It looks like you don't want the community to follow what you are doing.
Actually, no.
As I mentioned above, most of the truflow files are auto generated.
The reason for bundling some of the changes together was to avoid
multiple patches hitting the mail server patch size limit.
We thought it might be better to take the patch size hit on one patch
instead of multiple patches.

We are working on some design changes to the auto generation scripts
which will avoid big churn in the template patches in the future.

>
> For info, there are other things to fix in this patchset:
> Error: Incorrect indent at drivers/net/bnxt/tf_ulp/generic_templates/meson.build
> rte_flow doc out of sync for bnxt
>         action set_mac_dst
>         action set_mac_src
> You can run the following script to catch these issues:
>         devtools/check-meson.py
>         devtools/check-doc-vs-code.sh
We have addressed these in the v4 version.

Thanks
>
>
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]