From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69343A0562; Sat, 17 Apr 2021 16:54:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 382F3161C3C; Sat, 17 Apr 2021 16:54:55 +0200 (CEST) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by mails.dpdk.org (Postfix) with ESMTP id 751214068F for ; Sat, 17 Apr 2021 16:54:53 +0200 (CEST) Received: by mail-qk1-f173.google.com with SMTP id f19so14126207qka.8 for ; Sat, 17 Apr 2021 07:54:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I4/zYPY8uQIE+8jv4CfJ+xJ7TQYJVCmL3+f7/9Rd9i4=; b=Zma+iysN5+IuYKifXjp/CcClDm9QBlJQvAOwi5/aLpK5mqxtz1zmWEdE1umAhs0DkP +ql5oQeH2kuAExAV/PS4ku1V/uvBJGnjCG51fOPB2L3O4fPXuEnde20de3pN5oPm32wV 8HsTijd2xereJb41r8GevZOCOrrmsh++bqofU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I4/zYPY8uQIE+8jv4CfJ+xJ7TQYJVCmL3+f7/9Rd9i4=; b=Tvpr85/gQXyQf3LGBtJKgwiaw/UBsC4Qmyq4In+s2YVPkx1yMLXW4Z8ewlgpFiNVot zjAo3TzHDqifJ60D3aSIvfwa0gGBblqmklDbNw2zW5XxAIbFKXMfnfWqGmNW8Doz5z8w qL8Gh7fHawLQauqNKYfSs4XBvULptuLglDA8cvwYO8HBxnwzjFHVlq9mehXMrM+f1PFp cjIsUPTPKKIsn7Vd37W+505NLyxNkw7CO8Omr7viWI5eH+6Zs2tRxTxsDUsdnY9TPAxO KkjvSDfMvqZmM9gzitux/K+s6T7WIXyDma5RV3lFCzvopsIpa4dE3QGOztiCERe9zL6H 2H6A== X-Gm-Message-State: AOAM531NdCIvoJZIqDFJEdn7D35BvTBf2jrg8/zP7bmqSsyLyndiCo8m P6oire7ZbH/OQAi9eheMUyzTroZFyWsmif8JvNAUIw== X-Google-Smtp-Source: ABdhPJxvyppMLKCpXgMwhxPeL0mHje2ipkgrpqDfwgFNCKM7S1IjjAyy4c0QVBpzbmjDrzaVHRX6uAzHSewiXVfsRlg= X-Received: by 2002:a37:43cc:: with SMTP id q195mr4311661qka.455.1618671292692; Sat, 17 Apr 2021 07:54:52 -0700 (PDT) MIME-Version: 1.0 References: <1618062393-205611-1-git-send-email-bingz@nvidia.com> <1618504877-95597-1-git-send-email-bingz@nvidia.com> <1618504877-95597-2-git-send-email-bingz@nvidia.com> In-Reply-To: From: Ajit Khaparde Date: Sat, 17 Apr 2021 07:54:36 -0700 Message-ID: To: Bing Zhao Cc: Ori Kam , NBU-Contact-Thomas Monjalon , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "dev@dpdk.org" Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000006ded1c05c02c4725" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: introduce conntrack flow action and item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000006ded1c05c02c4725 Content-Type: text/plain; charset="UTF-8" On Fri, Apr 16, 2021 at 11:10 PM Bing Zhao wrote: > > Hi Ajit, > > > -----Original Message----- > > From: Ajit Khaparde > > Sent: Saturday, April 17, 2021 5:47 AM > > To: Bing Zhao > > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon > > ; ferruh.yigit@intel.com; > > andrew.rybchenko@oktetlabs.ru; dev@dpdk.org > > Subject: Re: [PATCH v2 1/2] ethdev: introduce conntrack flow action > > and item > > > > > > > + > > > > > +/** > > > > > + * @warning > > > > > + * @b EXPERIMENTAL: this structure may change without prior > > > > notice > > > > > + * > > > > > + * Configuration parameters for each direction of a TCP > > > > connection. > > > > > + */ > > > > > +struct rte_flow_tcp_dir_param { > > > > > + uint32_t scale:4; /**< TCP window scaling factor, 0xF to > > > > disable. */ > > > > > + uint32_t close_initiated:1; /**< The FIN was sent by this > > > > direction. */ > > > > > + /**< An ACK packet has been received by this side. */ > > > > > + uint32_t last_ack_seen:1; > > > > > + /**< If set, indicates that there is unacked data of the > > > > connection. */ > > > > > + uint32_t data_unacked:1; > > > > > + /**< Maximal value of sequence + payload length over sent > > > > > + * packets (next ACK from the opposite direction). > > > > > + */ > > > > > + uint32_t sent_end; > > > > > + /**< Maximal value of (ACK + window size) over received > > packet > > > > + > > > > > length > > > > > + * over sent packet (maximal sequence could be sent). > > > > > + */ > > > > > + uint32_t reply_end; > > > > > > > > This comment is for all members that are part of the packet, Do > > you > > > > think it should be in network order? > > > > > > Almost none of the fields are part of the packet. Indeed, most of > > them are calculated from the packets information. So I prefer to > > keep the host order easy for using and > > > keep all the fields of the whole structure the same endianness > > format. > > > What do you think? > > > > Can you mention it in the documentation and comments? > > That all the values are in host byte order and need to be converted > > to > > network byte order if the HW needs it that way > > Sure, I think it would be better to add it in the documentation. > What do you think? Documentation - yes. In the comments of the structure in the header file - if possible. > > BR. Bing --0000000000006ded1c05c02c4725--