On Thu, Mar 17, 2022 at 3:11 AM David Marchand wrote: > > Kalesh, Ajit, > > On Tue, Mar 1, 2022 at 1:53 PM David Marchand wrote: > > On Thu, Mar 4, 2021 at 9:45 AM Kalesh A P > > wrote: > > > > > > From: Kalesh AP > > > > > > Fix HWRM_VER_GET command to handle DEV_NOT_RDY state. > > > > > > Driver should fail probe if the device is not ready. > > > Conversely, the HWRM_VER_GET poll after reset can safely > > > retry until the existing timeout is exceeded. > > > > > > Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Kalesh AP > > > Reviewed-by: Somnath Kotur > > > Reviewed-by: Randy Schacher > > > Reviewed-by: Ajit Kumar Khaparde > > > > This patch makes probing fail on a RHEL9 kernel with firmwares: > > firmware-version: 20.6.143.0/pkg 20.06.04.06 > > and > > firmware-version: 20.6.112.0 Oh wow! That's really old FW. > > > > Simply reverting the patch fixes probing in my env. > > > > This was reported by our QE team which is doing sanity checks on ovs > > 2.17 which uses dpdk v21.11. > > https://bugzilla.redhat.com/show_bug.cgi?id=2055531 > > QE confirmed reverting this patch fixed initialisation in their setup. > I reproduced the issue on another system with RHEL 8.5, and confirmed > that reverting the patch or upgrading the firmware fix the issue. > > I can understand new features in a PMD might require newer firmwares. > But breaking compatibility with older firmwares is a big no. I agree. Ideally this should not have been sent as a fix targeting the super-old commit 804e746c7b73. > > If there is no other option, I will send a revert for this patch. A version check may help avoid a complete revert. But that will require some testing, which means we are looking at mid-next week for the fix. Submit the revert patch, just in case it takes longer than that. Thanks Ajit > > > Thanks. > > -- > David Marchand >