From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80490A0093; Thu, 17 Mar 2022 17:48:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6312940E28; Thu, 17 Mar 2022 17:48:52 +0100 (CET) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mails.dpdk.org (Postfix) with ESMTP id 98CD04067B for ; Thu, 17 Mar 2022 17:48:51 +0100 (CET) Received: by mail-il1-f179.google.com with SMTP id r2so4180549ilh.0 for ; Thu, 17 Mar 2022 09:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f9pdA/lyZAfh6xApeOr7E/WdKJXbwOfIBEdx4XgFZic=; b=MWRB1eoAc4QAbkgLMggXu7vZFApoJboPhY80lz0CrEYssh3QYkYHT/vm8GaFoNGN9k clEXp4ccDwl5t+GEhFMKtV+yx6+HCOpHVRMgT/p8F92qJR1Fh22ycnC1LOsLtQ33YZFw qPgu6kmJ7vzfqHBQ1ck2jJMqwPMKZVKcB1Ki4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f9pdA/lyZAfh6xApeOr7E/WdKJXbwOfIBEdx4XgFZic=; b=iAKgv9m4/Br4cnkCOKGULAIMEIoFewTfLO1nTJDtT7qmpbOy577rqeGgCL8ofNT3an fjhJePJz2qlGBnu3tD6+YKjBBXwLgLBva09xuU8lfgFcTxl8vIdUpuuIXX8nDJFWX58G 90b97BQvhke/J2C9D9vXlljo/pKDmX4ywGw43MYee+jtPYZHeeP9xB3QNDItpJxfZF7f H/zfmMtCPmdCOVyiLyhgJKBkUNlCYvmFO5MVUYT0vo05iRF8LoyF3TvJhcg6HefhDDEx et3qrcKJxepVPbkCYdUwiR79/B4imAn7zNWJc8MiFQtUWPHl+9aXvY1DS8yA+IjIzp0e +Evw== X-Gm-Message-State: AOAM532vfR38OWlhZEk2riIPqt2LB6hd6lTrgf9NW3ISSTQoH/sSdOL7 tBew0dY9AW8zyql0qFmxwDpWzmR6BesJFMXwHJPoCQ== X-Google-Smtp-Source: ABdhPJyNS6rY2b1fnqykcaAE2rWXZfF3/lciZc/ijNbvGqZsT0mMHksnFXb0hGvu+3oJimseEp50x1KIt+wTrqOZD88= X-Received: by 2002:a92:d1c9:0:b0:2c7:e18d:ff42 with SMTP id u9-20020a92d1c9000000b002c7e18dff42mr2217325ilg.63.1647535730788; Thu, 17 Mar 2022 09:48:50 -0700 (PDT) MIME-Version: 1.0 References: <20210304090728.26166-1-kalesh-anakkur.purayil@broadcom.com> <20210304090728.26166-3-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: From: Ajit Khaparde Date: Thu, 17 Mar 2022 09:48:34 -0700 Message-ID: Subject: Re: [dpdk-dev] [PATCH 2/3] net/bnxt: fix ver get HWRM command To: David Marchand Cc: Kalesh A P , dev , Thomas Monjalon , Kevin Traynor , Luca Boccassi Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000002e8cf05da6cce2b" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000002e8cf05da6cce2b Content-Type: text/plain; charset="UTF-8" On Thu, Mar 17, 2022 at 3:11 AM David Marchand wrote: > > Kalesh, Ajit, > > On Tue, Mar 1, 2022 at 1:53 PM David Marchand wrote: > > On Thu, Mar 4, 2021 at 9:45 AM Kalesh A P > > wrote: > > > > > > From: Kalesh AP > > > > > > Fix HWRM_VER_GET command to handle DEV_NOT_RDY state. > > > > > > Driver should fail probe if the device is not ready. > > > Conversely, the HWRM_VER_GET poll after reset can safely > > > retry until the existing timeout is exceeded. > > > > > > Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Kalesh AP > > > Reviewed-by: Somnath Kotur > > > Reviewed-by: Randy Schacher > > > Reviewed-by: Ajit Kumar Khaparde > > > > This patch makes probing fail on a RHEL9 kernel with firmwares: > > firmware-version: 20.6.143.0/pkg 20.06.04.06 > > and > > firmware-version: 20.6.112.0 Oh wow! That's really old FW. > > > > Simply reverting the patch fixes probing in my env. > > > > This was reported by our QE team which is doing sanity checks on ovs > > 2.17 which uses dpdk v21.11. > > https://bugzilla.redhat.com/show_bug.cgi?id=2055531 > > QE confirmed reverting this patch fixed initialisation in their setup. > I reproduced the issue on another system with RHEL 8.5, and confirmed > that reverting the patch or upgrading the firmware fix the issue. > > I can understand new features in a PMD might require newer firmwares. > But breaking compatibility with older firmwares is a big no. I agree. Ideally this should not have been sent as a fix targeting the super-old commit 804e746c7b73. > > If there is no other option, I will send a revert for this patch. A version check may help avoid a complete revert. But that will require some testing, which means we are looking at mid-next week for the fix. Submit the revert patch, just in case it takes longer than that. Thanks Ajit > > > Thanks. > > -- > David Marchand > --00000000000002e8cf05da6cce2b Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDBCmE9BT7srhoNHDEDANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDE4MjdaFw0yMjA5MjIxNDUxNDlaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEAwXsxfYF9jpj9zve1vXxD491SrWDVlcmLMdnOS1c7POMC8lbbgvp1o2kIu/3n xCVFTai5H6rHZgrFItNNVZ+XaJW9Ob9eiSuXdnAu5gVdTb+IFAf4S/PT2LXzpP07M7vyvm/yvA+8 HtVfapzqqTNYdNVUpq28MYsKEWbnyK94x5+C3oCAV4bpNnMoPNtKrMhvOdpTREQRyew8hyy3/Mz7 RIaCW0xx+14NTQe17dkH6CEEpmCjejneq/FU0gmbuorwHoP9mOiqeh23/ZKVpmFO/eiDtvMNAMDW 6LzhOk/pMklUPTHu/gQNW3OQebyhyFUHiBSp8rDkfWZT57Asd0PtdQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUPHif0ihgndR0 h7r3sANaOIu2yM8wDQYJKoZIhvcNAQELBQADggEBAAEuLXDnP0Xd2zAMpQobXLUyqbpqGMO6ycQc Xq4H2YYlSNKVwPA+ZAVdUOzbSimBKlx8mzAEHkI3Ll1yXlYeT4UwkfWV9fioyGuQelLN1sGzi5bm WEpaSIbR1eiJMtzxUPwpRTn19gHZVueIot2Gw0fEYgHiMJpUr6xBWv2QNXULu/E8qvbXIRh2iycq 5rWFggX/JHglO8nVqzb1ImzqzVMFnDN15h3j8ryy2MIvZ8VDQRP7l81IXaTvVwaKpWMgV6rfQOi6 aOQZuOKkad7qoCkS5N2oSsvxi+rZtDaJJNsDjs05y5JZZQtBlfAmdYS+mmvkPjZ1iaLTzk59o/Yo fNkxggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwQphPQ U+7K4aDRwxAwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIGt5EL+zljwlVVdzksAx sF2ByVi//z5oYHQXNCh+ucGwMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIyMDMxNzE2NDg1MVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQB9pq+bd9o9sqPFTpbZwqiT4qTG/oxLUe6Rv+JY btiY6xAPCt+avJr9+CkoeSwRL/9jS//ifCBW9ECL1wgReTowf4HcT6xkc17Z6AOGcLCeKTYEz4R2 RqY5LQUDSLuFi707+fLxkujEu7kTvT7ah8TCX6rw8Xf9sy63MOhai9ygUxDUGoakwiv3e6d/tk42 vmXZqcy3aUvBbaAPR70XpPxqZnD9ytOINITw62AbDVd0FRtNRQUCU3JKWC0vGHrL9Y2V+rHQD6tY gNlZjd8Juumr4l4IU3eRezyhVWiFuB8qT3r4Ffo0dbugQ1t6ZDgVx3J2OeW1VhZa+p84CSCPZkvn --00000000000002e8cf05da6cce2b--