From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Weiguo Li <liwg06@foxmail.com>
Cc: sbhosle@broadcom.com, michael.baucom@broadcom.com,
kishore.padmanabha@broadcom.com,
venkatkumar.duvvuru@broadcom.com, dev@dpdk.org, stable@dpdk.org,
Weiguo Li <liweiguo@xencore.cn>
Subject: Re: [PATCH] net/bnxt: fix deadlock in mgr timer cb
Date: Thu, 8 Feb 2024 13:45:13 -0800 [thread overview]
Message-ID: <CACZ4nhsVuBOmr0vBoSycjcr3n1w+P9Y04Bx2R5qnS24euLj=4w@mail.gmail.com> (raw)
In-Reply-To: <tencent_7B6D2301220A31DB3CA9A701112E3A47DF08@qq.com>
[-- Attachment #1: Type: text/plain, Size: 1503 bytes --]
On Fri, Nov 3, 2023 at 9:07 PM Weiguo Li <liwg06@foxmail.com> wrote:
>
> The function 'ulp_ha_mgr_timer_cb' acquires a lock on the context
> entry at the beginning with bnxt_ulp_cntxt_entry_acquire(). This lock
> is expected to be released by bnxt_ulp_cntxt_entry_release() at the
> end of the function.
>
> However, the second early return statement in the function could
> potentially bypass the lock release. To fix this issue, add
> bnxt_ulp_cntxt_entry_release() before the return statement.
>
> Fixes: 1993b267dbcb ("net/bnxt: cleanup ULP parser and mapper)
> CC: stable@dpdk.org
>
> Signed-off-by: Weiguo Li <liweiguo@xencore.cn>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Fixed up the author and signed-off-by mismatch and merged in
brcm-next-net for-next-net branch.
> ---
> drivers/net/bnxt/tf_ulp/ulp_ha_mgr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/bnxt/tf_ulp/ulp_ha_mgr.c b/drivers/net/bnxt/tf_ulp/ulp_ha_mgr.c
> index f3f5bda890..852deef3b4 100644
> --- a/drivers/net/bnxt/tf_ulp/ulp_ha_mgr.c
> +++ b/drivers/net/bnxt/tf_ulp/ulp_ha_mgr.c
> @@ -253,6 +253,7 @@ ulp_ha_mgr_timer_cb(void *arg)
>
> myclient_cnt = bnxt_ulp_cntxt_num_shared_clients_get(ulp_ctx);
> if (myclient_cnt == 0) {
> + bnxt_ulp_cntxt_entry_release();
> BNXT_TF_DBG(ERR,
> "PANIC Client Count is zero kill timer\n.");
> return;
> --
> 2.34.1
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
prev parent reply other threads:[~2024-02-08 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 4:06 Weiguo Li
2024-02-08 21:45 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhsVuBOmr0vBoSycjcr3n1w+P9Y04Bx2R5qnS24euLj=4w@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=kishore.padmanabha@broadcom.com \
--cc=liweiguo@xencore.cn \
--cc=liwg06@foxmail.com \
--cc=michael.baucom@broadcom.com \
--cc=sbhosle@broadcom.com \
--cc=stable@dpdk.org \
--cc=venkatkumar.duvvuru@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).