From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06D27A0C4E; Mon, 12 Jul 2021 23:44:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB27B4069E; Mon, 12 Jul 2021 23:44:09 +0200 (CEST) Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by mails.dpdk.org (Postfix) with ESMTP id 3445E4069D for ; Mon, 12 Jul 2021 23:44:08 +0200 (CEST) Received: by mail-qk1-f176.google.com with SMTP id 201so5439105qkj.13 for ; Mon, 12 Jul 2021 14:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rv89xWufz2BxpVfKgrFEVrpw5nIMCOFU0SwYPUX89AE=; b=gws7rletrMExTVO/aOGBu7tptagbCfGIICHAzDIZFM6P1e15OFR2CkWZYQf2C3z4P2 xKyKS2G7bMng0UpXN+Vd5nTlQJhmG3L1OJ9UNIc5tKuhpWuZETXfEAIdGOaiF/AJYnps dZEnJzAYzHGPj95CaSx+ydTvkWp19ZWnM2nSM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rv89xWufz2BxpVfKgrFEVrpw5nIMCOFU0SwYPUX89AE=; b=WgWKTpUV5LxHR9yASLfqR54oeVoycv7UfdSJAH1O5To6lC3T8PQ2fN1iX03v+5gjg4 C8/zH2ZYMAc2gOQlqqiSxOd9AjcA/4EflufC+w2rNyXxXAQKiWU3oINsc5K+Qjf2maN+ I6YDZtVXLHI594vosNxdpR0cBnggITYcYXZPy22xY7jDZTlOpRxn5Xq1dbSdr727CyQP Kxc569H/QazQaY8ipEsw8ZSCfHdxpyNddXHe61k1WyHpox4CuJqCfW1YdloOAfUirZ8y 7NOWulfT2dN7MC1cilC7xh65qoHHG9SRtbvsLCv5Rv4Ebj5COs6pt3I3xjUHdABF+zSZ 757g== X-Gm-Message-State: AOAM5302b/JJjHbSFVwjp2MPki3DV7iJ+TcZE/7vH0G9RbZiAwm4Rk+b xxpjcpKSIOyqV5v4Y/kdy8qjPhAcc8LDr+j/aneKbg== X-Google-Smtp-Source: ABdhPJyX5P6S6zr+CHHgBgf8RD1jhdyE4kDC42ujOUK6ZdoPoTqAmnwIXD2R1kMHQ1WV92LwBHWK7YOlxPCVTisUkeQ= X-Received: by 2002:a05:620a:21c2:: with SMTP id h2mr789486qka.333.1626126247319; Mon, 12 Jul 2021 14:44:07 -0700 (PDT) MIME-Version: 1.0 References: <20210708191501.77972-1-lance.richardson@broadcom.com> <20210709163849.88214-1-lance.richardson@broadcom.com> In-Reply-To: From: Ajit Khaparde Date: Mon, 12 Jul 2021 14:43:50 -0700 Message-ID: To: Ruifeng Wang Cc: Lance Richardson , Somnath Kotur , Bruce Richardson , Konstantin Ananyev , "jerinj@marvell.com" , Stephen Hurd , David Christensen , "dev@dpdk.org" , "stable@dpdk.org" , nd Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000005a1c6905c6f40564" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v2] net/bnxt: fix missing barriers in completion handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000005a1c6905c6f40564 Content-Type: text/plain; charset="UTF-8" On Sun, Jul 11, 2021 at 7:34 PM Ruifeng Wang wrote: > > -----Original Message----- > > From: Lance Richardson > > Sent: Saturday, July 10, 2021 12:39 AM > > To: Ajit Khaparde (ajit.khaparde@broadcom.com) > > ; Somnath Kotur > > ; Bruce Richardson > > ; Konstantin Ananyev > > ; jerinj@marvell.com; Ruifeng Wang > > ; Stephen Hurd ; > > David Christensen > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: [PATCH v2] net/bnxt: fix missing barriers in completion handling > > > > Ensure that Rx/Tx/Async completion entry fields are accessed > > only after the completion's valid flag has been loaded and > > verified. This is needed for correct operation on systems that > > use relaxed memory consistency models. > > > > Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code") > > Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") > > Cc: stable@dpdk.org > > Signed-off-by: Lance Richardson > > Reviewed-by: Ajit Khaparde > > --- > > v2: > > * Corrected name of the first parameter to bnxt_cpr_cmp_valid() in > > comments ('cmp' to 'cmpl'). > > > > drivers/net/bnxt/bnxt_cpr.h | 36 ++++++++++++++++++++++++--- > > drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++------ > > drivers/net/bnxt/bnxt_irq.c | 7 +++--- > > drivers/net/bnxt/bnxt_rxr.c | 9 ++++--- > > drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 2 +- > > drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 2 +- > > drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 2 +- > > drivers/net/bnxt/bnxt_txr.c | 2 +- > > 8 files changed, 54 insertions(+), 22 deletions(-) > > > Reviewed-by: Ruifeng Wang > Patch applied to dpdk-next-net-brcm. Thanks --0000000000005a1c6905c6f40564--