From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Li Zhang <lizh@nvidia.com>
Cc: Dekel Peled <dekelp@nvidia.com>, Ori Kam <orika@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>, dpdk-dev <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Raslan Darawsheh <rasland@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] [RFC]: adds support PPS(packet per second) on meter
Date: Fri, 12 Feb 2021 13:35:53 -0800 [thread overview]
Message-ID: <CACZ4nhsX9LOMrYpr_hUmUE2YseO7Ec7+f1LA0_DSvbnLN8K1Tw@mail.gmail.com> (raw)
In-Reply-To: <20210125010235.1768333-2-lizh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 3127 bytes --]
On Sun, Jan 24, 2021 at 5:02 PM Li Zhang <lizh@nvidia.com> wrote:
> Currently the flow Meter algorithms in rte_flow only supports bytes per
> second(BPS).
> Such as Single Rate Three Color Marker (srTCM rfc2697)
> This RFC adds the packet per second definition in Meter algorithms
> structure,
> to support the rte_mtr APIs with type srTCM pps mode.
>
I thought rfc2697 specified metering using BPS only.
The CIR was measured in bytes per second for IP packets.
Is there a draft or link to the new srTCM mode?
> The below structure will be extended:
> rte_mtr_algorithm
> rte_mtr_meter_profile
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> ---
> lib/librte_ethdev/rte_mtr.h | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/lib/librte_ethdev/rte_mtr.h b/lib/librte_ethdev/rte_mtr.h
> index 916a09c5c3..6413892aec 100644
> --- a/lib/librte_ethdev/rte_mtr.h
> +++ b/lib/librte_ethdev/rte_mtr.h
> @@ -119,6 +119,9 @@ enum rte_mtr_algorithm {
>
> /** Two Rate Three Color Marker (trTCM) - IETF RFC 4115. */
> RTE_MTR_TRTCM_RFC4115,
> +
> + /** Single Rate Three Color Marker (srTCM) in Packet per second
> mode */
> + RTE_MTR_SRTCM_PPS,
> };
>
> /**
> @@ -171,6 +174,18 @@ struct rte_mtr_meter_profile {
> /** Excess Burst Size (EBS) (bytes). */
> uint64_t ebs;
> } trtcm_rfc4115;
> +
> + /** Items only valid when *alg* is set to srTCM - PPS. */
> + struct {
> + /** Committed Information Rate
> (CIR)(packets/second). */
> + uint64_t cir;
> +
> + /** Committed Burst Size (CBS) (bytes). */
> + uint64_t cbs;
> +
> + /** Excess Burst Size (EBS) (bytes). */
> + uint64_t ebs;
> + } srtcm_pps;
> };
> };
>
> @@ -317,6 +332,13 @@ struct rte_mtr_capabilities {
> */
> uint32_t meter_trtcm_rfc4115_n_max;
>
> + /** Maximum number of MTR objects that can have their meter
> configured
> + * to run the srTCM packet per second algorithm. The value of 0
> + * indicates this metering algorithm is not supported.
> + * The maximum value is *n_max*.
> + */
> + uint32_t meter_srtcm_pps_n_max;
> +
> /** Maximum traffic rate that can be metered by a single MTR
> object. For
> * srTCM RFC 2697, this is the maximum CIR rate. For trTCM RFC
> 2698,
> * this is the maximum PIR rate. For trTCM RFC 4115, this is the
> maximum
> @@ -342,6 +364,12 @@ struct rte_mtr_capabilities {
> */
> int color_aware_trtcm_rfc4115_supported;
>
> + /**
> + * When non-zero, it indicates that color aware mode is supported
> for
> + * the srTCM packet per second metering algorithm.
> + */
> + int color_aware_srtcm_pps_supported;
> +
> /** When non-zero, it indicates that the policer packet recolor
> actions
> * are supported.
> * @see enum rte_mtr_policer_action
> --
> 2.21.0
>
>
next prev parent reply other threads:[~2021-02-12 21:36 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 1:02 [dpdk-dev] [RFC 0/1] lib/librte_ethdev: Meter algorithms support packet per second Li Zhang
2021-01-25 1:02 ` [dpdk-dev] [PATCH] [RFC]: adds support PPS(packet per second) on meter Li Zhang
2021-01-25 1:20 ` [dpdk-dev] [RFC 0/1] lib/librte_ethdev: Meter algorithms support packet per second Li Zhang
2021-01-25 1:20 ` [dpdk-dev] [PATCH] [RFC, v2]: adds support PPS(packet per second) on meter Li Zhang
2021-01-28 18:27 ` Ferruh Yigit
2021-02-12 7:40 ` Morten Brørup
2021-02-23 2:07 ` Li Zhang
2021-02-23 8:24 ` Morten Brørup
2021-03-01 3:16 ` Li Zhang
2021-03-01 3:31 ` Ajit Khaparde
2021-03-01 7:20 ` Morten Brørup
2021-03-01 13:08 ` Dumitrescu, Cristian
2021-03-01 9:39 ` [dpdk-dev] [RFC v3 0/4] " Li Zhang
2021-03-01 9:39 ` [dpdk-dev] [RFC v3 1/4] ethdev: add meter PPS profile Li Zhang
2021-03-01 9:39 ` [dpdk-dev] [RFC v3 2/4] common/mlx5: add meter mode definition in PRM file Li Zhang
2021-03-01 9:39 ` [dpdk-dev] [RFC v3 3/4] net/mlx5: support meter PPS profile Li Zhang
2021-03-01 9:40 ` [dpdk-dev] [RFC v3 4/4] app/testpmd: add meter pps mode cmd Li Zhang
2021-03-01 9:43 ` [dpdk-dev] [RFC v3 0/4] adds support PPS(packet per second) on meter Li Zhang
2021-03-01 9:43 ` [dpdk-dev] [RFC v3 1/4] ethdev: add meter PPS profile Li Zhang
2021-03-01 9:43 ` [dpdk-dev] [RFC v3 2/4] common/mlx5: add meter mode definition in PRM file Li Zhang
2021-03-01 9:43 ` [dpdk-dev] [RFC v3 3/4] net/mlx5: support meter PPS profile Li Zhang
2021-03-01 9:43 ` [dpdk-dev] [RFC v3 4/4] app/testpmd: add meter pps mode cmd Li Zhang
2021-03-01 9:53 ` [dpdk-dev] [RFC v3 0/4] adds support PPS(packet per second) on meter Li Zhang
2021-03-01 9:53 ` [dpdk-dev] [RFC v3 1/4] ethdev: add meter PPS profile Li Zhang
2021-03-01 9:53 ` [dpdk-dev] [RFC v3 2/4] common/mlx5: add meter mode definition in PRM file Li Zhang
2021-03-01 9:53 ` [dpdk-dev] [RFC v3 3/4] net/mlx5: support meter PPS profile Li Zhang
2021-03-01 9:53 ` [dpdk-dev] [RFC v3 4/4] app/testpmd: add meter pps mode cmd Li Zhang
2021-02-12 21:35 ` Ajit Khaparde [this message]
2021-02-23 2:11 ` [dpdk-dev] [PATCH] [RFC]: adds support PPS(packet per second) on meter Li Zhang
2021-03-01 10:35 ` [dpdk-dev] [RFC v4 0/4] " Li Zhang
2021-03-01 10:35 ` [dpdk-dev] [RFC v4 1/4] ethdev: add meter PPS profile Li Zhang
2021-03-01 13:20 ` Dumitrescu, Cristian
2021-03-01 15:53 ` Thomas Monjalon
2021-03-02 1:27 ` Li Zhang
2021-03-02 1:46 ` Ajit Khaparde
2021-03-02 12:13 ` Dumitrescu, Cristian
2021-03-02 7:02 ` Matan Azrad
2021-03-02 12:29 ` Dumitrescu, Cristian
2021-03-02 12:37 ` Matan Azrad
2021-03-02 14:33 ` Dumitrescu, Cristian
2021-03-02 18:10 ` Matan Azrad
2021-03-03 20:35 ` Dumitrescu, Cristian
2021-03-04 6:34 ` Matan Azrad
2021-03-05 18:44 ` Dumitrescu, Cristian
2021-03-01 10:35 ` [dpdk-dev] [RFC v4 2/4] common/mlx5: add meter mode definition in PRM file Li Zhang
2021-03-01 10:35 ` [dpdk-dev] [RFC v4 3/4] net/mlx5: support meter PPS profile Li Zhang
2021-03-01 10:35 ` [dpdk-dev] [RFC v4 4/4] app/testpmd: add meter pps mode cmd Li Zhang
2021-03-02 1:48 ` Li, Xiaoyun
2021-03-02 3:04 ` Li Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhsX9LOMrYpr_hUmUE2YseO7Ec7+f1LA0_DSvbnLN8K1Tw@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dekelp@nvidia.com \
--cc=dev@dpdk.org \
--cc=lizh@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).