From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00A7641DBC; Fri, 3 Mar 2023 02:18:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D39940EE3; Fri, 3 Mar 2023 02:18:07 +0100 (CET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id E4B6340687 for ; Fri, 3 Mar 2023 02:18:05 +0100 (CET) Received: by mail-pj1-f52.google.com with SMTP id h11-20020a17090a2ecb00b00237c740335cso779820pjs.3 for ; Thu, 02 Mar 2023 17:18:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1677806285; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gh++HW2RoLQe/GNimyMLfMoL1e2BArRoa5xe8NnxUxs=; b=VGMSbVkWU9bvKKUhlTgLM193+96bSgPfkurbKxGTJ7Ja1J5WubzYmzMEW3DPRdFUhd chvbT3WVpx2qLfyGmsT5HCMs6cIgpoGAxk+i8GQvVoaILQiCaUOwQsKREhez6ljsLveR DUP+g0ar00344vuFSpgzXjLEpLOI0bIgUDd68= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677806285; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gh++HW2RoLQe/GNimyMLfMoL1e2BArRoa5xe8NnxUxs=; b=MdFsNRF2jq/5n7CIL6e2pQIr7yEp7BpR1OD8qBdsWUkENQGeMyuBwsCzhauEtQv6Wb U1tVmWqiC5oXT1lOr77NlJt458X8EFv8hhUwpJjG04qAfBe6dAjuNrdeaY5IttOCxxPH lLi+Qr4EwNRxHpOo4qQHGjssv+HZa3DZnROnpxhDJJWf7JISrB4d5sFZdSBpKNgRCu// uiwsQZ/+ymwURp7s2GDphdjHvR1MpXua9MgOeTfqjxz7HwMdSSG6HgVYiZlACtFOHwT+ 8NbASroJF2Ju1gzMLMImFCfQQp+VNcWAFpxk0+JbnUtVWtNoaptvhswVPGsloh6Ky/if l5tQ== X-Gm-Message-State: AO0yUKUNT8ryEQNE7pkDlSfxthOl5/JM+BDT2qj+nLQh8VzSwsGKUDEE 11yFSvk2vLvDWF/wIP9xsELcMrKNU6hMl2NfdHnpuA== X-Google-Smtp-Source: AK7set9AXLBe6d0GAr8PQuKRuhyKHpN7vdfllsnBSWKKUnBgdY18JRElR/4cix0a92ih0i0N2thtL2o3fPMlGD8YBdc= X-Received: by 2002:a17:90a:39c8:b0:233:cc2c:7dae with SMTP id k8-20020a17090a39c800b00233cc2c7daemr4641030pjf.8.1677806284823; Thu, 02 Mar 2023 17:18:04 -0800 (PST) MIME-Version: 1.0 References: <20230301030610.49468-1-fengchengwen@huawei.com> <20230301030610.49468-5-fengchengwen@huawei.com> In-Reply-To: From: Ajit Khaparde Date: Thu, 2 Mar 2023 17:17:48 -0800 Message-ID: Subject: Re: [PATCH 4/5] net/bnxt: use fp ops setup function To: Konstantin Ananyev Cc: dev@dpdk.org Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000a19a5905f5f4b783" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000a19a5905f5f4b783 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 2, 2023 at 4:01=E2=80=AFPM Konstantin Ananyev wrote: > > 02/03/2023 12:30, Konstantin Ananyev =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > >> Use rte_eth_fp_ops_setup() instead of directly manipulating > >> rte_eth_fp_ops variable. > >> > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Chengwen Feng > >> --- > >> drivers/net/bnxt/bnxt_cpr.c | 5 +---- > >> drivers/net/bnxt/bnxt_ethdev.c | 5 +---- > >> 2 files changed, 2 insertions(+), 8 deletions(-) > >> > >> diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c > >> index 3950840600..a3f33c24c3 100644 > >> --- a/drivers/net/bnxt/bnxt_cpr.c > >> +++ b/drivers/net/bnxt/bnxt_cpr.c > >> @@ -416,10 +416,7 @@ void bnxt_stop_rxtx(struct rte_eth_dev *eth_dev) > >> eth_dev->rx_pkt_burst =3D rte_eth_pkt_burst_dummy; > >> eth_dev->tx_pkt_burst =3D rte_eth_pkt_burst_dummy; > > > > I am not that familiar with bnxt driver, but shouldn't we set here > > other optional fp_ops (descripto_status, etc.) to some dummy values OR = to null values? > > After another thought - wouldn't it be better just to call > fp_ops_reset() here? Yes. I was actually thinking the same. A reset equivalent of the setup. > > > > >> > >> - rte_eth_fp_ops[eth_dev->data->port_id].rx_pkt_burst =3D > >> - eth_dev->rx_pkt_burst; > >> - rte_eth_fp_ops[eth_dev->data->port_id].tx_pkt_burst =3D > >> - eth_dev->tx_pkt_burst; > >> + rte_eth_fp_ops_setup(eth_dev); > >> rte_mb(); > >> > >> /* Allow time for threads to exit the real burst functions. */ > >> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_et= hdev.c > >> index 4083a69d02..d6064ceea4 100644 > >> --- a/drivers/net/bnxt/bnxt_ethdev.c > >> +++ b/drivers/net/bnxt/bnxt_ethdev.c > >> @@ -4374,10 +4374,7 @@ static void bnxt_dev_recover(void *arg) > >> if (rc) > >> goto err_start; > >> > >> - rte_eth_fp_ops[bp->eth_dev->data->port_id].rx_pkt_burst =3D > >> - bp->eth_dev->rx_pkt_burst; > >> - rte_eth_fp_ops[bp->eth_dev->data->port_id].tx_pkt_burst =3D > >> - bp->eth_dev->tx_pkt_burst; > >> + rte_eth_fp_ops_setup(bp->eth_dev); > >> rte_mb(); > >> > >> PMD_DRV_LOG(INFO, "Port: %u Recovered from FW reset\n", > >> -- > >> 2.17.1 > > > --000000000000a19a5905f5f4b783 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIIRSYxU2j8X+da9wRbZo OSmHvv7VdtghoeF3d2ea9tfeMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIzMDMwMzAxMTgwNVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQAlG5EChjb0J4PBq8XePIg7zA403BH00qYU5SQr QMGddLrC0+xZjj6Rf5Xmw6AC9Q015uWBqL/tBdO0eWpb3xUzOo0Zv5yzeoqbm/z7oFyasiLrOw7D 6FUSgsae3+OUnyzStUmHB5gLsWu0m6D77G147asEWkwATb6CCf2WfAYuC7vVbw+pk9jmg/KmgP7v EQq22cjSVX4I97eQptr0g1WT9jeH4UbtqdAu3jWnkC4GNsJXbXrTcD9qSLbuPcdh9q6bAotK/5Rg LvHE1JrBEOD+1qWo7nwX/AABelvaitWNWIEbV7A9ZgNJjIVOmAfnmNpmrdbldR5LQnsZ3NUuoAb4 --000000000000a19a5905f5f4b783--