From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AD9EA04E1; Tue, 22 Sep 2020 07:16:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 161E71D71F; Tue, 22 Sep 2020 07:16:10 +0200 (CEST) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id 571C91D6D1 for ; Tue, 22 Sep 2020 07:16:09 +0200 (CEST) Received: by mail-oi1-f196.google.com with SMTP id m7so19765359oie.0 for ; Mon, 21 Sep 2020 22:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t4gXK+SYdZ7zxesZWQhlgi62YOtH+5GW5PJ4xTsw5oY=; b=dl+kqiVUUGrbBTNm43Qm64Du5698UD3YdBJzAkiZo2TzXuVRaJmo/4A6v+JBoulhPk eLfzSir/4JJQCYw6ltSWQ1cFqLtUA/hJung+JFp1MLIsWlwfMTuqFx3I0ly8/3csJQf3 Nqmgpco0nvEEjGh4txbk4EU+mIvvhcpBEQXQA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t4gXK+SYdZ7zxesZWQhlgi62YOtH+5GW5PJ4xTsw5oY=; b=Fwkp0T7UJHeVLMABdUtl4yx6JjiBu3vsoSNCiLcAuexaa9PhXRFG0RYd1sf26rqxdd h/ViJRVuq2Cnz9g/95+y6GPRVfoSJmmncbOqdW0soiPp1sxE59NT0MvZ2n5oxA3AT3f2 s+/IHzHZ43IwPl6D+HuUUxNBAmPo/6nwMKyt+EIbb5Y7f18VerQxW6UuauO3QLYqFGPj QToF30Benf8dxWGUTwH9tT2cQnxtJulMxvEf3qvR7yhG+9HgTXJqyIlODAtlQAE/UE6l /EX7CL4fsQiRPA7yRiswgjWbt3G3TViLX9Pu//mBDHBorLy0a/BXNvcm9s7M7mVe/9Ck NVpA== X-Gm-Message-State: AOAM530IAINoFh/3S8y2JJQQ/ZEAM3nJbuPiWeShfH8RqMG/VNW90NBt ZvP5Fzxu58zPcv1ltzfvzvmwOWdNxaW5Q01g0Ro0CQ== X-Google-Smtp-Source: ABdhPJzqIFGMFXWzxW3hBGwt8lyZFzuBzo1go8BbL5b+il71jyMEzErsSfMq9Gv7g2PcXyZ4ePNhRynkbbfOta3Hmuc= X-Received: by 2002:a05:6808:5ca:: with SMTP id d10mr1684784oij.27.1600751768408; Mon, 21 Sep 2020 22:16:08 -0700 (PDT) MIME-Version: 1.0 References: <20200908021603.44862-1-huwei013@chinasoftinc.com> <20200908021603.44862-3-huwei013@chinasoftinc.com> In-Reply-To: <20200908021603.44862-3-huwei013@chinasoftinc.com> From: Ajit Khaparde Date: Mon, 21 Sep 2020 22:15:52 -0700 Message-ID: To: "Wei Hu (Xavier)" Cc: dpdk-dev , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Jijiang Liu , Jingjing Wu , Helin Zhang , "Wei Hu (Xavier" , lihuisong@huawei.com, Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: retain original FDIR mode when configuring DCB X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 7, 2020 at 7:16 PM Wei Hu (Xavier) wrote: > > From: Huisong Li > > Sometimes, we have to start testpmd application with --pkt-filter-mode to > test flow table feature. When using 'port config 0 dcb vt off 4 pfc on' > command, the dcb information are configured in init_port_dcb_config > function by get_eth_dcb_conf function, And then rte_eth_dev_configure API > function will be called to re-configure PMD driver. > > The values of rxmode and txmode in rte_eth_conf struct used to configure > PMD driver, come from the current values maintained in testpmd. However, > the fdir_conf.mode in rte_eth_conf struct is not set, which may cause that > some PMD driver cannot test the flow table feature when multiple TCs are > enabled. > > Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic class") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Wei Hu (Xavier) > --- > app/test-pmd/testpmd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 73543bb..19bf972 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3521,6 +3521,7 @@ init_port_dcb_config(portid_t pid, > > port_conf.rxmode = rte_port->dev_conf.rxmode; > port_conf.txmode = rte_port->dev_conf.txmode; > + port_conf.fdir_conf.mode = rte_port->dev_conf.fdir_conf.mode; This is probably not necessary. FDIR is due for deprecation [1]. https://doc.dpdk.org/guides/rel_notes/deprecation.html > > /*set configuration of DCB in vt mode and DCB in non-vt mode*/ > retval = get_eth_dcb_conf(pid, &port_conf, dcb_mode, num_tcs, pfc_en); > -- > 2.9.5 >