From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D24FA052B; Tue, 28 Jul 2020 19:34:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C7C11BE8A; Tue, 28 Jul 2020 19:34:14 +0200 (CEST) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 70BD510A3 for ; Tue, 28 Jul 2020 19:34:12 +0200 (CEST) Received: by mail-ot1-f68.google.com with SMTP id c25so15461415otf.7 for ; Tue, 28 Jul 2020 10:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6wGdo1ufEjiMDlKZjl6naKeaCiE4RgeSNiuS2QVHrBw=; b=LziMXsiGaxJO7+DUONMeaTauyzB0UAFuntMgqL6LkFWmJKg/7LQXwL7wek9OFtZg7/ fg0YtXWF8RBbGpP8ZTG6J4VWXpyzEqxegvQv5juYWrpAa0xgFuYT9aS7jaGc4imPWrK5 9FYPovlhCc0kadMGJBZYUSr76gwY72g85JA8g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6wGdo1ufEjiMDlKZjl6naKeaCiE4RgeSNiuS2QVHrBw=; b=YUBuFpv1GHK0qBvLoddOZcSVJ6pU9X+3GsPig0XplBdvM21PS12MYCKH8zGtwVnvh0 jfdY8CY7gVpnw3bKwrnlqdBJF0qOWLwHAmPBn93wNYspVCY75KF6DB6v3Hoq05Fo8vFT C3it7j3L7Z+ryh/i/o3aKKlgkWCMPDo43V5z3vLgG3JYUgWdorFkVDVa6WxKTsLT82Ok nCSJEKbJ//I3UUwOEMJDrhke2scrROBTBn3iHTHZ41Cqopa/JuAizNkTRHb3+iBdNBiZ I7Znh7XucyVXyIPhziYsIf7ezpIHVQTWRqA5hVwL9H26iTtH9ZVgOvL6+ux0W3bTK19u JRNw== X-Gm-Message-State: AOAM531raMxAUDcW5pDy5hGwOBkvTvAunUGzsoMCALRooi7qJulMD8Cf FKrx0bn6WUamBUmqvYJ2VA4ebhVFzoxQ7JbvI4m38w== X-Google-Smtp-Source: ABdhPJyOn0aay4gSduMAfEdqZzvb05ZPbghqQ8qVUuV8U/1Kb25IklYjmjRC9Fzx3lF+DhplV1ej8HI5LOEHbHC5+Io= X-Received: by 2002:a05:6830:3094:: with SMTP id f20mr26004587ots.283.1595957651516; Tue, 28 Jul 2020 10:34:11 -0700 (PDT) MIME-Version: 1.0 References: <20200728063439.23114-1-ajit.khaparde@broadcom.com> <20200728063439.23114-17-ajit.khaparde@broadcom.com> In-Reply-To: From: Ajit Khaparde Date: Tue, 28 Jul 2020 10:33:55 -0700 Message-ID: To: Ferruh Yigit Cc: dpdk-dev , Mike Baucom , Kishore Padmanabha Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 16/22] net/bnxt: fix table reference count for shadow tcam X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 28, 2020 at 10:00 AM Ferruh Yigit wrote: > On 7/28/2020 7:34 AM, Ajit Khaparde wrote: > > From: Mike Baucom > > > > Moved setting the refcnt for shadow tcam and table entries to the > > allocation path only. The insert can be called multiple times for > > updates and was resetting the refcnt to 1 each time. Now multiple > > insertion/modifications will not change the reference count. > > > > Fixes: 3cf8fb975df9 ("net/bnxt: add shadow and search capability to > tcam") > > > > Signed-off-by: Mike Baucom > > Reviewed-by: Kishore Padmanabha > > The fix patch already in this set, why not fix the issue at first place > where it > is introduced? > > This patch distributed to 1/22 & 12/22 while merging, please confirm. > Ferruh, I took a quick look at the patches and I think we may be able to merge them. But I have not squashed and compiled the patches yet. So I can't tell if merging them will break the build. Thanks Ajit