From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6032A052B; Tue, 28 Jul 2020 20:06:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1226A10A3; Tue, 28 Jul 2020 20:06:21 +0200 (CEST) Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by dpdk.org (Postfix) with ESMTP id 1142FA69 for ; Tue, 28 Jul 2020 20:06:19 +0200 (CEST) Received: by mail-oi1-f194.google.com with SMTP id s144so8360606oie.3 for ; Tue, 28 Jul 2020 11:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MXL4Ntq1/HpyN7epHMa258RL0UWxaY6DAcT7gdV1bHo=; b=YY+vyGyFj2fElTPfi8Hk+gFi2LMlsMprBW3PSLtSGHIJ0+u2+n7muEFQQq13STwAP+ qBymhwice2G6EQGW7U7TzLuLHNfEqe0glNsSBf+lN7vHjWACfjetKTgq74M34jr80yMD bjq1jiA7ZpVoSa4IYhHYlLynd9Nt4TbVTh4kU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MXL4Ntq1/HpyN7epHMa258RL0UWxaY6DAcT7gdV1bHo=; b=iLOYXgyuBrNSfFUNoWOFqtw3+Lqd8FbdK0QuYI/EI1hjv1Te5WhCMVE9i7CpTyTSzs BUVH0e7bRw9aoDyGdqnavE8zSpMSoLpin5GWY+bNAkbMRzehJk8T5tTQojJeOvorg6sD G1ZjiWe3Qgwt4D9Oq4BWSwdIRLYLxC8nQy4+mwAtMNnmZJJlRD17NLy3Lfo06KG3PXhh 6vIeh1vnNifMEHuG/pjYY7jrVhPnpIbB8833xisF6dqfPA0qF8yOHeKoODsiuDrVnJL6 q7UOiL2VWyAkhjhzTHPHu9PHib9l6N+8yByZy1RFMmDyxjXuEFVseYvqMkrz/lHC5hCg XSZQ== X-Gm-Message-State: AOAM532rWMaXTv0s4SLjL3S9ZaICuAgqaIA9CbNhj1GoO/Arhuw5qBAb HuLEBML1xwiGHBuMQiunpxsssfFA58e4IZxUtN6daQ== X-Google-Smtp-Source: ABdhPJzgdUWkHOxE98BsxnWNU705s8BpsVtaDbF0pVKIHQVhAzg0sWXYPskPD8/TzNOpWK+kkowyuZXapJqRaYRYJgo= X-Received: by 2002:aca:f550:: with SMTP id t77mr4643754oih.168.1595959577951; Tue, 28 Jul 2020 11:06:17 -0700 (PDT) MIME-Version: 1.0 References: <20200728063439.23114-1-ajit.khaparde@broadcom.com> <20200728063439.23114-17-ajit.khaparde@broadcom.com> <640e6ebf-f800-0a3d-8388-e951ef093ab0@intel.com> In-Reply-To: <640e6ebf-f800-0a3d-8388-e951ef093ab0@intel.com> From: Ajit Khaparde Date: Tue, 28 Jul 2020 11:06:01 -0700 Message-ID: To: Ferruh Yigit Cc: dpdk-dev , Mike Baucom , Kishore Padmanabha Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 16/22] net/bnxt: fix table reference count for shadow tcam X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 28, 2020 at 10:39 AM Ferruh Yigit wrote: > On 7/28/2020 6:33 PM, Ajit Khaparde wrote: > > > > > > On Tue, Jul 28, 2020 at 10:00 AM Ferruh Yigit > > wrote: > > > > On 7/28/2020 7:34 AM, Ajit Khaparde wrote: > > > From: Mike Baucom > > > > > > > > Moved setting the refcnt for shadow tcam and table entries to the > > > allocation path only. The insert can be called multiple times for > > > updates and was resetting the refcnt to 1 each time. Now multiple > > > insertion/modifications will not change the reference count. > > > > > > Fixes: 3cf8fb975df9 ("net/bnxt: add shadow and search capability > to tcam") > > > > > > Signed-off-by: Mike Baucom > > > > > Reviewed-by: Kishore Padmanabha > > > > > > The fix patch already in this set, why not fix the issue at first > place where it > > is introduced? > > > > This patch distributed to 1/22 & 12/22 while merging, please confirm. > > > > Ferruh, > > I took a quick look at the patches and I think we may be able to merge > them. > > But I have not squashed and compiled the patches yet. So I can't tell if > merging > > them > > will break the build. > > I have verified the patch by patch build, which looks good and pushed to > next-net. > Also verified that final code is same, but better to have another eye to > double > check. > Thanks Ferruh. I am checking the code now.