From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f194.google.com (mail-ot0-f194.google.com [74.125.82.194]) by dpdk.org (Postfix) with ESMTP id 940D12F7D for ; Thu, 7 Jun 2018 23:35:00 +0200 (CEST) Received: by mail-ot0-f194.google.com with SMTP id q1-v6so13279854oth.13 for ; Thu, 07 Jun 2018 14:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DiZzTHUW55CRBMqyQduF+QopXErlcnkZ1ezMVCLs8kI=; b=IbZEsG4G/qB6IrMiEzy+QglpJhLe98tHmpVCxBeVV7jPiLUq295VNT9H0UmVrDfaen olcTrXqkhZlHdk4Erc/cIZrUkgJLyxg5UxWCA5LhronyI+TbRRmSCHw/ixQxfEwAJtdj n714ISdxGIq9NDgjqFVe6U1yAQOgLisrKUCGE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DiZzTHUW55CRBMqyQduF+QopXErlcnkZ1ezMVCLs8kI=; b=nhNC3njgN8dsKNmIzYVm+MdTq1aY0DyQc7JHloqPeFg0wwFMA3+8dxV9B9DEDe6XZR JOjPqJ9K1OzISn2hWbreqFxdBcnmYH/AiqyI+yG19lGCPX7ZIPLbKtQc+o5NUJayUiDp FpAVIQ8Qcg6K2Z7UbvQEw+/e5PE0k6A3Rx218YELcG6x4fbhegIfPmKvtnQGxAeVLIzb 6wyUEpnYiwFno0DXiRMin0Qv2ZDROwrqBXZ8BqWnLAj28i7GmTjbkPkHldOjXwx0ZQTl 4NmNZ1UpN8d3aM5HkAYcz8ZpszNXtuFpVA4t1NOrh7AG62BSTVJPm/r0ama7ikNFDxeO CTTA== X-Gm-Message-State: APt69E1dQZEqBgnqNrCHP6xBkF6KpAyPFhPhmqvu3MfU8mveDCBdZd9N kWRVvh9e4+APN+5G8yKQL4CSjbYVcr3ued67kUUSYg== X-Google-Smtp-Source: ADUXVKJMTCaR3T1xVkJKIoJoZMNZCLWl1UJJQlijWJrHgiQ3gd9zAoJXB4ChzMyxjc4OICYOGvXq4gKsDcxsZSNVodQ= X-Received: by 2002:a9d:7208:: with SMTP id u8-v6mr1995546otj.200.1528407299829; Thu, 07 Jun 2018 14:34:59 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:3d05:0:0:0:0:0 with HTTP; Thu, 7 Jun 2018 14:34:19 -0700 (PDT) In-Reply-To: <1528349765-31471-1-git-send-email-david.marchand@6wind.com> References: <1528349765-31471-1-git-send-email-david.marchand@6wind.com> From: Ajit Khaparde Date: Thu, 7 Jun 2018 14:34:19 -0700 Message-ID: To: David Marchand Cc: dev@dpdk.org, Somnath Kotur , dpdk stable Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: add missing ids in xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 21:35:00 -0000 On Wed, Jun 6, 2018 at 10:36 PM, David Marchand wrote: > The xstats api expects that the driver fills both values and ids for each > filled entries. > > Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset") > > Signed-off-by: David Marchand > =E2=80=8B=E2=80=8B Acked-by: =E2=80=8B Ajit Khaparde =E2=80=8B > --- > drivers/net/bnxt/bnxt_stats.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.= c > index bbd4e78..a5d3c86 100644 > --- a/drivers/net/bnxt/bnxt_stats.c > +++ b/drivers/net/bnxt/bnxt_stats.c > @@ -278,6 +278,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_de= v, > count =3D 0; > for (i =3D 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) { > uint64_t *rx_stats =3D (uint64_t *)bp->hw_rx_port_stats; > + xstats[count].id =3D count; > xstats[count].value =3D rte_le_to_cpu_64( > *(uint64_t *)((char *)rx_stats + > bnxt_rx_stats_strings[i].offset)); > @@ -286,6 +287,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_de= v, > > for (i =3D 0; i < RTE_DIM(bnxt_tx_stats_strings); i++) { > uint64_t *tx_stats =3D (uint64_t *)bp->hw_tx_port_stats; > + xstats[count].id =3D count; > xstats[count].value =3D rte_le_to_cpu_64( > *(uint64_t *)((char *)tx_stats + > bnxt_tx_stats_strings[i].offset)); > @@ -293,6 +295,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_de= v, > } > > /* The Tx drop pkts aka the Anti spoof coounter */ > + xstats[count].id =3D count; > xstats[count].value =3D rte_le_to_cpu_64(tx_drop_pkts); > count++; > > -- > 2.7.4 > >