From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2323A0562; Fri, 19 Mar 2021 04:51:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73EE14067C; Fri, 19 Mar 2021 04:51:17 +0100 (CET) Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by mails.dpdk.org (Postfix) with ESMTP id 97B1D40143 for ; Fri, 19 Mar 2021 04:51:16 +0100 (CET) Received: by mail-qv1-f51.google.com with SMTP id by2so4365996qvb.11 for ; Thu, 18 Mar 2021 20:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oy3HeiEKL0UoqdnsobTSOFtDn1DDluZXhgjmIM8QzqE=; b=Nr3HM7ZcUefmN6PQKIFFUIJpuOa+5mHKccdVqMgmhihFYIHv5SRt2GC8OcFrzY9C+9 pRQbMbYzkIX8vMm9Jdu0nl0sYBuD2V0XZf55pN9gXnExiLlZiyFQV8ANO2upK0oTGtZJ 8gd9rclKmIRZ56wTLG/g904w+sGpuNzrwq/XM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oy3HeiEKL0UoqdnsobTSOFtDn1DDluZXhgjmIM8QzqE=; b=qJjB3VKTOICYqe4c/7Y7esVXs9QNClmcGEc6RiI1EEEkh442FchMnOlqaXjeihBddf P5/H8lmZm3AUILFyXA/bDbK5jyOaC6/FRhhMuJc6CaTCVcRaoOmhHJNyyJDBAr+PtiWj QEllJti/oG/vLn7tAc+F/VxqUlF/GnIiAXisfjAVP5uD5R8opqWf1rz/6RN+SHghu+7k j7SRWYNqCwLoXE0j3Q+UyTvN4an+kQvPCEE8gPorVq53Nea0OfwbhoWj7L1tAfV9yarq U34NDdMqtnon/wOX6AYpvgDDmi0+Ak78XgrKxWppzGbDFtLzGG5PahC/6itNhzRxNmIj 7jIA== X-Gm-Message-State: AOAM530B6p41TqeKHsu9ujtlusZncQH6qB/2zuYCHJJgRfamxlhl6iAE 6NDNofWXDb9YokRCvLo5oeDrQdIo4Q7cY2Q8gdk21A== X-Google-Smtp-Source: ABdhPJzJBtZMBVNIphQOv9keA58NbWhBGTckuNNkVE3P9tiUzvn54mVGatCgSaaLhzN94mTcXsZxYWno0vZspgJ9+7Q= X-Received: by 2002:a05:6214:184e:: with SMTP id d14mr7606717qvy.30.1616125875883; Thu, 18 Mar 2021 20:51:15 -0700 (PDT) MIME-Version: 1.0 References: <20210318195213.683281-1-lance.richardson@broadcom.com> In-Reply-To: <20210318195213.683281-1-lance.richardson@broadcom.com> From: Ajit Khaparde Date: Thu, 18 Mar 2021 20:50:59 -0700 Message-ID: To: Lance Richardson Cc: Somnath Kotur , dpdk-dev , dpdk stable Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000c3f6f605bddba0bf" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 1/1] net/bnxt: fix Rx buffer posting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000c3f6f605bddba0bf Content-Type: text/plain; charset="UTF-8" On Thu, Mar 18, 2021 at 12:52 PM Lance Richardson wrote: > > Remove early buffer posting logic from burst receive loop to address > several issues: > - Posting receive descriptors without first posting completion > entries risks overflowing the completion queue. > - Posting receive descriptors without updating rx_raw_prod > creates the possibility that the receive descriptor doorbell > can be written twice with the same value. > - Having this logic in the inner descriptor processing loop > can impact performance. > > Fixes: 637e34befd9c ("net/bnxt: optimize Rx processing") > Fixes: 04067844a3e9 ("net/bnxt: reduce CQ queue size without aggregation ring") > Cc: stable@dpdk.org > > Signed-off-by: Lance Richardson > Reviewed-by: Ajit Kumar Khaparde Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_rxr.c | 3 --- > drivers/net/bnxt/bnxt_rxr.h | 2 -- > 2 files changed, 5 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index c72545ada7..7179c6cb30 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -1018,9 +1018,6 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > raw_cons = NEXT_RAW_CMP(raw_cons); > if (nb_rx_pkts == nb_pkts || nb_rep_rx_pkts == nb_pkts || evt) > break; > - /* Post some Rx buf early in case of larger burst processing */ > - if (nb_rx_pkts == BNXT_RX_POST_THRESH) > - bnxt_db_write(&rxr->rx_db, rxr->rx_raw_prod); > } > > cpr->cp_raw_cons = raw_cons; > diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h > index a6fdd7767a..b43256e03e 100644 > --- a/drivers/net/bnxt/bnxt_rxr.h > +++ b/drivers/net/bnxt/bnxt_rxr.h > @@ -41,8 +41,6 @@ static inline uint16_t bnxt_tpa_start_agg_id(struct bnxt *bp, > (((cmp)->agg_bufs_v1 & RX_PKT_CMPL_AGG_BUFS_MASK) >> \ > RX_PKT_CMPL_AGG_BUFS_SFT) > > -#define BNXT_RX_POST_THRESH 32 > - > /* Number of descriptors to process per inner loop in vector mode. */ > #define RTE_BNXT_DESCS_PER_LOOP 4U > > -- > 2.25.1 > --000000000000c3f6f605bddba0bf--