From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B986DA0528; Thu, 9 Jul 2020 16:34:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05CE81E8F4; Thu, 9 Jul 2020 16:34:07 +0200 (CEST) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id 1E2641E8BC for ; Thu, 9 Jul 2020 16:34:05 +0200 (CEST) Received: by mail-oi1-f196.google.com with SMTP id h17so2051165oie.3 for ; Thu, 09 Jul 2020 07:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MBqaVqjV8L0io0DZ2bI/s5tsqm0PDfVwfhDGe1Mp994=; b=SuG/qh3NHZHTTGizw5sLtC5PPTqrVpZU4Xr6WFyBUmSeGUxWb509OsCxUR3yKoLhcG EkEIt1/IaRBL77NdgS7WciVP+32hEjm1Un9d2yLkJbY9Zh5i9Kh2nahAWA9+700kfxZi Nes7ODTqAPXY3AxVRvPo68/+2fg7Nv6oIQ5e0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MBqaVqjV8L0io0DZ2bI/s5tsqm0PDfVwfhDGe1Mp994=; b=Xyq+3SLQzYSiFWedK0ekP/PW8h+RfX4T38BUg3XKrzEKyTwXtUcOFcBz3PxJG2JDh3 7LRQRDPDpbV+mvrK+eCQP2P0hKAhXHmAHmBLIX2dbez7HvHJWFgJNpoulxnUTJetCp4k eY65NOCaOwEf3vt/aonvJbLyGWprlOePZtsctjc+7m6Nc1rqRuTfSX/NRDTuN36HPySp kUnpFRSKUD0erwfqYMRO1tUM795lutYTYsbxRDf4UnrWQRWLWU9eAFIi4Sqr22NeJh3y 80ydv5puumR5YJXvhps6n8qHPO3HsVJ11eZ1u2vfbwPEyKEaKy7vvaPbM36WDNYdLMgf euUQ== X-Gm-Message-State: AOAM5332Wj3OHwqX6H0iTGdAGrL67yyI7XxtB4eh3wiw8dWqnAKsx5DS JRkM5bg5TLSr6ypAAUgxvNkI3wM2dQ/A4D+DaN7mTA== X-Google-Smtp-Source: ABdhPJyp3v5Po22V9L3/ZH1K+029661y4/jsv4UkIBhlifmbdm32UfyWuThhxgKhJQXFOmpg01DTz8jSxPouq5QTelY= X-Received: by 2002:aca:5347:: with SMTP id h68mr282475oib.168.1594305244188; Thu, 09 Jul 2020 07:34:04 -0700 (PDT) MIME-Version: 1.0 References: <20200709081504.12336-1-david.marchand@redhat.com> In-Reply-To: From: Ajit Khaparde Date: Thu, 9 Jul 2020 07:33:48 -0700 Message-ID: To: Ferruh Yigit Cc: David Marchand , dpdk-dev , Thomas Monjalon , Somnath Kotur , Randy Schacher , Venkat Duvvuru , Peter Spreadborough Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 9, 2020 at 5:11 AM Ferruh Yigit wrote: > On 7/9/2020 9:15 AM, David Marchand wrote: > > In existing build env, RTE_LIBRTE_BNXT_PMD_SYSTEM is unset. > > Testing against a n value does not work and we end up with a link issue: > > > > /usr/bin/ld: tf_core/tf_em_common.o: in function > `tf_em_ext_common_alloc': > > .../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1040: undefined > reference > > to `tf_em_ext_alloc' > > /usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_free': > > .../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1047: undefined > reference > > to `tf_em_ext_free' > > collect2: error: ld returned 1 exit status > > gmake[4]: *** [.../dpdk/mk/rte.lib.mk:95: librte_pmd_bnxt.so.20.0.3] > > Error 1 > > gmake[3]: *** [.../dpdk/mk/rte.subdir.mk:35: bnxt] Error 2 > > > > Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory") > > > > Signed-off-by: David Marchand > > --- > > drivers/net/bnxt/tf_core/Makefile | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/bnxt/tf_core/Makefile > b/drivers/net/bnxt/tf_core/Makefile > > index b4fbdd00fc..806471427c 100644 > > --- a/drivers/net/bnxt/tf_core/Makefile > > +++ b/drivers/net/bnxt/tf_core/Makefile > > @@ -16,10 +16,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += > tf_core/tf_msg.c > > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_tbl.c > > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_common.c > > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_internal.c > > -ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM), n) > > -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c > > +ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM),y) > > +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_system.c > > else > > -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM) += tf_core/tf_em_system.c > > +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c > > endif > > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_session.c > > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_device.c > > > > Functionally this is same so no objection to the change, > but I wonder why 'RTE_LIBRTE_BNXT_PMD_SYSTEM' is unset. > > "CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM=n" is added to 'config/common_base' in > the > same patch that updates the Makefile, so it should be set. > > > Btw, @Ajit, @Peter, how this new flagged managed via meson? > I will sync with Peter and others in the team and we will get back on this.