From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F0E7A0A03; Mon, 18 Jan 2021 21:05:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DBD98140E06; Mon, 18 Jan 2021 21:05:42 +0100 (CET) Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by mails.dpdk.org (Postfix) with ESMTP id 1554D140DF4 for ; Mon, 18 Jan 2021 21:05:41 +0100 (CET) Received: by mail-qv1-f51.google.com with SMTP id p5so8077255qvs.7 for ; Mon, 18 Jan 2021 12:05:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r2o+78krnxNFtjBY30uURPnJC0NfPwqFEyWrCmobu8I=; b=Jc5YPiYo0sE2TeNH4hzJ8dOqteF1sJ8BDqF5SsXon1adcqqmHkT4HFh46tB+pMYUPZ 4VyRePttwxEe9AGlRJJj7zflsCFUBpqt+7n4y8pFdpFBfP9Deu60ioHrgtITA7AzOs/h u4bu/UHMlCREZzet7byU1pPxYyBAcMOhh++CI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r2o+78krnxNFtjBY30uURPnJC0NfPwqFEyWrCmobu8I=; b=KeMNmaJfRhknA55uoeN7qLvi+E4ncAoZX9e2kschhaSLCUJ13LmMI/k8iCucJUYzb2 KqrAabB/Xz5T9DnLHLYbgx8mJtP94Asij/XJpW40lr0bF+kbx6gYLq4DsfWj73S37TAD c7xOA6MQHptHSeofiF9FQc/6pEOwKE5J9ARHLdrz9MrPGsiS3kzVCkEHqI+0ox1dTs3L E/i6ioE+RynRHEP27GAh5/pZ2ukTZk1gwfulIM1NkqMLsDQWmeShFbcOGtFTtgMM824v aN0R3HUuLalPRs8vjs72URQJHrpjegEzdYe6K1nFB0FzLHT5uayf6YYHT8TFXKTvoVFG 5f1w== X-Gm-Message-State: AOAM5332sWH8BS7b5zsnLM7qmLJPoD/tUa1/AxOloymZCoRpQKrwQjKM o7dlh76VwETiGY+HbmQSye8BddCWKAo8zjK18brxLg== X-Google-Smtp-Source: ABdhPJz8M3BgTcafLIfLA9bgt9EWukTOPssYDD00yDudfUTMNY2DvZvvkpIUQMECVYTSwScPHzQv6vTZ2d9puAuVE6s= X-Received: by 2002:ad4:4c50:: with SMTP id cs16mr1349318qvb.33.1611000340190; Mon, 18 Jan 2021 12:05:40 -0800 (PST) MIME-Version: 1.0 References: <20210116045054.14539-1-akozyrev@nvidia.com> <20210118161825.31516-1-akozyrev@nvidia.com> In-Reply-To: <20210118161825.31516-1-akozyrev@nvidia.com> From: Ajit Khaparde Date: Mon, 18 Jan 2021 12:05:23 -0800 Message-ID: To: Alexander Kozyrev Cc: dpdk-dev , Slava Ovsiienko , Ori Kam , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Jerin Jacob Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000000941c705b9323fc4" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v8 0/2] generic modify rte flow action support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000000941c705b9323fc4 Content-Type: text/plain; charset="UTF-8" On Mon, Jan 18, 2021 at 8:18 AM Alexander Kozyrev wrote: > > Implement a generic modify rte flow API as described in RFC: > http://patches.dpdk.org/patch/85384/ > > This API allows modifying a destination header field with data from > a source header field. Number of bits to use from the source is specified. > Tag, Mark or Metadata can also be used as a source/destination to allow > saving/overwriting an arbitrary header field with a user-specified value. > Alternatively, an immediate value can be provided by a user as a source. > > Outermost/innermost packet fields (and Tag array elements) are > accessible via the level parameter to facilitate the modification > of encapsulated packet header fields. The offset parameter provides > the flexibility to copy/set any part of a packet starting the > specified packet header field. > > Example of RTE_FLOW_ACTION_TYPE_MODIFY_FIELD implementation for MLX5: > https://patchwork.dpdk.org/patch/86736/ > > --- > v1: https://patchwork.dpdk.org/patch/86173/ > Initial design. > v2: https://patchwork.dpdk.org/cover/86369/ > Added testpmd support. > v3: https://patchwork.dpdk.org/cover/86442/ > Made dst_type, src_type and width only mandatory parameters. > v4: https://patchwork.dpdk.org/cover/86488/ > Renamed action to RTE_FLOW_ACTION_TYPE_COPY_FIELD. > v5: https://patchwork.dpdk.org/cover/86705/ > Redesigned as RTE_FLOW_ACTION_TYPE_MODIFY_FIELD. > v6: https://patchwork.dpdk.org/cover/86715/ > Fixed typos in documentation. > v7: https://patchwork.dpdk.org/cover/86718/ > Fixed warnings. > v8: > Added doxygen comments. > > Alexander Kozyrev (2): > ethdev: introduce generic modify rte flow action > app/testpmd: add support for modify field flow action I see Thomas has some comments on one of the patches. Please address that. Otherwise ack for the series. Acked-by: Ajit Khaparde > > app/test-pmd/cmdline_flow.c | 246 +++++++++++++++++++++++++ > doc/guides/prog_guide/rte_flow.rst | 66 +++++++ > doc/guides/rel_notes/release_21_02.rst | 8 + > lib/librte_ethdev/rte_flow.c | 2 + > lib/librte_ethdev/rte_flow.h | 87 ++++++++- > 5 files changed, 408 insertions(+), 1 deletion(-) > > -- > 2.24.1 > --0000000000000941c705b9323fc4--