From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99CE7A034E; Wed, 9 Feb 2022 16:38:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 881C1426D7; Wed, 9 Feb 2022 16:38:03 +0100 (CET) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by mails.dpdk.org (Postfix) with ESMTP id 6B92441144 for ; Wed, 9 Feb 2022 16:38:01 +0100 (CET) Received: by mail-io1-f43.google.com with SMTP id q204so3607802iod.8 for ; Wed, 09 Feb 2022 07:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AMHPWHWle2CDoR1Ri/cLrhJj8tODaEg91dB7mJOj88g=; b=c8L+f1o95haPTrVRqZ/1MWYa+tWoc/cf9DnuJsnhq//jXwrJE7p7HqVHwfLfxDgb0c xC9vR7lVdOYLSNTwJP+bFTe2CxboaLUjQisjcCso5BvFEP33OnKtvjQuwZ8sRHtZUZkL boKHQCbjbIatoBpV1Sh7RE/S9b+So0Z4BsytI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AMHPWHWle2CDoR1Ri/cLrhJj8tODaEg91dB7mJOj88g=; b=Al2Rrfn7NxYoVw79WaFJxLAfDoI5p9XhEOOaMrPRYa0N7IOqcToy9O0SLZppex0Tiy Ka9suzAAzuOYdYzRECWf/XyxmTH0lVZiSeS5knM3GSYpKGsuDIzcwxCGpLgSTPX+Nnp2 xXHz47RVaiw/sUx3w26ZvYr33E8mn/B9ZbgQprGZr6/mtisZMHzvSSeq6wVwZHqDC82o 2zAKZB9bGLizZ3xrC3oH+nanvjJ1FRONPXglzWEKAWf1hbZW8xOyq62mnRK5lpGrZvUv uaSwdYQpy4Vy9BzrBcnmA0lFCIl56BV2OSM0evmBRm6R7TgZM70WLXJLb7ua0afM71ep VIOA== X-Gm-Message-State: AOAM532ybsyzaflkn5xMIks7aFL45e5ItF/+VuVwXOrrbHhk9AO627IS FSMSW+7Bue/Sjf8MfUdq1Pzac8+gyIf2JzmdTIxK1tdJ3zaFHg== X-Google-Smtp-Source: ABdhPJxfuEC5nSsu1QTN1cepjhnHTdSPUVbN0XiaR7DyUQCkNrFxwBAl0hThS05z/TKbzv+YPmTHcy6KFAkfX4TajwM= X-Received: by 2002:a05:6638:14d2:: with SMTP id l18mr1281051jak.69.1644421080646; Wed, 09 Feb 2022 07:38:00 -0800 (PST) MIME-Version: 1.0 References: <20220209055811.88850-1-ajit.khaparde@broadcom.com> In-Reply-To: <20220209055811.88850-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Wed, 9 Feb 2022 07:37:44 -0800 Message-ID: Subject: Re: [PATCH] net/bnxt: fix ring calculation for representors To: dpdk-dev Cc: dpdk stable , Somnath Kotur , Kalesh AP , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000638f9205d7979e0e" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000638f9205d7979e0e Content-Type: text/plain; charset="UTF-8" On Tue, Feb 8, 2022 at 9:58 PM Ajit Khaparde wrote: > > Currently the Tx and Rx ring count for representors is fixed. > It does not consider the number of rings created for the parent > function. And that can cause issues not only during initialization > but while running traffic. > Instead check the number of rings created for the parent function > while configuring the ring resources for representors. > > Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure") > Cc: stable@dpdk.org > > Signed-off-by: Ajit Khaparde > Reviewed-by: Somnath Kotur > Reviewed-by: Kalesh AP Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt.h | 2 +- > drivers/net/bnxt/bnxt_reps.c | 19 ++++++++++--------- > 2 files changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h > index 433f1c80be..0cbb58b2cf 100644 > --- a/drivers/net/bnxt/bnxt.h > +++ b/drivers/net/bnxt/bnxt.h > @@ -831,7 +831,7 @@ struct bnxt { > uint16_t max_tx_rings; > uint16_t max_rx_rings; > #define MAX_STINGRAY_RINGS 236U > -#define BNXT_MAX_VF_REP_RINGS 8 > +#define BNXT_MAX_VF_REP_RINGS 8U > > uint16_t max_nq_rings; > uint16_t max_l2_ctx; > diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c > index 5e140f0cdb..9ae8848382 100644 > --- a/drivers/net/bnxt/bnxt_reps.c > +++ b/drivers/net/bnxt/bnxt_reps.c > @@ -548,7 +548,8 @@ int bnxt_rep_dev_info_get_op(struct rte_eth_dev *eth_dev, > dev_info->max_mac_addrs = parent_bp->max_l2_ctx; > dev_info->max_hash_mac_addrs = 0; > > - max_rx_rings = BNXT_MAX_VF_REP_RINGS; > + max_rx_rings = RTE_MIN(parent_bp->rx_nr_rings, BNXT_MAX_VF_REP_RINGS); > + > /* For the sake of symmetry, max_rx_queues = max_tx_queues */ > dev_info->max_rx_queues = max_rx_rings; > dev_info->max_tx_queues = max_rx_rings; > @@ -629,10 +630,10 @@ int bnxt_rep_rx_queue_setup_op(struct rte_eth_dev *eth_dev, > struct rte_mbuf **buf_ring; > int rc = 0; > > - if (queue_idx >= BNXT_MAX_VF_REP_RINGS) { > + if (queue_idx >= rep_bp->rx_nr_rings) { > PMD_DRV_LOG(ERR, > "Cannot create Rx ring %d. %d rings available\n", > - queue_idx, BNXT_MAX_VF_REP_RINGS); > + queue_idx, rep_bp->rx_nr_rings); > return -EINVAL; > } > > @@ -729,10 +730,10 @@ int bnxt_rep_tx_queue_setup_op(struct rte_eth_dev *eth_dev, > struct bnxt_tx_queue *parent_txq, *txq; > struct bnxt_vf_rep_tx_queue *vfr_txq; > > - if (queue_idx >= BNXT_MAX_VF_REP_RINGS) { > + if (queue_idx >= rep_bp->rx_nr_rings) { > PMD_DRV_LOG(ERR, > "Cannot create Tx rings %d. %d rings available\n", > - queue_idx, BNXT_MAX_VF_REP_RINGS); > + queue_idx, rep_bp->rx_nr_rings); > return -EINVAL; > } > > @@ -805,10 +806,10 @@ int bnxt_rep_stats_get_op(struct rte_eth_dev *eth_dev, > struct rte_eth_stats *stats) > { > struct bnxt_representor *rep_bp = eth_dev->data->dev_private; > - int i; > + unsigned int i; > > memset(stats, 0, sizeof(*stats)); > - for (i = 0; i < BNXT_MAX_VF_REP_RINGS; i++) { > + for (i = 0; i < rep_bp->rx_nr_rings; i++) { > stats->obytes += rep_bp->tx_bytes[i]; > stats->opackets += rep_bp->tx_pkts[i]; > stats->ibytes += rep_bp->rx_bytes[i]; > @@ -828,9 +829,9 @@ int bnxt_rep_stats_get_op(struct rte_eth_dev *eth_dev, > int bnxt_rep_stats_reset_op(struct rte_eth_dev *eth_dev) > { > struct bnxt_representor *rep_bp = eth_dev->data->dev_private; > - int i; > + unsigned int i; > > - for (i = 0; i < BNXT_MAX_VF_REP_RINGS; i++) { > + for (i = 0; i < rep_bp->rx_nr_rings; i++) { > rep_bp->tx_pkts[i] = 0; > rep_bp->tx_bytes[i] = 0; > rep_bp->rx_pkts[i] = 0; > -- > 2.32.0 (Apple Git-132) > --000000000000638f9205d7979e0e Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDBCmE9BT7srhoNHDEDANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDE4MjdaFw0yMjA5MjIxNDUxNDlaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEAwXsxfYF9jpj9zve1vXxD491SrWDVlcmLMdnOS1c7POMC8lbbgvp1o2kIu/3n xCVFTai5H6rHZgrFItNNVZ+XaJW9Ob9eiSuXdnAu5gVdTb+IFAf4S/PT2LXzpP07M7vyvm/yvA+8 HtVfapzqqTNYdNVUpq28MYsKEWbnyK94x5+C3oCAV4bpNnMoPNtKrMhvOdpTREQRyew8hyy3/Mz7 RIaCW0xx+14NTQe17dkH6CEEpmCjejneq/FU0gmbuorwHoP9mOiqeh23/ZKVpmFO/eiDtvMNAMDW 6LzhOk/pMklUPTHu/gQNW3OQebyhyFUHiBSp8rDkfWZT57Asd0PtdQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUPHif0ihgndR0 h7r3sANaOIu2yM8wDQYJKoZIhvcNAQELBQADggEBAAEuLXDnP0Xd2zAMpQobXLUyqbpqGMO6ycQc Xq4H2YYlSNKVwPA+ZAVdUOzbSimBKlx8mzAEHkI3Ll1yXlYeT4UwkfWV9fioyGuQelLN1sGzi5bm WEpaSIbR1eiJMtzxUPwpRTn19gHZVueIot2Gw0fEYgHiMJpUr6xBWv2QNXULu/E8qvbXIRh2iycq 5rWFggX/JHglO8nVqzb1ImzqzVMFnDN15h3j8ryy2MIvZ8VDQRP7l81IXaTvVwaKpWMgV6rfQOi6 aOQZuOKkad7qoCkS5N2oSsvxi+rZtDaJJNsDjs05y5JZZQtBlfAmdYS+mmvkPjZ1iaLTzk59o/Yo fNkxggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwQphPQ U+7K4aDRwxAwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIInulhWtxud1xGqS1y+j XIpXRd3NKETfJ1sEQgYHuL+ZMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIyMDIwOTE1MzgwMFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQAdChg5wVF+4A5SMg4nAx3F7IdzkW2OxOgk9fx1 ABqlMcY/vHtSACEwZnxubSjYJbjbxfbKaX+5ZaxVv5jxao+5aEWZ2FOStzlnEC1RpkF+O3pTJe26 2ITF0+UOTcPYTr6+XA6fddwJ6Y/O1EZvR4w9AYHnXvXQmr7MSOL37oMPdfqj+T8+AFJ7BTYZA/W2 B8ljLgKXVWa2DIeKmwSun/ZpNcBiJSQbEppAaPlmX4S3lMKhKSaNKsjD5tSYwovylvSaS4rxb50c z8SmLnrYHx37miyAvMmiOAcV/ALCOUs8ozaWSwry/VklyJYCuAbIdnUA0N0rzERv7VY0zH5E4lKN --000000000000638f9205d7979e0e--