From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC57FA0547; Wed, 29 Sep 2021 18:45:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 901D0410EA; Wed, 29 Sep 2021 18:45:17 +0200 (CEST) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by mails.dpdk.org (Postfix) with ESMTP id 72DDC410E5 for ; Wed, 29 Sep 2021 18:45:16 +0200 (CEST) Received: by mail-io1-f53.google.com with SMTP id i62so3961617ioa.6 for ; Wed, 29 Sep 2021 09:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FYQW1JtYQXOV90X9f75GFrywpXV/xZDS107cqOpP9ag=; b=ccNsm5U55uJIdxFVPTjZ0mkCwa4KgJSlD/lNLXjSbjLz62dF9MEAgUt1UytqAnW4oi zkPPeEe6RhfdOCiNt5S4sW9WaGzir8RSfGnO4AlwJt8/VZcTWHKV3LDtgCoUzFiZqLyV blonTxqEvsT0gENaPV7YIDOOBRYLozATZ6cNo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FYQW1JtYQXOV90X9f75GFrywpXV/xZDS107cqOpP9ag=; b=zOl+064onqdS7qoFOp5kR7YysWUbSR/mpNBqM0/mkOutKYbG+K2qLzfcYT8InBWE3u 7B0PWdSNGGvTuu6q4UsDZ9swU/NKaZQVQMT9vAuMCY5rfUYqORKaHU939ZFde6NmoRUv 49ml1tuO/EWj6lOfmXCDC/+YnmZ1J9NgwvBoHRS+Mcx8RtJ8nke8Yar3kUJ504Va19Z+ EIWTjPaHTY17pHXjFfzDcnTxyETyjwO3QFCieZSeXgIqAeyWWV2c8DRbAG4VNLP52LeK J+llI8Z1A4kuPawWiMR+jBMXRqhl0rvzocl0D6rBfKnjmeCDK+u3t8ltQomx4z/9axwH h3Ew== X-Gm-Message-State: AOAM533UNtHCjJIiRrvEQbmnmGwYsoVVt8Pb7+mJrRUfgjXfE2Hi34cO NNd8elZx7ugLpCLl5VBfwEXdam3ZmBK3m6Q+ca39ZQ== X-Google-Smtp-Source: ABdhPJzYSxUwIIeXb0zWnr8ZFb+pPqwlY4RvU653aQ34xb9bkYpnut++0f9oj/z8nQpVxDBbKZgqGrqJOb9CJCP02XQ= X-Received: by 2002:a6b:c3cb:: with SMTP id t194mr596098iof.50.1632933915757; Wed, 29 Sep 2021 09:45:15 -0700 (PDT) MIME-Version: 1.0 References: <20210908050643.9989-1-venkatkumar.duvvuru@broadcom.com> <043f9e39-222d-975d-d361-f9b27e7a3c74@intel.com> <1971997.DethVJQmbG@thomas> <8bea0af2-5713-032c-96db-bbcb0b690cda@intel.com> In-Reply-To: <8bea0af2-5713-032c-96db-bbcb0b690cda@intel.com> From: Ajit Khaparde Date: Wed, 29 Sep 2021 09:44:59 -0700 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , Venkat Duvvuru , dpdk-dev , Kishore Padmanabha , "jerinj@marvell.com" Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000001b0ab05cd250ed1" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v4 06/13] net/bnxt: add support for tunnel offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000001b0ab05cd250ed1 Content-Type: text/plain; charset="UTF-8" On Wed, Sep 29, 2021 at 2:44 AM Ferruh Yigit wrote: > > On 9/29/2021 9:20 AM, Thomas Monjalon wrote: > > 28/09/2021 23:32, Ajit Khaparde: > >> On Tue, Sep 28, 2021 at 5:43 AM Ferruh Yigit wrote: > >>> Following warning is reported by Jerin & Thomas: > >>> > >>> $ ./devtools/check-doc-vs-code.sh > >>> rte_flow doc out of sync for bnxt > >>> action shared > >>> > >>> > >>> This is mainly saying 'RTE_FLOW_ACTION_TYPE_SHARED' flow action is supported but > >>> not documented. But from code I am not sure if shared action is used, there is > >>> only one range check using this enum in the code, can you please clarify? > >> > >> Correct. RTE_FLOW_ACTION_TYPE_SHARED is being used only for a range check. > >> It is not really a supported action right now as far as the code is concerned. > >> As of now, no document update is necessary. Thanks > > > > You need to update something to make the check OK. > > If it is a false positive, it can be handled in the script, > > but we cannot let the script returning an error. > > > > > > I will add following exception to the script (suggested by Thomas) in the next-net: > > diff --git a/devtools/parse-flow-support.sh b/devtools/parse-flow-support.sh > index 8462abe53603..63c0b20e234f 100755 > --- a/devtools/parse-flow-support.sh > +++ b/devtools/parse-flow-support.sh > @@ -25,7 +25,8 @@ exclude() # > $dir/tf_ulp/ulp_rte_handler_tbl.c | > grep -wo "$1[[:alnum:]_]*" | sort -u | > tr '\n' '|' | sed 's,.$,\n,') > - grep -vE "$filter";; > + exceptions='RTE_FLOW_ACTION_TYPE_SHARED' > + grep -vE "$filter" | grep -vE $exceptions;; > *) cat > esac > } ACK > > --00000000000001b0ab05cd250ed1--