From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ajit.khaparde@broadcom.com>
Received: from mail-ot0-f175.google.com (mail-ot0-f175.google.com
 [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id 5442B1B5C8
 for <dev@dpdk.org>; Thu, 28 Jun 2018 22:17:04 +0200 (CEST)
Received: by mail-ot0-f175.google.com with SMTP id h6-v6so7560869otj.0
 for <dev@dpdk.org>; Thu, 28 Jun 2018 13:17:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=6DYCm4khm551YJ/eUYyVcxelIeVc8O1nN6wJCea64pY=;
 b=hUQ/vsGqrbweGFd0YLpPpJIcU4T8lTrPL1vyZq6FSO8zP0+XpkigKA7+1G6FdN2F4s
 DXQJNsd83HMIDpGlIHdmmMRkELgyVjDrpKL4nag/J9n4BhDrwvtGRpEQ1YRqKAHUpkf4
 SBwUiNSxe4XZwzs/stuG0u5r3Vg9jmb8sAxWs=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=6DYCm4khm551YJ/eUYyVcxelIeVc8O1nN6wJCea64pY=;
 b=qgs1hPRKJIG80Tfw0i73tO198EDg0kGdphHRco/ZZZbVrSMP1rlDYThv9QZJ11AvR8
 Zrs2av91TQ6WRDLVn+IAjs12ryNKcTrDIKIgBGDFzFpc1oSXnDpYDhdBMaapZkgQqjQy
 P8Z3Jk+h85/SHUI78tTtIT28GIT2+jVYr3AO58yF+pQyYnzXh+BPmNkxGrrfydTiHiqL
 znq5wsP4BLC9QPV4ia3i2kUlGLWHqcek7VfShIou+aq5WeijndWOwt0aheOlHEE9Grea
 xWw2JGAmb2CZqalWQ1AUczcxoyr7bo1h0XGxYG3YzlVmkG16gWiTOmhWix4FrwEA4Zkw
 58Fg==
X-Gm-Message-State: APt69E07MKnOoiKhe2xGF8F/1AeErSahXeFAxIGgamS8agzmi9v8lqVG
 vCumW3Lnu6KIcHtEHzcQDfYdiK7QIpoSVP6oWyKKG9l2
X-Google-Smtp-Source: AAOMgpem9DoV0jJDbQ7ENYRavRHAuLkGGZ4XnzBdk3w9phpIWwmpLTa+aQZYonGKvkag6hbAILcLMkLy35N/VSW9j8A=
X-Received: by 2002:a9d:7242:: with SMTP id
 a2-v6mr5715474otk.200.1530217023751; 
 Thu, 28 Jun 2018 13:17:03 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:ac9:3d05:0:0:0:0:0 with HTTP; Thu, 28 Jun 2018 13:16:23
 -0700 (PDT)
In-Reply-To: <4a09d560-3fc9-0202-f5c9-145fc232e3bf@intel.com>
References: <20180619213058.12273-1-ajit.khaparde@broadcom.com>
 <20180619213058.12273-6-ajit.khaparde@broadcom.com>
 <4a09d560-3fc9-0202-f5c9-145fc232e3bf@intel.com>
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: Thu, 28 Jun 2018 13:16:23 -0700
Message-ID: <CACZ4nhszyS3ufsxLTUYizL=-h43Og2g1nNPq4DdyzHc55jp1DQ@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH 05/31] net/bnxt: fix dev close operation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jun 2018 20:17:04 -0000

>
> > +     PMD_DRV_LOG(INFO, "Calling Device uninit\n");
>
> This looks like can be a debug message, what do you think?
>
=E2=80=8BYes. Changed it to debug.
=E2=80=8B


>
> <...>
>
> > @@ -3456,7 +3469,7 @@ static int bnxt_pci_remove(struct rte_pci_device
> *pci_dev)
> >  static struct rte_pci_driver bnxt_rte_pmd =3D {
> >       .id_table =3D bnxt_pci_id_map,
> >       .drv_flags =3D RTE_PCI_DRV_NEED_MAPPING |
> > -             RTE_PCI_DRV_INTR_LSC,
> > +             RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV,
>
> Is Remove interrupts really supported? I can't find the related code in
> the driver.
>
=E2=80=8BThat was some left over code. I cleaned it up.

Thanks
=E2=80=8B


>
> You need to call _rte_eth_dev_callback_process() for
> RTE_ETH_EVENT_INTR_RMV
> where you handle the interrupt.
>
> And announce the feature "Removal event" in bnxt.ini