From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Aaron Conole <aconole@redhat.com>
Cc: dev@dpdk.org, Patrick Robb <probb@iol.unh.edu>,
stuart.schacher@broadcom.com, farah.smith@broadcom.com,
sbhosle@broadcom.com
Subject: Re: [PATCH] test: eal: update base-virtaddr parameter test
Date: Thu, 20 Jul 2023 07:07:27 -0700 [thread overview]
Message-ID: <CACZ4nht0za=XrsmfNBaDH5=Nxdoza85MywN-g5k4ZPtFgXoExw@mail.gmail.com> (raw)
In-Reply-To: <20230720130900.357876-1-aconole@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]
On Thu, Jul 20, 2023 at 6:09 AM Aaron Conole <aconole@redhat.com> wrote:
>
> When 97435d7906 ("net/bnxt: update Truflow core") was applied, it introduced
> a number of static variables. These ended up filling the lower address space
> enough that on some platforms, the min addr for heap address to start was
> not within the range specified by base-virtaddr. This is dependent on both
> build and link time options.
>
> The simplest resolution is to just update the base virtaddr parameter to
> move the rte config location.
>
> Reported-by: Patrick Robb <probb@iol.unh.edu>
> Suggested-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
ACK.
I tested again and the test passed with this change. Thanks.
> ---
> app/test/test_eal_flags.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
> index d2b91e2075..148e9098e8 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -1017,7 +1017,7 @@ test_misc_flags(void)
>
> /* try running with base-virtaddr param */
> const char *argv13[] = {prgname, "--file-prefix=virtaddr",
> - "--base-virtaddr=0x12345678"};
> + "--base-virtaddr=0x23456789"};
>
> /* try running with --vfio-intr INTx flag */
> const char *argv14[] = {prgname, "--file-prefix=intr",
> --
> 2.40.1
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
next prev parent reply other threads:[~2023-07-20 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 13:09 Aaron Conole
2023-07-20 14:07 ` Ajit Khaparde [this message]
2023-07-22 13:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nht0za=XrsmfNBaDH5=Nxdoza85MywN-g5k4ZPtFgXoExw@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=farah.smith@broadcom.com \
--cc=probb@iol.unh.edu \
--cc=sbhosle@broadcom.com \
--cc=stuart.schacher@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).