From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8F56A04C7; Tue, 15 Sep 2020 17:39:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F41C1C0CE; Tue, 15 Sep 2020 17:39:04 +0200 (CEST) Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by dpdk.org (Postfix) with ESMTP id 0ACF21BE8E for ; Tue, 15 Sep 2020 17:39:03 +0200 (CEST) Received: by mail-oi1-f193.google.com with SMTP id 185so4305106oie.11 for ; Tue, 15 Sep 2020 08:39:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zCeQugD5qevcOMR3+dlrySonN2RnGeIyc0O0nPdSWGc=; b=P0u8K5YVAX0gpNb9NW++qPeV1XYtTrqD9psigmCHU7k1jnJW/8cImC4JcuYpq1ojXs /IhQfYJSBaG06JN6qRjOw0zuTJEB4UKz5lBtBCkmtpvTjpZh/6PrHb891I/ijh7lRLkI RpgnyDOqzlwqwzJFu78dx7aGsQx8sC2RPko+4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zCeQugD5qevcOMR3+dlrySonN2RnGeIyc0O0nPdSWGc=; b=tDlJ89SKF+V3ONFNpdk6iNxpyk3U00YDWLpTNgCHEKqSRail5ZUcEX+UQoqq4nQsoL d/K7L/JcxQEWr+s7+2xCcSe+HobqL9+rqXsY/cEdXLXvhPcXqr0USugpuPOJ4hiYKkPf Q/JlyiSm+akfpMifLdF7fqBNk1230SDb64DG7JGuLUM1HjQob8mPbnCUXGiYN6SjJmh0 ZonzpxwAogn7OFEQo19rT1Q/QbpMGi53eljgYbYkMyc/RzbQ6FneWL2A/6lv+IFiQ5T6 jRnRMTEw9mCbSreX7mip+cpd7a4jQnHTUc6THJM2gLWakEHrMe88JMiqDYpgkxfoLfem knxg== X-Gm-Message-State: AOAM533Tp9uFlm06NFmSBiwkdW73gq+YLAkqakimZBAKFq2LHjcVZeyS T51zylfspy90Xxw5w28LXg9oRII4677GFVx1U2/5H7LVxtg= X-Google-Smtp-Source: ABdhPJyMfKFf1bDGxA033wJw8LVb0zRlHq8JS/NehUSLUcaClPqEgXShj0mhDzB+Dp+lCp7otZ6AwcpGsAgJwa76uhc= X-Received: by 2002:a05:6808:5ca:: with SMTP id d10mr3864364oij.27.1600184340901; Tue, 15 Sep 2020 08:39:00 -0700 (PDT) MIME-Version: 1.0 References: <20200915140735.209826-1-lance.richardson@broadcom.com> In-Reply-To: <20200915140735.209826-1-lance.richardson@broadcom.com> From: Ajit Khaparde Date: Tue, 15 Sep 2020 08:38:43 -0700 Message-ID: To: Lance Richardson Cc: Somnath Kotur , dpdk-dev , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix powerpc build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 15, 2020 at 7:07 AM Lance Richardson < lance.richardson@broadcom.com> wrote: > A previous commit broke compilation for builds other than x86 and > aarch64. Fix by moving macro definitions to more appropriate header > files. > > Fixes: 479387565605 ("net/bnxt: improve small ring sizes support") > Signed-off-by: Lance Richardson > Ferruh, Let me know if you can pick this directly or would like to pull through the subtree. Reviewed-by: Ajit Khaparde Also adding Reported-by: Raslan Darawsheh --- > drivers/net/bnxt/bnxt_rxq.c | 1 - > drivers/net/bnxt/bnxt_rxq.h | 3 +++ > drivers/net/bnxt/bnxt_rxr.c | 1 - > drivers/net/bnxt/bnxt_rxr.h | 3 +++ > drivers/net/bnxt/bnxt_rxtx_vec_common.h | 4 ---- > drivers/net/bnxt/bnxt_txq.c | 1 - > drivers/net/bnxt/bnxt_txq.h | 3 +++ > 7 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c > index 57ba9a157..793a47d11 100644 > --- a/drivers/net/bnxt/bnxt_rxq.c > +++ b/drivers/net/bnxt/bnxt_rxq.c > @@ -14,7 +14,6 @@ > #include "bnxt_rxq.h" > #include "bnxt_rxr.h" > #include "bnxt_vnic.h" > -#include "bnxt_rxtx_vec_common.h" > #include "hsi_struct_def_dpdk.h" > > /* > diff --git a/drivers/net/bnxt/bnxt_rxq.h b/drivers/net/bnxt/bnxt_rxq.h > index 96c6e06a5..fae92ea45 100644 > --- a/drivers/net/bnxt/bnxt_rxq.h > +++ b/drivers/net/bnxt/bnxt_rxq.h > @@ -6,6 +6,9 @@ > #ifndef _BNXT_RQX_H_ > #define _BNXT_RQX_H_ > > +/* Maximum receive burst supported in vector mode. */ > +#define RTE_BNXT_MAX_RX_BURST 64U > + > struct bnxt; > struct bnxt_rx_ring_info; > struct bnxt_cp_ring_info; > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index 89a964a49..ca3e0a521 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -20,7 +20,6 @@ > #ifdef RTE_LIBRTE_IEEE1588 > #include "bnxt_hwrm.h" > #endif > -#include "bnxt_rxtx_vec_common.h" > > #include > #include > diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h > index 4f5e23b85..250033690 100644 > --- a/drivers/net/bnxt/bnxt_rxr.h > +++ b/drivers/net/bnxt/bnxt_rxr.h > @@ -167,6 +167,9 @@ static inline uint16_t bnxt_tpa_start_agg_id(struct > bnxt *bp, > > #define BNXT_RX_POST_THRESH 32 > > +/* Number of descriptors to process per inner loop in vector mode. */ > +#define RTE_BNXT_DESCS_PER_LOOP 4U > + > enum pkt_hash_types { > PKT_HASH_TYPE_NONE, /* Undefined type */ > PKT_HASH_TYPE_L2, /* Input: src_MAC, dest_MAC */ > diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_common.h > b/drivers/net/bnxt/bnxt_rxtx_vec_common.h > index 8c10fdfa1..4a48152fc 100644 > --- a/drivers/net/bnxt/bnxt_rxtx_vec_common.h > +++ b/drivers/net/bnxt/bnxt_rxtx_vec_common.h > @@ -9,10 +9,6 @@ > #include "bnxt_rxq.h" > #include "bnxt_rxr.h" > > -#define RTE_BNXT_MAX_RX_BURST 64U > -#define RTE_BNXT_MAX_TX_BURST 64U > -#define RTE_BNXT_DESCS_PER_LOOP 4U > - > #define TX_BD_FLAGS_CMPL ((1 << TX_BD_LONG_FLAGS_BD_CNT_SFT) | \ > TX_BD_SHORT_FLAGS_COAL_NOW | \ > TX_BD_SHORT_TYPE_TX_BD_SHORT | \ > diff --git a/drivers/net/bnxt/bnxt_txq.c b/drivers/net/bnxt/bnxt_txq.c > index 42930abbf..bdc7ffaaa 100644 > --- a/drivers/net/bnxt/bnxt_txq.c > +++ b/drivers/net/bnxt/bnxt_txq.c > @@ -11,7 +11,6 @@ > #include "bnxt_ring.h" > #include "bnxt_txq.h" > #include "bnxt_txr.h" > -#include "bnxt_rxtx_vec_common.h" > > /* > * TX Queues > diff --git a/drivers/net/bnxt/bnxt_txq.h b/drivers/net/bnxt/bnxt_txq.h > index 83a98536d..9f849fc71 100644 > --- a/drivers/net/bnxt/bnxt_txq.h > +++ b/drivers/net/bnxt/bnxt_txq.h > @@ -6,6 +6,9 @@ > #ifndef _BNXT_TXQ_H_ > #define _BNXT_TXQ_H_ > > +/* Maximum transmit burst for vector mode. */ > +#define RTE_BNXT_MAX_TX_BURST 64U > + > struct bnxt_tx_ring_info; > struct bnxt_cp_ring_info; > struct bnxt_tx_queue { > -- > 2.25.1 > >