From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55137A0093; Thu, 21 May 2020 00:08:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8464F1C1FB; Thu, 21 May 2020 00:08:29 +0200 (CEST) Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by dpdk.org (Postfix) with ESMTP id 22B911C1AB for ; Thu, 21 May 2020 00:08:28 +0200 (CEST) Received: by mail-ot1-f67.google.com with SMTP id o13so3854119otl.5 for ; Wed, 20 May 2020 15:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qi3ZbTefjYDPAtDAFFPe+QHCehV7CJMf6+IA4o4aug8=; b=bjLIOdm4onl76tVzKDykjecNVfEzejoeuzbUzbj5Z847EhQIiscfQDPhDD550Ia4cq C8ToaUHVaBBpevjxF6XI/4MtJ5onXrkdei0ZyqWZpv8QoJvO24xb2eqTxHQY688p8foS P4zW1uhLRAjkgQp5SD6Y1Vcdic1B6IfOxX1Tg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qi3ZbTefjYDPAtDAFFPe+QHCehV7CJMf6+IA4o4aug8=; b=oEfcWGaJaThXw2fk25M+s+Ub12cKllHHnQXzmt6lmF3rOV19mbhDYcuk4hOVBEW9lx 7o3wLUpBEIihfbqLo2nX9q1ROx51RLZc1V++x1+cyDfi6R4gR+AbvRusUfICq/dtQ7qR g8+NFtr9o1bT7RwMHysFYhkaB1FdibHQU6qEfAkDjkGmaUskDROjQakJupexB3M6OGM2 6eGNMblA+ywAHfcEXOBo9ZdvmeEP1BSgoMbjK3TqGIYBk+b+o5zwb/x08GyW4TZ5tPR7 Meb1TLpT74DNg2CjU7sHNy1Bzv9rUrwM7GfIYz8zXucI3lRcD4ST2r63O3nzKuNy2CFM ycPA== X-Gm-Message-State: AOAM5318qh0kXA/2WobfONMvOSdJVoNiqrbJYBPPrunxUks+ebUCK/yz qZQ6WEX4uwodri3ZFT1rST3K5q9mWhk61bQkRUHP8w== X-Google-Smtp-Source: ABdhPJynHKQSc5zclkIvivaOlQNhr0EmaOEfdZ8WTJ7y62WXhFhKIYl3nxM1AV8PiRvrjCmALFsdM5x3nqUGHaVIymo= X-Received: by 2002:a9d:10b:: with SMTP id 11mr4490754otu.95.1590012507001; Wed, 20 May 2020 15:08:27 -0700 (PDT) MIME-Version: 1.0 References: <20200520173918.13969-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20200520173918.13969-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Wed, 20 May 2020 15:08:10 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix to advance producer index X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 20, 2020 at 10:23 AM Kalesh A P < kalesh-anakkur.purayil@broadcom.com> wrote: > From: Rahul Gupta > > When a queue is started after deferred_start, then increment raw_prod > irrespective of new mbuf is allocated or old mbufs are used. > > Fixes: d256c73c1122 ("net/bnxt: fix memory leak during queue restart") > Cc: stable@dpdk.org > > Signed-off-by: Rahul Gupta > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit Khaparde > Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_rxr.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index d2955ba..ee1acb1 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -987,9 +987,9 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq) > rxq->queue_id, i, > ring->ring_size); > break; > } > - rxr->rx_prod = prod; > - prod = RING_NEXT(rxr->rx_ring_struct, prod); > } > + rxr->rx_prod = prod; > + prod = RING_NEXT(rxr->rx_ring_struct, prod); > } > > ring = rxr->ag_ring_struct; > @@ -1005,9 +1005,9 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq) > rxq->queue_id, i, > ring->ring_size); > break; > } > - rxr->ag_prod = prod; > - prod = RING_NEXT(rxr->ag_ring_struct, prod); > } > + rxr->ag_prod = prod; > + prod = RING_NEXT(rxr->ag_ring_struct, prod); > } > PMD_DRV_LOG(DEBUG, "AGG Done!\n"); > > -- > 2.10.1 > >