From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C442CA04A7; Tue, 5 May 2020 19:00:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 975401C1A9; Tue, 5 May 2020 19:00:22 +0200 (CEST) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by dpdk.org (Postfix) with ESMTP id 5483E1BFD9 for ; Tue, 5 May 2020 19:00:21 +0200 (CEST) Received: by mail-ot1-f66.google.com with SMTP id g19so2278266otk.5 for ; Tue, 05 May 2020 10:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=njywxi81w8VTBwyMtwwwuQ5oL8jFR9eCy5kKHzbIXow=; b=SePwkZRPzONULQ8QlnNPWYa++44FogMaqsmZb8bFossVbA+VQ2FRdWIuUOJGelpiAn iM03yNu1i3DV+J1BA9abBzmdlyz1VzkMIlha3zSJd9ETYSYUumdUhqLJ5O1k/vCDLZJL p069tUOxn7F9RvuPCddOFPmYLCbtkxVUXPMpQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=njywxi81w8VTBwyMtwwwuQ5oL8jFR9eCy5kKHzbIXow=; b=gWYRqnlm70z6Fl0ZwQXncmUMCpzhehVMurDDujW+djkl8aUTam8u5spsQbyb/wc88E 0Zks2p7cXvXLrAThYF1XNemNWTNwJUs2BWACkuAJ4wWS7MIOQnMIumFywwIXzeNjlh/k CArEglXFWOIoAOPvJHtHOySBlnDZ0Og/+MvCsEFr1TUn0gXxLOazLMk6Dw0kv9RaN0+U uqjGEfQjWuRPoaDcGau0RNDOLNougAtz6Kd1IkHFMwG1ePa1HCb60Q29s0knPV5+kxU5 Rhudmq3Pn1DfPrjlGzrzQM0lT/YJxwCfVfgJmnE69i4/ZGK8BKJfWtW8irRGJckK4zX8 vUmQ== X-Gm-Message-State: AGi0PuYJ98GVpywaFcsWDOE7KEG3MhPN2xvzMXRozZczHGBBQxb8hRz3 PycqZsN5i9YYbVGdnCk34ZSyWDC5eX6hcN6+yF5teQ== X-Google-Smtp-Source: APiQypI/WuuMPKW2SweOZ0D1NR/wfPO2b2JoZ3pOvzHf9CLUym7ES3Kw3vaJvIoyfdWV31s9tNyaeZ89+sm5acTc3+I= X-Received: by 2002:a05:6830:1613:: with SMTP id g19mr2770254otr.95.1588698020430; Tue, 05 May 2020 10:00:20 -0700 (PDT) MIME-Version: 1.0 References: <20200505040337.34463-1-ajit.khaparde@broadcom.com> In-Reply-To: From: Ajit Khaparde Date: Tue, 5 May 2020 10:00:04 -0700 Message-ID: To: Kevin Traynor Cc: dpdk-dev , Randy Schacher , Peter Spreadborough Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix build with gcc10 default fno-common X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 5, 2020 at 7:56 AM Kevin Traynor wrote: > On 05/05/2020 05:03, Ajit Khaparde wrote: > > From: Randy Schacher > > > > Remove the defensive compile-time checker macro. > > > > Thanks Ajit/Randy. This removes the error for bnxt on my Fedora 32 system. > > Was chatting to David and he suggest if 'static __rte_used' could be > added to the macro as an alternative. > > Checked and it [1] is working also. It seems like a cleaner fix for the > specific issue to me. If you have an additional reason to remove the > compile checks, it could be a separate patch or a comment added to the > commit message. > > [1] > --- a/drivers/net/bnxt/tf_core/hwrm_tf.h > +++ b/drivers/net/bnxt/tf_core/hwrm_tf.h > @@ -40,5 +40,5 @@ typedef enum tf_subtype { > > #define __BUILD_BUG_ON(condition, line) \ > - char p##line[(condition) ? 1 : -1] > + static __rte_unused char p##line[(condition) ? 1 : -1] > > > Bugzilla ID: 468 > > Fixes: 8430a8b841c8 ("net/bnxt: add initial TruFlow core session open") > > Signed-off-by: Randy Schacher > > Reviewed-by: Peter Spreadborough > > Reviewed-by: Ajit Khaparde > Patch applied to dpdk-next-net-brcm. Thanks > >