From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 757CAA0524; Mon, 3 May 2021 00:33:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6384041101; Mon, 3 May 2021 00:33:48 +0200 (CEST) Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by mails.dpdk.org (Postfix) with ESMTP id 11423410FC for ; Mon, 3 May 2021 00:33:47 +0200 (CEST) Received: by mail-qt1-f173.google.com with SMTP id n22so2479374qtk.9 for ; Sun, 02 May 2021 15:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hKccTKdTFo3/hxTLlF7eIJ2l3A2cpuCHXrjTj5tzpgI=; b=MfyHEgsNGX3KL+evLBuvR+MZCA1kLPPcuy3SsUlNnUxjkpwkn0UWz8M5Ahst7rg9dG CY1aWThjPZBrpYBhMz3wnELki/+App88yfv5ZBLWYadpb7i7G07UCvMvbKEcxjDips81 Hbi3lOWNzg5Pwyfe7EdXEA6PHFO9+v+VuVDpE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hKccTKdTFo3/hxTLlF7eIJ2l3A2cpuCHXrjTj5tzpgI=; b=tIhVofgUgJwQJGYbmPWEhYWaCXyhTMmo30S3leadPn5L7n7CTECxFkaDeVsSewuVUy WiOhPB6JttkM8kxKxLZ5ZzcVggPSCEe3WohB7aA398YdzcQleI/EGrhgxgfHM4gHieUE b94WbSxuq1ZGmPxyTEDkKsS7y7WhGwgclSNevJvmaJEDnWyujPtAQpaa4e0A/KCWFqu0 HSGRZ0HXYzaPiAxpYlNnipWvLptYzr2pZq0C6yGJ3F/b33kvqE0VNsOOao/yLnTnJagO vEi+qhhIwzw2R3LxUXu3iT3kL1YGsosYqS+OojN3ZaZrHetc2LTsGsfalnINLBRfA5x0 1a5g== X-Gm-Message-State: AOAM533na1b2nb5h3unFTqLqdpYQmxW4kXR0ZrYcgbtPfT/BpCVk5qLj XpYp1bkU9RE+s8nXfzUtvhOyzjKd2U0P04/U9r9iu0TuSKU28A== X-Google-Smtp-Source: ABdhPJwGLBccPJtMelB2fSh7C4VOOH3ZvkpSDPNNNrx0dVC1xGwls9siSsFtCxzD9QHo30jICGnumQ+wSsvrTEuqS+M= X-Received: by 2002:ac8:5e0b:: with SMTP id h11mr14680642qtx.194.1619994826418; Sun, 02 May 2021 15:33:46 -0700 (PDT) MIME-Version: 1.0 References: <20210429055300.18326-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20210429055300.18326-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Sun, 2 May 2021 15:33:30 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000002f808705c1607053" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix check for single PF per port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000002f808705c1607053 Content-Type: text/plain; charset="UTF-8" On Wed, Apr 28, 2021 at 10:31 PM Kalesh A P < kalesh-anakkur.purayil@broadcom.com> wrote: > From: Kalesh AP > > The check BNXT_SINGLE_PF(bp) returns false for a VF. So there is no > extra check needed for VF along with BNXT_SINGLE_PF(bp). > > Also make error messages more explicit. > > Fixes: ff947c6ce15f ("net/bnxt: add check for multi host PF per port") > Fixes: f86febfb46da ("net/bnxt: support VF") > Fixes: 3e12fdb78e82 ("net/bnxt: support VLAN pvid") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit Kumar Khaparde > Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_ethdev.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > index f5d2dc8..50cb12d 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -2197,8 +2197,9 @@ static int bnxt_flow_ctrl_set_op(struct rte_eth_dev > *dev, > if (rc) > return rc; > > - if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) { > - PMD_DRV_LOG(ERR, "Flow Control Settings cannot be > modified\n"); > + if (!BNXT_SINGLE_PF(bp)) { > + PMD_DRV_LOG(ERR, > + "Flow Control Settings cannot be modified on > VF or on shared PF\n"); > return -ENOTSUP; > } > > @@ -2992,9 +2993,8 @@ bnxt_vlan_pvid_set_op(struct rte_eth_dev *dev, > uint16_t pvid, int on) > if (rc) > return rc; > > - if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) { > - PMD_DRV_LOG(ERR, > - "PVID cannot be modified for this function\n"); > + if (!BNXT_SINGLE_PF(bp)) { > + PMD_DRV_LOG(ERR, "PVID cannot be modified on VF or on > shared PF\n"); > return -ENOTSUP; > } > bp->vlan = on ? pvid : 0; > -- > 2.10.1 > > --0000000000002f808705c1607053--