[dpdk-dev] [PATCH] net/bnxt: fix check for single PF per port

[dpdk-dev] [PATCH] net/bnxt: fix check for single PF per port

[Kalesh A P]

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

The check BNXT_SINGLE_PF(bp) returns false for a VF. So there is no
extra check needed for VF along with BNXT_SINGLE_PF(bp).

Also make error messages more explicit.

Fixes: ff947c6ce15f ("net/bnxt: add check for multi host PF per port")
Fixes: f86febfb46da ("net/bnxt: support VF")
Fixes: 3e12fdb78e82 ("net/bnxt: support VLAN pvid")
Cc: stable@dpdk.org

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index f5d2dc8..50cb12d 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -2197,8 +2197,9 @@ static int bnxt_flow_ctrl_set_op(struct rte_eth_dev *dev,
 	if (rc)
 		return rc;
 
-	if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
-		PMD_DRV_LOG(ERR, "Flow Control Settings cannot be modified\n");
+	if (!BNXT_SINGLE_PF(bp)) {
+		PMD_DRV_LOG(ERR,
+			    "Flow Control Settings cannot be modified on VF or on shared PF\n");
 		return -ENOTSUP;
 	}
 
@@ -2992,9 +2993,8 @@ bnxt_vlan_pvid_set_op(struct rte_eth_dev *dev, uint16_t pvid, int on)
 	if (rc)
 		return rc;
 
-	if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
-		PMD_DRV_LOG(ERR,
-			"PVID cannot be modified for this function\n");
+	if (!BNXT_SINGLE_PF(bp)) {
+		PMD_DRV_LOG(ERR, "PVID cannot be modified on VF or on shared PF\n");
 		return -ENOTSUP;
 	}
 	bp->vlan = on ? pvid : 0;
-- 
2.10.1

Re: [dpdk-dev] [PATCH] net/bnxt: fix check for single PF per port

[Ajit Khaparde]

[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]

On Wed, Apr 28, 2021 at 10:31 PM Kalesh A P <
kalesh-anakkur.purayil@broadcom.com> wrote:

> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> The check BNXT_SINGLE_PF(bp) returns false for a VF. So there is no
> extra check needed for VF along with BNXT_SINGLE_PF(bp).
>
> Also make error messages more explicit.
>
> Fixes: ff947c6ce15f ("net/bnxt: add check for multi host PF per port")
> Fixes: f86febfb46da ("net/bnxt: support VF")
> Fixes: 3e12fdb78e82 ("net/bnxt: support VLAN pvid")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
>
Patch applied to dpdk-next-net-brcm. Thanks



> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index f5d2dc8..50cb12d 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -2197,8 +2197,9 @@ static int bnxt_flow_ctrl_set_op(struct rte_eth_dev
> *dev,
>         if (rc)
>                 return rc;
>
> -       if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
> -               PMD_DRV_LOG(ERR, "Flow Control Settings cannot be
> modified\n");
> +       if (!BNXT_SINGLE_PF(bp)) {
> +               PMD_DRV_LOG(ERR,
> +                           "Flow Control Settings cannot be modified on
> VF or on shared PF\n");
>                 return -ENOTSUP;
>         }
>
> @@ -2992,9 +2993,8 @@ bnxt_vlan_pvid_set_op(struct rte_eth_dev *dev,
> uint16_t pvid, int on)
>         if (rc)
>                 return rc;
>
> -       if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
> -               PMD_DRV_LOG(ERR,
> -                       "PVID cannot be modified for this function\n");
> +       if (!BNXT_SINGLE_PF(bp)) {
> +               PMD_DRV_LOG(ERR, "PVID cannot be modified on VF or on
> shared PF\n");
>                 return -ENOTSUP;
>         }
>         bp->vlan = on ? pvid : 0;
> --
> 2.10.1
>
>