From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id D9804A0C53;
Wed, 3 Nov 2021 14:36:04 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 5897642715;
Wed, 3 Nov 2021 14:36:04 +0100 (CET)
Received: from mail-io1-f52.google.com (mail-io1-f52.google.com
[209.85.166.52]) by mails.dpdk.org (Postfix) with ESMTP id CE763426F6
for <dev@dpdk.org>; Wed, 3 Nov 2021 14:36:02 +0100 (CET)
Received: by mail-io1-f52.google.com with SMTP id y73so2762372iof.4
for <dev@dpdk.org>; Wed, 03 Nov 2021 06:36:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=2H6r6Cnlb81oT8M0PKDb4KG2IqF3e+U1+tCyb3jv9EA=;
b=NCE5/n+KrmxLx3u1WZCr9uQ0FqwCte7KfmFXZXszSV75XTPZ8P0cS5fl20qpXqNcHf
LeNWoyUXoJwx9FOELh7DX9sn4GI6cKzIjV1DdUnxY5fkfx2qBRgjlAmzx/wl/pWENSdQ
eT7tfwQj9YJMrKF5s+8Q75KVJphFevcwHT4qQ=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=2H6r6Cnlb81oT8M0PKDb4KG2IqF3e+U1+tCyb3jv9EA=;
b=Tif6dpB79JKMahdSvnUvoi288t54TuPM4VBU4YaDYC0+gU86Agn7/XmkfeOQvHKKOl
P943T0AilY6fD82TvZ7D6sGstBfND2R9N3oNwcAs8Yf66YAZaS+9SzBqWcv+0+9Q85HJ
qAgLBccaK6JMzeYHNmU064boOwmuvj3ET3K/SW1/g3GySsWdUC2AMEMeuHGXpeoUhaxM
YOVfy8Mv8aI+TXx4Gnnb+RV4f7GwreCVHqh71JX6EpYyIL2puKrYYqHegCCVmIxrUBva
kYNa9GFBHJyZghZXeuDsmsOTosrFgZQNyd7SK8Xgeoy8dsT8p0CdsZmnGQQQFgKTD7hX
82Jg==
X-Gm-Message-State: AOAM533gKMR6PYAFpyLxsQw88Pm20JpDGMD3VJEY1Li7sBetdotKYZfJ
JvemoLJf/ZGVZWskobkC1MZwnpb9Ywsgm59FS3dLOg==
X-Google-Smtp-Source: ABdhPJwBTIkI/rc1LhXHvfLToRvA2T/z0SrxtHk5i/SZcdekIArKhYxLXzNi41RKIOUMOgWr6xDrhiJ3RLrhYAJaH0k=
X-Received: by 2002:a5d:878e:: with SMTP id f14mr31683061ion.111.1635946562138;
Wed, 03 Nov 2021 06:36:02 -0700 (PDT)
MIME-Version: 1.0
References: <20211102040556.7840-1-venkatkumar.duvvuru@broadcom.com>
<20211103005251.25524-1-ajit.khaparde@broadcom.com>
<20211103005251.25524-11-ajit.khaparde@broadcom.com>
<7853ffe7-511b-7ac3-c0fc-850dbc5ba4f8@intel.com>
In-Reply-To: <7853ffe7-511b-7ac3-c0fc-850dbc5ba4f8@intel.com>
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: Wed, 3 Nov 2021 06:35:45 -0700
Message-ID: <CACZ4nhtBnaEwTJSA==wuy5UJx7DBSK5PEksD_Y2UFm-Um=8H0A@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dpdk-dev <dev@dpdk.org>,
Kishore Padmanabha <kishore.padmanabha@broadcom.com>,
Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,
Mike Baucom <michael.baucom@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v4 10/20] net/bnxt: remove devargs for stats
accumulation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Wed, Nov 3, 2021 at 6:24 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 11/3/2021 12:52 AM, Ajit Khaparde wrote:
> > From: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
> >
> > The accumulation of flow counters is not determined by the
> > application device arguments anymore. Instead it is now dictated by
> > the platform capabilities whether to do software based accumulation or not.
> >
> > Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
> > Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
> > Reviewed-by: Mike Baucom <michael.baucom@broadcom.com>
> > Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> <...>
>
> > @@ -87,7 +87,6 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {
> > { .vendor_id = 0, /* sentinel */ },
> > };
> >
> > -#define BNXT_DEVARG_ACCUM_STATS "accum-stats"
> > #define BNXT_DEVARG_FLOW_XSTAT "flow-xstat"
> > #define BNXT_DEVARG_MAX_NUM_KFLOWS "max-num-kflows"
> > #define BNXT_DEVARG_REPRESENTOR "representor"
>
> Hi Ajit,
>
> Not for this patch, but I recognized that runtime devargs for the driver
> is not documented at all.
>
> Can you please have a separate patch to document them in bnxt.rst?
Hi Freeuh,
Yes. I am working on that.