From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48F7EA0540; Tue, 24 May 2022 18:25:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D539C400EF; Tue, 24 May 2022 18:25:14 +0200 (CEST) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by mails.dpdk.org (Postfix) with ESMTP id 796F2400D6 for ; Tue, 24 May 2022 18:25:13 +0200 (CEST) Received: by mail-io1-f41.google.com with SMTP id 2so9032700iou.5 for ; Tue, 24 May 2022 09:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Os/q2ExnegxVybzJbLJZJypWf1gQV3hbWIIhChYOKl8=; b=gYfCeB+UIhmqIwg6NRSJ2mQy9GGXKkYyu1NiKYPhcZ9zmnFGJlrb0bEqqbo5Utn2wO tYFbG09057t30lIZtv+Lww4BHq7a9df/z806taFiOIWfxP+KxgI/EU8Qhf0LDRL/SVC9 xfLtqeQdoB6sxrOVVrFeLNq06djUtc+KKt8NU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Os/q2ExnegxVybzJbLJZJypWf1gQV3hbWIIhChYOKl8=; b=THDcddYA1QQBXCRQTMiRQVN8wCphNtUy6SkNY6hSbjiVBNkBo5B6RFGBnuOeI43BEH sLOJRPXZt7PDjy5BHC+p++nYCfzNh3J5cZ7+1EQK6W+hP5gACQtJMmxFcN8CrXDn9sKR Y+m68uLK3l7NLO2WxgR6kWTRNLOlE21aqYdQo+NfHMNW+DWKUNm2gnXD1U1qYKt/M3h3 PEPBhwQFwWEubPFZ7l881iWVDz6n+LkhHmOOaWBGAK/7gePI+W45x1vw+seZYjX53xmZ wuP2yqcM4HSGn4OK5KMUIKCrBrhrgNuYfRFszfdEaGJe5oco8iWjU8EuhdMzpdIalnbC UvvA== X-Gm-Message-State: AOAM531eGyDQlv7ZVr+9g6zf6kSp29qfe6wwWTAzTguaKxm9KBMM19tQ 1yvs9cb6YWxmGp+VeK43VOr0WNYvq+7qgy1oybgJOg== X-Google-Smtp-Source: ABdhPJxCFQd27FBTePRN5TZhmkqAr8bPf2HYf/Ujtc/OIeqcU+bjr2AH25fahjimcqvsGRtBJDyBiuD3JJrswH1imHs= X-Received: by 2002:a6b:fa13:0:b0:64f:d480:30d3 with SMTP id p19-20020a6bfa13000000b0064fd48030d3mr12776594ioh.179.1653409512738; Tue, 24 May 2022 09:25:12 -0700 (PDT) MIME-Version: 1.0 References: <20201009111130.10422-1-somnath.kotur@broadcom.com> <20201010041153.63921-1-ajit.khaparde@broadcom.com> <20201010041153.63921-7-ajit.khaparde@broadcom.com> In-Reply-To: From: Ajit Khaparde Date: Tue, 24 May 2022 09:24:56 -0700 Message-ID: Subject: Re: [dpdk-dev] [PATCH v2 06/12] net/bnxt: combine default and regular flows To: Ferruh Yigit Cc: Kishore Padmanabha , Mike Baucom , Thomas Monjalon , David Marchand , dpdk-dev Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000b160a605dfc46627" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000b160a605dfc46627 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, May 24, 2022 at 8:32 AM Ferruh Yigit wrote: > > On 10/10/2020 5:11 AM, Ajit Khaparde wrote: > > From: Kishore Padmanabha > > > > The default and regular flows are stored in the same flow table > > instead of different flow tables. This should help code reuse > > and reducing the number of allocations. > > So combine default and regular flows in flow database. > > > > Signed-off-by: Kishore Padmanabha > > Reviewed-by: Mike Baucom > > Reviewed-by: Ajit Khaparde > > <...> > > > * > > * returns 0 on success or negative number on failure > > */ > > -int32_t ulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx, > > - uint32_t idx) > > +int32_t > > +ulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx, > > + enum bnxt_ulp_fdb_type flow_type) > > > Above change is causing build error [1] because the function declaration > [2] differs from definition. Reproduced by latest gcc [3]. > > [1] > ../drivers/net/bnxt/tf_ulp/ulp_flow_db.c:962:1: error: conflicting types > for =E2=80=98ulp_flow_db_flush_flows=E2=80=99 due to enum/integer mismatc= h; > have =E2=80=98int32_t(struct bnxt_ulp_context *, enum bnxt_ulp_fdb_type)= =E2=80=99 > {aka =E2=80=98int(struct bnxt_ulp_context *, enum bnxt_ulp_fdb_type)=E2= =80=99} > [-Werror=3Denum-int-mismatch] > 962 | ulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx, > | ^~~~~~~~~~~~~~~~~~~~~~~ > In file included from ../drivers/net/bnxt/tf_ulp/ulp_flow_db.c:12: > ../drivers/net/bnxt/tf_ulp/ulp_flow_db.h:211:1: note: previous > declaration of =E2=80=98ulp_flow_db_flush_flows=E2=80=99 with type =E2=80= =98int32_t(struct > bnxt_ulp_context *,uint32_t)=E2=80=99 {aka =E2=80=98int(struct bnxt_ulp_c= ontext *, > unsigned int)=E2=80=99} > 211 | ulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx, > | ^~~~~~~~~~~~~~~~~~~~~~~ > > > [2] > > +ulp_flow_db_flush_flows(struct bnxt_ulp_context *ulp_ctx, > > + uint32_t idx); > > > > > [3] > gcc 13.0.0 "gcc (GCC) 13.0.0 20220524 (experimental)") Bleeding edge gcc. Thanks Ferruh. We will take a look at this. --000000000000b160a605dfc46627 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDBCmE9BT7srhoNHDEDANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDE4MjdaFw0yMjA5MjIxNDUxNDlaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEAwXsxfYF9jpj9zve1vXxD491SrWDVlcmLMdnOS1c7POMC8lbbgvp1o2kIu/3n xCVFTai5H6rHZgrFItNNVZ+XaJW9Ob9eiSuXdnAu5gVdTb+IFAf4S/PT2LXzpP07M7vyvm/yvA+8 HtVfapzqqTNYdNVUpq28MYsKEWbnyK94x5+C3oCAV4bpNnMoPNtKrMhvOdpTREQRyew8hyy3/Mz7 RIaCW0xx+14NTQe17dkH6CEEpmCjejneq/FU0gmbuorwHoP9mOiqeh23/ZKVpmFO/eiDtvMNAMDW 6LzhOk/pMklUPTHu/gQNW3OQebyhyFUHiBSp8rDkfWZT57Asd0PtdQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUPHif0ihgndR0 h7r3sANaOIu2yM8wDQYJKoZIhvcNAQELBQADggEBAAEuLXDnP0Xd2zAMpQobXLUyqbpqGMO6ycQc Xq4H2YYlSNKVwPA+ZAVdUOzbSimBKlx8mzAEHkI3Ll1yXlYeT4UwkfWV9fioyGuQelLN1sGzi5bm WEpaSIbR1eiJMtzxUPwpRTn19gHZVueIot2Gw0fEYgHiMJpUr6xBWv2QNXULu/E8qvbXIRh2iycq 5rWFggX/JHglO8nVqzb1ImzqzVMFnDN15h3j8ryy2MIvZ8VDQRP7l81IXaTvVwaKpWMgV6rfQOi6 aOQZuOKkad7qoCkS5N2oSsvxi+rZtDaJJNsDjs05y5JZZQtBlfAmdYS+mmvkPjZ1iaLTzk59o/Yo fNkxggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwQphPQ U+7K4aDRwxAwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEINVh4rSNj3QsklsLnrBd 4kXoEToBxlsr2HhOuDII7u40MBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIyMDUyNDE2MjUxM1owaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQC0hz+bxfIjbfnEUu6HK/ODLq3T+yaUeQWgB4tk IoMvtRn0GophUtQwyf5DTnIFOdWsT2FPq/0SL7MLnCeNDGWragOD5m7nnAFOA8RO1kagLMajTmAz 7iDOsy1Ym9j+RHtpyU0O5oC6AJxGH7Vk8Nbq+7Szz4Ll2R6Y/rOQDjkBTvg0priyV8YEmwU41wJl vDYn6/9SYCrYnxrTciFtqq03pWy6aGcu+DX3A9M6dsy/FOKeVhtqvfC1FNmS+Ow5Iy6b4qGf53s5 aG5L4MQvHXVJ0POL8G2YNPL7wYXhxjNGOUstSUqn2wkpKE54bINnpTrPG8RKF5TwQgs2BBeh18tb --000000000000b160a605dfc46627--