From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2981A0562; Fri, 19 Mar 2021 04:56:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E0DA140E9D; Fri, 19 Mar 2021 04:56:53 +0100 (CET) Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by mails.dpdk.org (Postfix) with ESMTP id A1C2840143 for ; Fri, 19 Mar 2021 04:56:52 +0100 (CET) Received: by mail-qt1-f172.google.com with SMTP id c6so5843575qtc.1 for ; Thu, 18 Mar 2021 20:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=roappsyp02z8EDjygn20e5uSyYMjjTp0F9yHiXApFNU=; b=Q36UqcD82RrjuPDESimO26gbLoHGq2phGwwJxrJVHdaRZYbQsBHs27P1ut3esGO3X1 EIdr9yaDB14jm2+vXX9L5+2nJ7oZPZEYJpFj8wdWo8oISofGsqdIzQbxTOPXQQZLxyJP F9k4gEtW7kMCwBfZP5CnczDZg7aml+IswD4YA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=roappsyp02z8EDjygn20e5uSyYMjjTp0F9yHiXApFNU=; b=ONyNfB44Kibjx/8phPDMD3/qM1P7+wlYAq2qE2d60XGHVWm7j+j2QBenlVJW68K+K3 bPYQe+HpaCzUGAcKCDuJI59Us9qjNWqOK87MOA/vFWhL/dWawN4K+4OoPbFxj5gL3J3V AfB+ZeSVO2jTlevjXQTlTOGyfyORErotp1Rb8Ee9BpOIxRBxQlrPsB1ozUBiclXEZZ9n glyavCzuk0AyOZMrLl0FGHMzyGlOaXPWRXwLNyudNE8XI3tJsfiopUf+/CWP+I76Rx11 ivbpjPspR4RHD/20a9MKbc43nkHZmwQn8UFTpDxmipmOt6TXwddyNeDyttZioIF76VlI gydg== X-Gm-Message-State: AOAM532UZ0iDJf1u94UIG8pScyPceiXFzK+kGM3k+wI19tsi1sdBO8eF TB6NUOA7vEvPzPtTmu/e6RNp2rvJdJwB/O1nzlOf0TKgSA689TSO X-Google-Smtp-Source: ABdhPJxlHC3V1zJ9TQTwCmY/1OF1ztEVIDUXlUblB/uZV+Evcl0ejh3KWVVxQdv+Urb+lw64aTEQ5ewO48ghBpRnhvw= X-Received: by 2002:ac8:5047:: with SMTP id h7mr6894716qtm.22.1616126211695; Thu, 18 Mar 2021 20:56:51 -0700 (PDT) MIME-Version: 1.0 References: <20210319001709.77261-1-ajit.khaparde@broadcom.com> In-Reply-To: <20210319001709.77261-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Thu, 18 Mar 2021 20:56:35 -0700 Message-ID: To: dpdk-dev Cc: dpdk stable , Lance Richardson Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000c7c57405bddbb46c" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: check return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000c7c57405bddbb46c Content-Type: text/plain; charset="UTF-8" On Thu, Mar 18, 2021 at 5:17 PM Ajit Khaparde wrote: > > Check return value of rte_kvargs_process() > > Coverity issue: 357765 > > Fixes: ba404aacc5cf ("net/bnxt: set maximum flow count") > Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats") > Fixes: 7b0940653720 ("net/bnxt: support host memory based TruFlow") > > Cc: stable@dpdk.org > > Signed-off-by: Ajit Khaparde > Reviewed-by: Lance Richardson Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_ethdev.c | 31 +++++++++++++++++++++---------- > 1 file changed, 21 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 1990d65c29..930e7e83f4 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -5477,40 +5477,49 @@ bnxt_parse_devarg_rep_fc_f2r(__rte_unused const char *key, > return 0; > } > > -static void > +static int > bnxt_parse_dev_args(struct bnxt *bp, struct rte_devargs *devargs) > { > struct rte_kvargs *kvlist; > + int ret; > > if (devargs == NULL) > - return; > + return 0; > > kvlist = rte_kvargs_parse(devargs->args, bnxt_dev_args); > if (kvlist == NULL) > - return; > + return -EINVAL; > > /* > * Handler for "truflow" devarg. > * Invoked as for ex: "-a 0000:00:0d.0,host-based-truflow=1" > */ > - rte_kvargs_process(kvlist, BNXT_DEVARG_TRUFLOW, > - bnxt_parse_devarg_truflow, bp); > + ret = rte_kvargs_process(kvlist, BNXT_DEVARG_TRUFLOW, > + bnxt_parse_devarg_truflow, bp); > + if (ret) > + goto err; > > /* > * Handler for "flow_xstat" devarg. > * Invoked as for ex: "-a 0000:00:0d.0,flow_xstat=1" > */ > - rte_kvargs_process(kvlist, BNXT_DEVARG_FLOW_XSTAT, > - bnxt_parse_devarg_flow_xstat, bp); > + ret = rte_kvargs_process(kvlist, BNXT_DEVARG_FLOW_XSTAT, > + bnxt_parse_devarg_flow_xstat, bp); > + if (ret) > + goto err; > > /* > * Handler for "max_num_kflows" devarg. > * Invoked as for ex: "-a 000:00:0d.0,max_num_kflows=32" > */ > - rte_kvargs_process(kvlist, BNXT_DEVARG_MAX_NUM_KFLOWS, > - bnxt_parse_devarg_max_num_kflows, bp); > + ret = rte_kvargs_process(kvlist, BNXT_DEVARG_MAX_NUM_KFLOWS, > + bnxt_parse_devarg_max_num_kflows, bp); > + if (ret) > + goto err; > > +err: > rte_kvargs_free(kvlist); > + return ret; > } > > static int bnxt_alloc_switch_domain(struct bnxt *bp) > @@ -5645,7 +5654,9 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused) > bp = eth_dev->data->dev_private; > > /* Parse dev arguments passed on when starting the DPDK application. */ > - bnxt_parse_dev_args(bp, pci_dev->device.devargs); > + rc = bnxt_parse_dev_args(bp, pci_dev->device.devargs); > + if (rc) > + goto error_free; > > rc = bnxt_drv_init(eth_dev); > if (rc) > -- > 2.21.1 (Apple Git-122.3) > --000000000000c7c57405bddbb46c--