From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Lance Richardson <lance.richardson@broadcom.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix vector mode for 32-bit x86
Date: Fri, 25 Sep 2020 17:58:20 -0700 [thread overview]
Message-ID: <CACZ4nhtLSm8gi7tQwG1miiAaAjkpmNJWOCWkCJVnQ001iBPeXg@mail.gmail.com> (raw)
In-Reply-To: <20200925214019.42504-1-lance.richardson@broadcom.com>
On Fri, Sep 25, 2020 at 2:40 PM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> Descriptor valid mask should be 64-bit all ones, use
> appropriate initializer type (unsigned long long) to
> obtain correct value in 32-bit mode.
>
> Fixes: deae85145c64 ("net/bnxt: handle multiple packets per loop in vector Rx")
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Patch applied to dpdk-next-net-brcm. Thanks
> ---
> drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> index 3a5a50afd8..271e7908e3 100644
> --- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> +++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> @@ -164,7 +164,7 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
> uint16_t cp_ring_size = cpr->cp_ring_struct->ring_size;
> uint16_t rx_ring_size = rxr->rx_ring_struct->ring_size;
> struct cmpl_base *cp_desc_ring = cpr->cp_desc_ring;
> - uint64_t valid, desc_valid_mask = ~0UL;
> + uint64_t valid, desc_valid_mask = ~0ULL;
> const __m128i info3_v_mask = _mm_set_epi32(CMPL_BASE_V, CMPL_BASE_V,
> CMPL_BASE_V, CMPL_BASE_V);
> uint32_t raw_cons = cpr->cp_raw_cons;
> --
> 2.25.1
>
prev parent reply other threads:[~2020-09-26 0:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 21:40 Lance Richardson
2020-09-26 0:58 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhtLSm8gi7tQwG1miiAaAjkpmNJWOCWkCJVnQ001iBPeXg@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=lance.richardson@broadcom.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).