From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jerin Jacob <jerinjacobk@gmail.com>,
Rasesh Mody <rmody@marvell.com>, dpdklab <dpdklab@iol.unh.edu>,
Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>,
GR-Everest-DPDK-Dev <GR-Everest-DPDK-Dev@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: fix to add QLogic vendor id
Date: Tue, 13 Oct 2020 14:36:51 -0700 [thread overview]
Message-ID: <CACZ4nhtNYRGn5k9BaQpN83czEeqdWHy1Ax38BA36WUDQPGGeDw@mail.gmail.com> (raw)
In-Reply-To: <c95b806c-b2db-debf-6422-715c23e0a389@intel.com>
On Tue, Oct 13, 2020 at 1:43 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 10/13/2020 7:28 PM, Jerin Jacob wrote:
> > On Tue, Oct 13, 2020 at 4:18 AM Rasesh Mody <rmody@marvell.com> wrote:
> >>
> >> Add QLogic vendor id support for BCM57840 device ids.
> >>
> >> Fixes: 9fb557035d90 ("bnx2x: enable PMD build")
> >> Cc: stable@dpdk.org
> >>
> >> Reported-by: Souvik Dey <sodey@rbbn.com>
> >> Signed-off-by: Rasesh Mody <rmody@marvell.com>
> >
> >
> > There was an error from CI on Broadcom CI,
> > Since this patch is about Broadcom PMD fix, Do we need to worry about this?
> > http://mails.dpdk.org/archives/test-report/2020-October/158246.html
> >
>
> Errors shouldn't be related to this patch, so I think error can be ignored for
> this patch.
+1
>
> But added Ajit & lab for the issue.
I have seen this behavior earlier.
It showed up randomly on some patches which are not even
related to Broadcom PMD. I will try to keep an eye on it.
>
> >
> >> ---
> >> drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
> >> index 40225b2f4..ce9df8748 100644
> >> --- a/drivers/net/bnx2x/bnx2x_ethdev.c
> >> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c
> >> @@ -17,6 +17,7 @@
> >> * The set of PCI devices this driver supports
> >> */
> >> #define BROADCOM_PCI_VENDOR_ID 0x14E4
> >> +#define QLOGIC_PCI_VENDOR_ID 0x1077
> >> static const struct rte_pci_id pci_id_bnx2x_map[] = {
> >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57800) },
> >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57711) },
> >> @@ -24,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = {
> >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) },
> >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) },
> >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) },
> >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) },
> >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) },
> >> #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT
> >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) },
> >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) },
> >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) },
> >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) },
> >> #endif
> >> { .vendor_id = 0, }
> >> };
> >> @@ -38,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = {
> >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) },
> >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) },
> >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) },
> >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) },
> >> { .vendor_id = 0, }
> >> };
> >>
> >> --
> >> 2.18.0
> >>
>
next prev parent reply other threads:[~2020-10-13 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 22:48 Rasesh Mody
2020-10-13 18:28 ` Jerin Jacob
2020-10-13 20:42 ` Ferruh Yigit
2020-10-13 21:36 ` Ajit Khaparde [this message]
2020-10-14 6:42 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhtNYRGn5k9BaQpN83czEeqdWHy1Ax38BA36WUDQPGGeDw@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=GR-Everest-DPDK-Dev@marvell.com \
--cc=dev@dpdk.org \
--cc=dpdklab@iol.unh.edu \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=rmody@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).